Skip to contentSkip to conversation

tty: serial: make SERIAL_SPRD depend on COMMON_CLK

PATCH New Chunyan Zhang 1 participant 1 message Mar 25, 2020 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tty: serial: make SERIAL_SPRD depend on COMMON_CLK

From: Chunyan Zhang <[email protected]>

kbuild-test reported an error:

config: mips-randconfig-a001-20200321 ...

Quoted 1 line
Quoted 1 line

drivers/tty/serial/sprd_serial.c:1175: undefined reference

to `clk_set_parent'

Because some mips Kconfig selects HAVE_CLK but not COMMON_CLK and no clk_set_parent implemented, so the error was exposed. So adding dependence on COMMON_CLK can fix this issue.

Fixes 7ba87cfec71a ("tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD")

---
Changes from v1:
* Change to depend on COMMON_CLK instead of ARM

---
 drivers/tty/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/tty/serial/Kconfig +1 -0
index b43dce785a58..ff942ca95b66 100644
@@ -1444,6 +1444,7 @@ config SERIAL_MEN_Z135
 config SERIAL_SPRD
 	tristate "Support for Spreadtrum serial"
 	select SERIAL_CORE
+	depends on COMMON_CLK
 	help
 	  This enables the driver for the Spreadtrum's serial.
 
Signature · 1 line
2.20.1