Skip to contentSkip to conversation

arm64: Make extension enablement consistent

PATCH In review Mark Brown 2 participants 4 messages Mar 25, 2020

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

cover arm64: Make extension enablement consistent

Currently we use a mix of .arch and .cpu to enable architecture extensions, make things consistent by converting the two instances of .cpu to .arch which is more common and a bit more idiomatic for our goal.

Mark Brown (2):
arm64: crypto: Consistently enable extension
arm64: lib: Consistently enable crc32 extension

 arch/arm64/crypto/crct10dif-ce-core.S | 2 +-
 arch/arm64/lib/crc32.S                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH 1/2 arm64: crypto: Consistently enable extension

Currently most of the crypto files enable the crypto extension using the .arch directive but crct10dif-ce-core.S uses .cpu instead. Move that over to .arch for consistency.

---
 arch/arm64/crypto/crct10dif-ce-core.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/crypto/crct10dif-ce-core.S +1 -1
index 5a95c2628fbf..111d9c9abddd 100644
@@ -66,7 +66,7 @@
 #include <asm/assembler.h>
 
 	.text
-	.cpu		generic+crypto
+	.arch		armv8-a+crypto
 
 	init_crc	.req	w19
 	buf		.req	x20
Signature · 1 line
2.20.1
author
#2 lore raw

PATCH 2/2 arm64: lib: Consistently enable crc32 extension

In reply to Mark Brown

Currently most of the assembly files that use architecture extensions enable them using the .arch directive but crc32.S uses .cpu instead. Move that over to .arch for consistency.

---
 arch/arm64/lib/crc32.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/lib/crc32.S +1 -1
index 243e107e9896..0f9e10ecda23 100644
@@ -9,7 +9,7 @@
 #include <asm/alternative.h>
 #include <asm/assembler.h>
 
-	.cpu		generic+crc
+	.arch		armv8-a+crc
 
 	.macro		__crc32, c
 	cmp		x2, #16
Signature · 1 line
2.20.1
Acked-by on the v1 series
#3 lore raw
In reply to Mark Brown
Quoted 10 lines · Mark Brown

Currently we use a mix of .arch and .cpu to enable architecture extensions, make things consistent by converting the two instances of .cpu to .arch which is more common and a bit more idiomatic for our goal.

Mark Brown (2):
arm64: crypto: Consistently enable extension
arm64: lib: Consistently enable crc32 extension

Quoted 7 lines
 arch/arm64/crypto/crct10dif-ce-core.S | 2 +-
 arch/arm64/lib/crc32.S                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.20.1