x86: acpi: Describe USB 3 host controller found on Intel Tangier
PATCH 1/1 x86: acpi: Describe USB 3 host controller found on Intel Tangier
USB 3 host controller may be described in ACPI to allow users alter the properties or other features. Describe it for Intel Tangier SoC.
Signed-off-by Andy Shevchenko <[email protected]>
--- .../asm/arch-tangier/acpi/southcluster.asl | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+)
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +38 -0
@@ -321,6 +321,44 @@ Device (PCI0) } } + Device (DWC3) + { + Name (_ADR, 0x00110000) + Name (_DEP, Package () + { + ^IPC1.PMIC + }) + + Method (_STA, 0, NotSerialized) + { + Return (STA_VISIBLE) + } + + Device (RHUB) + { + Name (_ADR, Zero) + + // GPLD: Generate Port Location Data (PLD) + Method (GPLD, 1, Serialized) { + Name (PCKG, Package () { + Buffer (0x10) {} + }) + + // REV: Revision 0x02 for ACPI 5.0 + CreateField (DerefOf (Index (PCKG, Zero)), Zero, 0x07, REV) + Store (0x02, REV) + + // VISI: Port visibility to user per port + CreateField (DerefOf (Index (PCKG, Zero)), 0x40, One, VISI) + Store (Arg0, VISI) + Return (PCKG) + } + + Device (HS01) { Name (_ADR, 1) } + Device (SS01) { Name (_ADR, 2) } + } + } + Device (PWM0) { Name (_ADR, 0x00170000)
Signature · 1 line
2.25.1
PATCH 1/1 x86: acpi: Describe USB 3 host controller found on Intel Tangier
Quoted 25 lines · Andy Shevchenko
USB 3 host controller may be described in ACPI to allow users alter the properties or other features. Describe it for Intel Tangier SoC.
Signed-off-by Andy Shevchenko <[email protected]>--- .../asm/arch-tangier/acpi/southcluster.asl | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+)arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +8
-0@@ -321,6 +321,44 @@ Device (PCI0) } } + Device (DWC3) + { + Name (_ADR, 0x00110000) + Name (_DEP, Package () + { + ^IPC1.PMIC + }) +
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl Device (PCI0) · line 341
Quoted 10 lines
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +10
-0+ Method (_STA, 0, NotSerialized) + { + Return (STA_VISIBLE) + } + + Device (RHUB) + { + Name (_ADR, Zero) + + // GPLD: Generate Port Location Data (PLD)
nits: please use /* */
Quoted 13 lines
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +13
-0+ Method (GPLD, 1, Serialized) { + Name (PCKG, Package () { + Buffer (0x10) {} + }) + + // REV: Revision 0x02 for ACPI 5.0 + CreateField (DerefOf (Index (PCKG, Zero)), Zero, 0x07, REV) + Store (0x02, REV) + + // VISI: Port visibility to user per port + CreateField (DerefOf (Index (PCKG, Zero)), 0x40, One, VISI) + Store (Arg0, VISI) + Return (PCKG)
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl Device (PCI0) · line 364
Quoted 10 lines
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +7
-0+ } + + Device (HS01) { Name (_ADR, 1) } + Device (SS01) { Name (_ADR, 2) } + } + } + Device (PWM0) { Name (_ADR, 0x00170000)
Otherwise, looks good to me
Reviewed-by Bin Meng <[email protected]>