arm64: dts: allwinner: a64: olinuxino: add user red LED
Subsystems (2)
PATCH 1/1 arm64: dts: allwinner: a64: olinuxino: add user red LED
There is a red LED marked as GPIO_LED1 on the silkscreen and connected to PE17 by default. So lets add this missing bit in the current hardware description.
--- arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts +9 -0
@@ -32,6 +32,15 @@ }; }; + leds { + compatible = "gpio-leds"; + + user { + label = "a64-olinuxino:red:user"; + gpios = <&pio 4 17 GPIO_ACTIVE_HIGH>; /* PE17 */ + }; + }; + reg_usb1_vbus: usb1-vbus { compatible = "regulator-fixed"; regulator-name = "usb1-vbus";
Maxime Ripard
AppliedQuoted 5 lines · Petr Štetiar
There is a red LED marked as
GPIO_LED1on the silkscreen and connected to PE17 by default. So lets add this missing bit in the current hardware description.Signed-off-by Petr Štetiar <[email protected]>
QUeued for 5.8, thanks!
Maxime
Quoted 9 lines · Maxime Ripard
Quoted 5 lines · Petr Štetiar
There is a red LED marked as
GPIO_LED1on the silkscreen and connected to PE17 by default. So lets add this missing bit in the current hardware description.Signed-off-by Petr Štetiar <[email protected]>QUeued for 5.8, thanks!
The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f]) as the child node name. This was recently brought to my attention. Do we want to follow suit here?
ChenYu
Chen-Yu Tsai <[email protected]> [2020-03-31 09:19:57]:
Hi,
Quoted 7 lines · Maxime Ripard
Quoted 6 lines · Petr Štetiar
Quoted 4 lines
There is a red LED marked as
GPIO_LED1on the silkscreen and connected to PE17 by default. So lets add this missing bit in the current hardware description.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Petr Štetiar <[email protected]>QUeued for 5.8, thanks!
The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f]) as the child node name. This was recently brought to my attention. Do we want to follow suit here?
I can see following in Documentation/devicetree/bindings/leds/leds-gpio.yaml:
patternProperties:
# The first form is preferred, but fall back to just 'led' anywhere in the
# node name to at least catch some child nodes. "(^led-[0-9a-f]$|led)":
So it seems like led-0 is indeed preferred, should I send v2 or a new patch as a fix on top of the previous one?
-- ynezz
Quoted 7 lines · Chen-Yu Tsai
Quoted 6 lines · Maxime Ripard
Quoted 4 lines · Petr Štetiar
There is a red LED marked as
GPIO_LED1on the silkscreen and connected to PE17 by default. So lets add this missing bit in the current hardware description.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Petr Štetiar <[email protected]>QUeued for 5.8, thanks!
The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f]) as the child node name. This was recently brought to my attention. Do we want to follow suit here?
I've fixed it up, thanks!
Maxime