Skip to contentSkip to conversation

mm: Remove dummy struct bootmem_data/bootmem_data_t

PATCH Applied Waiman Long 3 participants 3 messages Mar 26, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: Remove dummy struct bootmem_data/bootmem_data_t

Both bootmem_data and bootmem_data_t structures are no longer defined. Remove the dummy forward declarations.

---
 arch/alpha/include/asm/mmzone.h | 2 --
 include/linux/mmzone.h          | 1 -
 2 files changed, 3 deletions(-)
arch/alpha/include/asm/mmzone.h +0 -2
index 7ee144f484f1..9b521c857436 100644
@@ -8,8 +8,6 @@
 
 #include <asm/smp.h>
 
-struct bootmem_data_t; /* stupid forward decl. */
-
 /*
  * Following are macros that are specific to this numa platform.
  */
include/linux/mmzone.h +0 -1
index 462f6873905a..5c388eced889 100644
@@ -706,7 +706,6 @@ struct deferred_split {
  * Memory statistics and page replacement data structures are maintained on a
  * per-zone basis.
  */
-struct bootmem_data;
 typedef struct pglist_data {
 	struct zone node_zones[MAX_NR_ZONES];
 	struct zonelist node_zonelists[MAX_ZONELISTS];
Signature · 1 line
2.18.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Waiman Long

Both bootmem_data and bootmem_data_t structures are no longer defined. Remove the dummy forward declarations.

---
 arch/alpha/include/asm/mmzone.h | 2 --
 include/linux/mmzone.h          | 1 -
 2 files changed, 3 deletions(-)
arch/alpha/include/asm/mmzone.h +0 -2
index 7ee144f484f1..9b521c857436 100644
@@ -8,8 +8,6 @@
 
 #include <asm/smp.h>
 
-struct bootmem_data_t; /* stupid forward decl. */
-
 /*
  * Following are macros that are specific to this numa platform.
  */
include/linux/mmzone.h +0 -0
index 462f6873905a..5c388eced889 100644

include/linux/mmzone.h struct deferred_split { · line 711

Quoted 7 lines
include/linux/mmzone.h +0 -1
@@ -706,7 +706,6 @@ struct deferred_split {
  * Memory statistics and page replacement data structures are maintained on a
  * per-zone basis.
  */
-struct bootmem_data;
 typedef struct pglist_data {
 	struct zone node_zones[MAX_NR_ZONES];
 	struct zonelist node_zonelists[MAX_ZONELISTS];

Looks good to me.

reviewer Acked-by on v1 1/1
#2 lore raw
In reply to Waiman Long
Quoted 4 lines · Waiman Long

Both bootmem_data and bootmem_data_t structures are no longer defined. Remove the dummy forward declarations.

Quoted 34 lines
---
 arch/alpha/include/asm/mmzone.h | 2 --
 include/linux/mmzone.h          | 1 -
 2 files changed, 3 deletions(-)
arch/alpha/include/asm/mmzone.h +0 -2
index 7ee144f484f1..9b521c857436 100644
@@ -8,8 +8,6 @@
 
 #include <asm/smp.h>
 
-struct bootmem_data_t; /* stupid forward decl. */
-
 /*
  * Following are macros that are specific to this numa platform.
  */
include/linux/mmzone.h +0 -1
index 462f6873905a..5c388eced889 100644
@@ -706,7 +706,6 @@ struct deferred_split {
  * Memory statistics and page replacement data structures are maintained on a
  * per-zone basis.
  */
-struct bootmem_data;
 typedef struct pglist_data {
 	struct zone node_zones[MAX_NR_ZONES];
 	struct zonelist node_zonelists[MAX_ZONELISTS];
Signature · 1 line
2.18.1
Signature · 2 lines
Sincerely yours,
Mike.