Skip to contentSkip to conversation

dmaengine: uniphier-xdmac: Remove redandant error log for platform_get_irq

PATCH Applied Vinod Koul 1 participant 2 messages Mar 23, 2020 – Mar 26, 2020

Subsystems (2)
lore
Share & tools
lore

Vinod Koul

author maintainer
#0 lore raw

PATCH 1/1 dmaengine: uniphier-xdmac: Remove redandant error log for platform_get_irq

platform_get_irq prints the error on failure, so there is no need to have caller add a log.
Remove the log in uniphier_xdmac_probe() for platform_get_irq() failure

---
 drivers/dma/uniphier-xdmac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/dma/uniphier-xdmac.c +1 -3
index 2f6fd518d180..7b2f8a8c2d31 100644
@@ -525,10 +525,8 @@ static int uniphier_xdmac_probe(struct platform_device *pdev)
 		uniphier_xdmac_chan_init(xdev, i);
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "Failed to get IRQ\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	ret = devm_request_irq(dev, irq, uniphier_xdmac_irq_handler,
 			       IRQF_SHARED, "xdmac", xdev);
Signature · 1 line
2.25.1
author maintainer Applied
#1 lore raw
Quoted 3 lines · Vinod Koul

platform_get_irq prints the error on failure, so there is no need to have caller add a log.
Remove the log in uniphier_xdmac_probe() for platform_get_irq() failure

Applied, thanks

Signature · 1 line
~Vinod