mm/sparse: Fix kernel crash with pfn_section_valid check
Subsystems (3)
PATCH v2 1/1 mm/sparse: Fix kernel crash with pfn_section_valid check
Fixes the below crash
BUG: Kernel NULL pointer dereference on read at 0x00000000 Faulting instruction address: 0xc000000000c3447c Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries CPU: 11 PID: 7519 Comm: lt-ndctl Not tainted 5.6.0-rc7-autotest #1 ... NIP [c000000000c3447c] vmemmap_populated+0x98/0xc0 LR [c000000000088354] vmemmap_free+0x144/0x320 Call Trace: section_deactivate+0x220/0x240 __remove_pages+0x118/0x170 arch_remove_memory+0x3c/0x150 memunmap_pages+0x1cc/0x2f0 devm_action_release+0x30/0x50 release_nodes+0x2f8/0x3e0 device_release_driver_internal+0x168/0x270 unbind_store+0x130/0x170 drv_attr_store+0x44/0x60 sysfs_kf_write+0x68/0x80 kernfs_fop_write+0x100/0x290 __vfs_write+0x3c/0x70 vfs_write+0xcc/0x240 ksys_write+0x7c/0x140 system_call+0x5c/0x68
The crash is due to NULL dereference at
test_bit(idx, ms->usage->subsection_map); due to ms->usage = NULL; in pfn_section_valid()
With commit: d41e2f3bd546 ("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case") section_mem_map is set to NULL after depopulate_section_mem(). This
was done so that pfn_page() can work correctly with kernel config that disables SPARSEMEM_VMEMMAP. With that config pfn_to_page does
__section_mem_map_addr(__sec) + __pfn;
where
static inline struct page *__section_mem_map_addr(struct mem_section *section)
{
unsigned long map = section->section_mem_map;
map &= SECTION_MAP_MASK;
return (struct page *)map;
}Now with SPASEMEM_VMEMAP enabled, mem_section->usage->subsection_map is used to check the pfn validity (pfn_valid()). Since section_deactivate release mem_section->usage if a section is fully deactivated, pfn_valid() check after a subsection_deactivate cause a kernel crash.
static inline int pfn_valid(unsigned long pfn)
{
...
return early_section(ms) || pfn_section_valid(ms, pfn); }
where
static inline int pfn_section_valid(struct mem_section *ms, unsigned long pfn)
{
int idx = subsection_map_index(pfn);
return test_bit(idx, ms->usage->subsection_map);
}Avoid this by clearing SECTION_HAS_MEM_MAP when mem_section->usage is freed. For architectures like ppc64 where large pages are used for vmmemap mapping (16MB), a specific vmemmap mapping can cover multiple sections. Hence before a vmemmap mapping page can be freed, the kernel needs to make sure there are no valid sections within that mapping. Clearing the section valid bit before depopulate_section_memap enables this.
--- mm/sparse.c | 6 ++++++ 1 file changed, 6 insertions(+)
mm/sparse.c +6 -0
@@ -781,6 +781,12 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages, ms->usage =NULL ; } memmap =sparse_decode_mem_map (ms->section_mem_map, section_nr); +/* +* Mark the section invalid so that valid_section() +* return false. This prevents code from dereferencing +* ms->usage array. +*/ + ms->section_mem_map &= ~SECTION_HAS_MEM_MAP ; }if (section_is_early && memmap)
Signature · 1 line
2.25.1
Quoted 96 lines · Aneesh Kumar K.V
Fixes the below crash
BUG: Kernel NULL pointer dereference on read at 0x00000000 Faulting instruction address: 0xc000000000c3447c Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries CPU: 11 PID: 7519 Comm: lt-ndctl Not tainted 5.6.0-rc7-autotest #1 ... NIP [c000000000c3447c] vmemmap_populated+0x98/0xc0 LR [c000000000088354] vmemmap_free+0x144/0x320 Call Trace: section_deactivate+0x220/0x240 __remove_pages+0x118/0x170 arch_remove_memory+0x3c/0x150 memunmap_pages+0x1cc/0x2f0 devm_action_release+0x30/0x50 release_nodes+0x2f8/0x3e0 device_release_driver_internal+0x168/0x270 unbind_store+0x130/0x170 drv_attr_store+0x44/0x60 sysfs_kf_write+0x68/0x80 kernfs_fop_write+0x100/0x290 __vfs_write+0x3c/0x70 vfs_write+0xcc/0x240 ksys_write+0x7c/0x140 system_call+0x5c/0x68The crash is due to NULL dereference at
test_bit(idx, ms->usage->subsection_map); due toms->usage= NULL; inpfn_section_valid()With commit:
d41e2f3bd546("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")section_mem_mapis set to NULL afterdepopulate_section_mem(). This
was done so thatpfn_page()can work correctly with kernel config that disablesSPARSEMEM_VMEMMAP. With that configpfn_to_pagedoes__section_mem_map_addr(__sec) + __pfn;where
static inline struct page *__section_mem_map_addr(struct
mem_section*section){ unsigned long map = section->section_mem_map; map &= SECTION_MAP_MASK; return (struct page *)map; }Now with
SPASEMEM_VMEMAPenabled,mem_section->usage->subsection_mapis used to check the pfn validity (pfn_valid()). Sincesection_deactivatereleasemem_section->usageif a section is fully deactivated,pfn_valid()check after asubsection_deactivatecause a kernel crash.static inline int
pfn_valid(unsigned long pfn)
{
...return early_section(ms) || pfn_section_valid(ms, pfn); }where
static inline int
pfn_section_valid(struct mem_section *ms, unsigned long pfn){ int idx = subsection_map_index(pfn); return test_bit(idx, ms->usage->subsection_map); }Avoid this by clearing
SECTION_HAS_MEM_MAPwhenmem_section->usageis freed. For architectures like ppc64 where large pages are used for vmmemap mapping (16MB), a specific vmemmap mapping can cover multiple sections. Hence before a vmemmap mapping page can be freed, the kernel needs to make sure there are no valid sections within that mapping. Clearing the section valid bit beforedepopulate_section_memapenables this.Fixes d41e2f3bd546 ("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")Reported-by Sachin Sant <[email protected]>Tested-by Sachin Sant <[email protected]>Cc Baoquan He <[email protected]>Cc Michael Ellerman <[email protected]>Cc Dan Williams <[email protected]>Cc Pankaj Gupta <[email protected]>Cc David Hildenbrand <[email protected]>Cc Michal Hocko <[email protected]>Cc Wei Yang <[email protected]>Cc Oscar Salvador <[email protected]>Cc Mike Rapoport <[email protected]>Cc <[email protected]>Signed-off-by Aneesh Kumar K.V <[email protected]>--- mm/sparse.c | 6 ++++++ 1 file changed, 6 insertions(+)mm/sparse.c +0
-0
mm/sparse.c static void section_deactivate(unsigned long pfn, unsigned long nr_pages, · line 790
Quoted 10 lines
mm/sparse.c +6
-0@@ -781,6 +781,12 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages, ms->usage =NULL ; } memmap =sparse_decode_mem_map (ms->section_mem_map, section_nr); +/* +* Mark the section invalid so that valid_section() +* return false. This prevents code from dereferencing +* ms->usage array. +*/ + ms->section_mem_map &= ~SECTION_HAS_MEM_MAP ; }
Quoted 66 lines · Aneesh Kumar K.V
Fixes the below crash
BUG: Kernel NULL pointer dereference on read at 0x00000000 Faulting instruction address: 0xc000000000c3447c Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries CPU: 11 PID: 7519 Comm: lt-ndctl Not tainted 5.6.0-rc7-autotest #1 ... NIP [c000000000c3447c] vmemmap_populated+0x98/0xc0 LR [c000000000088354] vmemmap_free+0x144/0x320 Call Trace: section_deactivate+0x220/0x240 __remove_pages+0x118/0x170 arch_remove_memory+0x3c/0x150 memunmap_pages+0x1cc/0x2f0 devm_action_release+0x30/0x50 release_nodes+0x2f8/0x3e0 device_release_driver_internal+0x168/0x270 unbind_store+0x130/0x170 drv_attr_store+0x44/0x60 sysfs_kf_write+0x68/0x80 kernfs_fop_write+0x100/0x290 __vfs_write+0x3c/0x70 vfs_write+0xcc/0x240 ksys_write+0x7c/0x140 system_call+0x5c/0x68The crash is due to NULL dereference at
test_bit(idx, ms->usage->subsection_map); due toms->usage= NULL; inpfn_section_valid()With commit:
d41e2f3bd546("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")section_mem_mapis set to NULL afterdepopulate_section_mem(). This
was done so thatpfn_page()can work correctly with kernel config that disablesSPARSEMEM_VMEMMAP. With that configpfn_to_pagedoes__section_mem_map_addr(__sec) + __pfn;where
static inline struct page *__section_mem_map_addr(struct
mem_section*section){ unsigned long map = section->section_mem_map; map &= SECTION_MAP_MASK; return (struct page *)map; }Now with
SPASEMEM_VMEMAPenabled,mem_section->usage->subsection_mapis used to check the pfn validity (pfn_valid()). Sincesection_deactivatereleasemem_section->usageif a section is fully deactivated,pfn_valid()check after asubsection_deactivatecause a kernel crash.static inline int
pfn_valid(unsigned long pfn)
{
...return early_section(ms) || pfn_section_valid(ms, pfn); }where
static inline int
pfn_section_valid(struct mem_section *ms, unsigned long pfn){ int idx = subsection_map_index(pfn); return test_bit(idx, ms->usage->subsection_map); }
Quoted 6 lines
Avoid this by clearing
SECTION_HAS_MEM_MAPwhenmem_section->usageis freed. For architectures like ppc64 where large pages are used for vmmemap mapping (16MB), a specific vmemmap mapping can cover multiple sections. Hence before a vmemmap mapping page can be freed, the kernel needs to make sure there are no valid sections within that mapping. Clearing the section valid bit beforedepopulate_section_memapenables this.
I believe that the necessity of clearing the section before the tear down is worth a comment into the code. Because this is just way to easy to miss or not be aware at all while looking into the code without git balme.
Quoted 6 lines
Fixes d41e2f3bd546 ("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")Reported-by Sachin Sant <[email protected]>Tested-by Sachin Sant <[email protected]>Cc Baoquan He <[email protected]>Cc Michael Ellerman <[email protected]>Cc Dan Williams <[email protected]>
Quoted 8 lines
Cc Pankaj Gupta <[email protected]>Cc David Hildenbrand <[email protected]>Cc Michal Hocko <[email protected]>Cc Wei Yang <[email protected]>Cc Oscar Salvador <[email protected]>Cc Mike Rapoport <[email protected]>Cc <[email protected]>Signed-off-by Aneesh Kumar K.V <[email protected]>
Thanks!
Quoted 24 lines
--- mm/sparse.c | 6 ++++++ 1 file changed, 6 insertions(+)mm/sparse.c +6
-0@@ -781,6 +781,12 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages, ms->usage =NULL ; } memmap =sparse_decode_mem_map (ms->section_mem_map, section_nr); +/* +* Mark the section invalid so that valid_section() +* return false. This prevents code from dereferencing +* ms->usage array. +*/ + ms->section_mem_map &= ~SECTION_HAS_MEM_MAP ; }if (section_is_early && memmap)Signature · 1 line
2.25.1
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 100 lines
Fixes the below crash
BUG: Kernel NULL pointer dereference on read at 0x00000000 Faulting instruction address: 0xc000000000c3447c Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries CPU: 11 PID: 7519 Comm: lt-ndctl Not tainted 5.6.0-rc7-autotest #1 ... NIP [c000000000c3447c] vmemmap_populated+0x98/0xc0 LR [c000000000088354] vmemmap_free+0x144/0x320 Call Trace: section_deactivate+0x220/0x240 __remove_pages+0x118/0x170 arch_remove_memory+0x3c/0x150 memunmap_pages+0x1cc/0x2f0 devm_action_release+0x30/0x50 release_nodes+0x2f8/0x3e0 device_release_driver_internal+0x168/0x270 unbind_store+0x130/0x170 drv_attr_store+0x44/0x60 sysfs_kf_write+0x68/0x80 kernfs_fop_write+0x100/0x290 __vfs_write+0x3c/0x70 vfs_write+0xcc/0x240 ksys_write+0x7c/0x140 system_call+0x5c/0x68The crash is due to NULL dereference at
test_bit(idx, ms->usage->subsection_map); due toms->usage= NULL; inpfn_section_valid()With commit:
d41e2f3bd546("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")section_mem_mapis set to NULL afterdepopulate_section_mem(). This
was done so thatpfn_page()can work correctly with kernel config that disablesSPARSEMEM_VMEMMAP. With that configpfn_to_pagedoes__section_mem_map_addr(__sec) + __pfn;where
static inline struct page *__section_mem_map_addr(struct
mem_section*section){ unsigned long map = section->section_mem_map; map &= SECTION_MAP_MASK; return (struct page *)map; }Now with
SPASEMEM_VMEMAPenabled,mem_section->usage->subsection_mapis used to check the pfn validity (pfn_valid()). Sincesection_deactivatereleasemem_section->usageif a section is fully deactivated,pfn_valid()check after asubsection_deactivatecause a kernel crash.static inline int
pfn_valid(unsigned long pfn)
{
...return early_section(ms) || pfn_section_valid(ms, pfn); }where
static inline int
pfn_section_valid(struct mem_section *ms, unsigned long pfn){ int idx = subsection_map_index(pfn); return test_bit(idx, ms->usage->subsection_map); }Avoid this by clearing
SECTION_HAS_MEM_MAPwhenmem_section->usageis freed. For architectures like ppc64 where large pages are used for vmmemap mapping (16MB), a specific vmemmap mapping can cover multiple sections. Hence before a vmemmap mapping page can be freed, the kernel needs to make sure there are no valid sections within that mapping. Clearing the section valid bit beforedepopulate_section_memapenables this.Fixes d41e2f3bd546 ("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")Reported-by Sachin Sant <[email protected]>Tested-by Sachin Sant <[email protected]>Cc Baoquan He <[email protected]>Cc Michael Ellerman <[email protected]>Cc Dan Williams <[email protected]>Cc Pankaj Gupta <[email protected]>Cc David Hildenbrand <[email protected]>Cc Michal Hocko <[email protected]>Cc Wei Yang <[email protected]>Cc Oscar Salvador <[email protected]>Cc Mike Rapoport <[email protected]>Cc <[email protected]>Signed-off-by Aneesh Kumar K.V <[email protected]>--- mm/sparse.c | 6 ++++++ 1 file changed, 6 insertions(+)mm/sparse.c +0
-0@@ -781,6 +781,12 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages, ms->usage =NULL ; } memmap =sparse_decode_mem_map (ms->section_mem_map, section_nr);
mm/sparse.c static void section_deactivate(unsigned long pfn, unsigned long nr_pages,
Quoted 10 lines
mm/sparse.c +6
-1+/* +* Mark the section invalid so that valid_section() +* return false. This prevents code from dereferencing +* ms->usage array. +*/ + ms->section_mem_map &= ~SECTION_HAS_MEM_MAP ; }if (section_is_early && memmap) --
Agree with Michal, comment for clearing the section would be nicer.
Fix looks good to me.
Quoted 2 lines
2.25.1
Quoted 73 lines · Aneesh Kumar K.V
Fixes the below crash
BUG: Kernel NULL pointer dereference on read at 0x00000000 Faulting instruction address: 0xc000000000c3447c Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries CPU: 11 PID: 7519 Comm: lt-ndctl Not tainted 5.6.0-rc7-autotest #1 ... NIP [c000000000c3447c] vmemmap_populated+0x98/0xc0 LR [c000000000088354] vmemmap_free+0x144/0x320 Call Trace: section_deactivate+0x220/0x240 __remove_pages+0x118/0x170 arch_remove_memory+0x3c/0x150 memunmap_pages+0x1cc/0x2f0 devm_action_release+0x30/0x50 release_nodes+0x2f8/0x3e0 device_release_driver_internal+0x168/0x270 unbind_store+0x130/0x170 drv_attr_store+0x44/0x60 sysfs_kf_write+0x68/0x80 kernfs_fop_write+0x100/0x290 __vfs_write+0x3c/0x70 vfs_write+0xcc/0x240 ksys_write+0x7c/0x140 system_call+0x5c/0x68The crash is due to NULL dereference at
test_bit(idx, ms->usage->subsection_map); due toms->usage= NULL; inpfn_section_valid()With commit:
d41e2f3bd546("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")section_mem_mapis set to NULL afterdepopulate_section_mem(). This
was done so thatpfn_page()can work correctly with kernel config that disablesSPARSEMEM_VMEMMAP. With that configpfn_to_pagedoes__section_mem_map_addr(__sec) + __pfn;where
static inline struct page *__section_mem_map_addr(struct
mem_section*section){ unsigned long map = section->section_mem_map; map &= SECTION_MAP_MASK; return (struct page *)map; }Now with
SPASEMEM_VMEMAPenabled,mem_section->usage->subsection_mapis used to check the pfn validity (pfn_valid()). Sincesection_deactivatereleasemem_section->usageif a section is fully deactivated,pfn_valid()check after asubsection_deactivatecause a kernel crash.static inline int
pfn_valid(unsigned long pfn)
{
...return early_section(ms) || pfn_section_valid(ms, pfn); }where
static inline int
pfn_section_valid(struct mem_section *ms, unsigned long pfn){ int idx = subsection_map_index(pfn); return test_bit(idx, ms->usage->subsection_map); }Avoid this by clearing
SECTION_HAS_MEM_MAPwhenmem_section->usageis freed. For architectures like ppc64 where large pages are used for vmmemap mapping (16MB), a specific vmemmap mapping can cover multiple sections. Hence before a vmemmap mapping page can be freed, the kernel needs to make sure there are no valid sections within that mapping. Clearing the section valid bit beforedepopulate_section_memapenables this.
Quoted 14 lines
Fixes d41e2f3bd546 ("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")Reported-by Sachin Sant <[email protected]>Tested-by Sachin Sant <[email protected]>Cc Baoquan He <[email protected]>Cc Michael Ellerman <[email protected]>Cc Dan Williams <[email protected]>Cc Pankaj Gupta <[email protected]>Cc David Hildenbrand <[email protected]>Cc Michal Hocko <[email protected]>Cc Wei Yang <[email protected]>Cc Oscar Salvador <[email protected]>Cc Mike Rapoport <[email protected]>Cc <[email protected]>Signed-off-by Aneesh Kumar K.V <[email protected]>
Signature · 2 lines
Wei Yang Help you, Help me
Quoted 96 lines · Aneesh Kumar K.V
Fixes the below crash
BUG: Kernel NULL pointer dereference on read at 0x00000000 Faulting instruction address: 0xc000000000c3447c Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries CPU: 11 PID: 7519 Comm: lt-ndctl Not tainted 5.6.0-rc7-autotest #1 ... NIP [c000000000c3447c] vmemmap_populated+0x98/0xc0 LR [c000000000088354] vmemmap_free+0x144/0x320 Call Trace: section_deactivate+0x220/0x240 __remove_pages+0x118/0x170 arch_remove_memory+0x3c/0x150 memunmap_pages+0x1cc/0x2f0 devm_action_release+0x30/0x50 release_nodes+0x2f8/0x3e0 device_release_driver_internal+0x168/0x270 unbind_store+0x130/0x170 drv_attr_store+0x44/0x60 sysfs_kf_write+0x68/0x80 kernfs_fop_write+0x100/0x290 __vfs_write+0x3c/0x70 vfs_write+0xcc/0x240 ksys_write+0x7c/0x140 system_call+0x5c/0x68The crash is due to NULL dereference at
test_bit(idx, ms->usage->subsection_map); due toms->usage= NULL; inpfn_section_valid()With commit:
d41e2f3bd546("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")section_mem_mapis set to NULL afterdepopulate_section_mem(). This
was done so thatpfn_page()can work correctly with kernel config that disablesSPARSEMEM_VMEMMAP. With that configpfn_to_pagedoes__section_mem_map_addr(__sec) + __pfn;where
static inline struct page *__section_mem_map_addr(struct
mem_section*section){ unsigned long map = section->section_mem_map; map &= SECTION_MAP_MASK; return (struct page *)map; }Now with
SPASEMEM_VMEMAPenabled,mem_section->usage->subsection_mapis used to check the pfn validity (pfn_valid()). Sincesection_deactivatereleasemem_section->usageif a section is fully deactivated,pfn_valid()check after asubsection_deactivatecause a kernel crash.static inline int
pfn_valid(unsigned long pfn)
{
...return early_section(ms) || pfn_section_valid(ms, pfn); }where
static inline int
pfn_section_valid(struct mem_section *ms, unsigned long pfn){ int idx = subsection_map_index(pfn); return test_bit(idx, ms->usage->subsection_map); }Avoid this by clearing
SECTION_HAS_MEM_MAPwhenmem_section->usageis freed. For architectures like ppc64 where large pages are used for vmmemap mapping (16MB), a specific vmemmap mapping can cover multiple sections. Hence before a vmemmap mapping page can be freed, the kernel needs to make sure there are no valid sections within that mapping. Clearing the section valid bit beforedepopulate_section_memapenables this.Fixes d41e2f3bd546 ("mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case")Reported-by Sachin Sant <[email protected]>Tested-by Sachin Sant <[email protected]>Cc Baoquan He <[email protected]>Cc Michael Ellerman <[email protected]>Cc Dan Williams <[email protected]>Cc Pankaj Gupta <[email protected]>Cc David Hildenbrand <[email protected]>Cc Michal Hocko <[email protected]>Cc Wei Yang <[email protected]>Cc Oscar Salvador <[email protected]>Cc Mike Rapoport <[email protected]>Cc <[email protected]>Signed-off-by Aneesh Kumar K.V <[email protected]>--- mm/sparse.c | 6 ++++++ 1 file changed, 6 insertions(+)mm/sparse.c +0
-0
mm/sparse.c static void section_deactivate(unsigned long pfn, unsigned long nr_pages, · line 786
Quoted 6 lines
mm/sparse.c +3
-0@@ -781,6 +781,12 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages, ms->usage =NULL ; } memmap =sparse_decode_mem_map (ms->section_mem_map, section_nr); +/* +* Mark the section invalid so that valid_section() +* return false. This prevents code from dereferencing
s/return/returns/
mm/sparse.c static void section_deactivate(unsigned long pfn, unsigned long nr_pages, · line 787
Quoted 1 line
mm/sparse.c +1
-0+* ms->usage array.
maybe "(see pfn_section_valid())"
Quoted 2 lines
mm/sparse.c +2
-0+*/ + ms->section_mem_map &= ~SECTION_HAS_MEM_MAP ;
Signature · 3 lines
Thanks, David / dhildenb