acpi: pcihp: fix left shift undefined behavior in acpi_pcihp_eject_slot()
PATCH 1/1 acpi: pcihp: fix left shift undefined behavior in acpi_pcihp_eject_slot()
Coverity spots subj in following guest triggered code path
pci_write(, data = 0) -> acpi_pcihp_eject_slot(,slots = 0)
uinst32_t slot = ctz32(slots)
...
... = ~(1U << slot)where 'slot' value is 32 in case 'slots' bitmap is empty. 'slots' is a bitmap and empty one shouldn't do anything so return early doing nothing if resulted slot value is not valid (i.e. not in 0-31 range)
Reported-by Peter Maydell <[email protected]>
Signed-off-by Igor Mammedov <[email protected]>
--- hw/acpi/pcihp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/acpi/pcihp.c +1 -1
@@ -154,7 +154,7 @@ static void acpi_pcihp_eject_slot(AcpiPciHpState *s, unsigned bsel, unsigned slotrace_acpi_pci_eject_slot (bsel, slot); -if (!bus) { +if (!bus || slot >31 ) {return ; }
Signature · 1 line
2.18.1
Quoted 5 lines · Igor Mammedov
Coverity spots subj in following guest triggered code path
pci_write(, data = 0)->acpi_pcihp_eject_slot(,slots = 0)uinst32_t slot = ctz32(slots) ... ... = ~(1U << slot)
Quoted 7 lines
where 'slot' value is 32 in case 'slots' bitmap is empty. 'slots' is a bitmap and empty one shouldn't do anything so return early doing nothing if resulted slot value is not valid (i.e. not in 0-31 range)
Reported-by Peter Maydell <[email protected]>Signed-off-by Igor Mammedov <[email protected]>
tagged, thanks!
Quoted 19 lines
--- hw/acpi/pcihp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/acpi/pcihp.c +1
-1@@ -154,7 +154,7 @@ static void acpi_pcihp_eject_slot(AcpiPciHpState *s, unsigned bsel, unsigned slotrace_acpi_pci_eject_slot (bsel, slot); -if (!bus) { +if (!bus || slot >31 ) {return ; }Signature · 1 line
2.18.1