Fix use after stack unwind in fzsync lib
PATCH v2 1/1 Fix use after stack unwind in fzsync lib
tst_fzsync_pair_reset() passes a local variable to thread B which may be already unwinded by the time the thread wrapper function executes. If new variables get allocated and initialized on stack between pthread_create() and thread wrapper execution, thread B will segfault.
---
Changes since v1:
- Use tst_alloc() instead of SAFE_MALLOC() to prevent memory leak even if SAFE_PTHREAD_CREATE() fails
- Revert changes in tst_fzsync_thread_wrapper() as they're no longer needed
include/tst_fuzzy_sync.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
include/tst_fuzzy_sync.h +6 -2
@@ -297,8 +297,12 @@ static void tst_fzsync_pair_reset(struct tst_fzsync_pair *pair, pair->b_cntr =0 ; pair->exit =0 ;if (run_b) { -struct tst_fzsync_run_thread wrap_run_b = {.func = run_b, .arg =NULL }; -SAFE_PTHREAD_CREATE (&pair->thread_b,0 , tst_fzsync_thread_wrapper, &wrap_run_b); +struct tst_fzsync_run_thread *wrap_run_b; + + wrap_run_b =tst_alloc (sizeof (struct tst_fzsync_run_thread )); + wrap_run_b->func = run_b; + wrap_run_b->arg =NULL ; +SAFE_PTHREAD_CREATE (&pair->thread_b,0 , tst_fzsync_thread_wrapper, wrap_run_b); } pair->exec_time_start = (float )tst_timeout_remaining ();
Signature · 1 line
2.25.1
PATCH v2 1/1 Fix use after stack unwind in fzsync lib
Hi!
Quoted 21 lines
tst_fzsync_pair_reset()passes a local variable to thread B which may be already unwinded by the time the thread wrapper function executes. If new variables get allocated and initialized on stack betweenpthread_create()and thread wrapper execution, thread B will segfault.Signed-off-by Martin Doucha <[email protected]>---
Changes since v1:
- Usetst_alloc()instead ofSAFE_MALLOC()to prevent memory leak even ifSAFE_PTHREAD_CREATE()fails
- Revert changes intst_fzsync_thread_wrapper()as they're no longer neededinclude/tst_fuzzy_sync.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)include/tst_fuzzy_sync.h +0
-0
include/tst_fuzzy_sync.h static void tst_fzsync_pair_reset(struct tst_fzsync_pair *pair, · line 304
Quoted 10 lines
include/tst_fuzzy_sync.h +5
-2@@ -297,8 +297,12 @@ static void tst_fzsync_pair_reset(struct tst_fzsync_pair *pair, pair->b_cntr =0 ; pair->exit =0 ;if (run_b) { -struct tst_fzsync_run_thread wrap_run_b = {.func = run_b, .arg =NULL }; -SAFE_PTHREAD_CREATE (&pair->thread_b,0 , tst_fzsync_thread_wrapper, &wrap_run_b); +struct tst_fzsync_run_thread *wrap_run_b; + + wrap_run_b =tst_alloc (sizeof (struct tst_fzsync_run_thread )); + wrap_run_b->func = run_b; + wrap_run_b->arg =NULL ;
Why can't we simply declare the wrap_run_b as a global variable?
Quoted 10 lines
include/tst_fuzzy_sync.h +1
-0+SAFE_PTHREAD_CREATE (&pair->thread_b,0 , tst_fzsync_thread_wrapper, wrap_run_b); } pair->exec_time_start = (float )tst_timeout_remaining ();Signature · 5 lines
2.25.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 2 lines
Cyril Hrubis [email protected]