ARM: dts: stm32: Define FMC2 base address
Subsystems (3)
PATCH 1/1 ARM: dts: stm32: Define FMC2 base address
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
--- arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-stm32mp/include/mach/stm32.h +1 -0
@@ -13,6 +13,7 @@#define STM32_RCC_BASE 0x50000000#define STM32_PWR_BASE 0x50001000#define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000#define STM32_TZC_BASE 0x5C006000#define STM32_ETZPC_BASE 0x5C007000#define STM32_STGEN_BASE 0x5C008000
Signature · 1 line
2.25.1
PATCH 1/1 ARM: dts: stm32: Define FMC2 base address
Hi Marek
Quoted 15 lines · Marek Vasut
Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)arch/arm/mach-stm32mp/include/mach/stm32.h +0
-0
arch/arm/mach-stm32mp/include/mach/stm32.h line 19
Quoted 7 lines
arch/arm/mach-stm32mp/include/mach/stm32.h +1
-0@@ -13,6 +13,7 @@#define STM32_RCC_BASE 0x50000000#define STM32_PWR_BASE 0x50001000#define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000#define STM32_TZC_BASE 0x5C006000#define STM32_ETZPC_BASE 0x5C007000#define STM32_STGEN_BASE 0x5C008000
Thanks
Patrice
PATCH 1/1 ARM: dts: stm32: Define FMC2 base address
In reply to Marek VasutHi Marek,
Quoted 19 lines
From: Marek Vasut <[email protected]>
Sent: jeudi 26 mars 2020 16:57Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)arch/arm/mach- renamed from arch/arm/mach-stm32mp/include/mach/stm32.h +0
-0
stm32mp/include/mach/stm32.h
indexf0636005e5..62d95d7f88100644
arch/arm/mach-stm32mp/include/mach/stm32.h line 16
Quoted 4 lines
arch/arm/mach-stm32mp/include/mach/stm32.h +1
-0@@ -13,6 +13,7 @@#define STM32_RCC_BASE 0x50000000#define STM32_PWR_BASE 0x50001000#define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000
For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the device defined here.
But normally it is not the case for FMC2, even if I understand the current need, without FMC2 bus driver.... I will take this patch only it is not possible to get FMC2 address from device tree.
Quoted 5 lines
arch/arm/mach-stm32mp/include/mach/stm32.h +0
-1#define STM32_TZC_BASE 0x5C006000#define STM32_ETZPC_BASE 0x5C007000#define STM32_STGEN_BASE 0x5C008000 --2.25.1
Regards
Patrick
PATCH 1/1 ARM: dts: stm32: Define FMC2 base address
Quoted 1 line · Patrick DELAUNAY
Hi Marek,
Hi,
Quoted 27 lines
Quoted 19 lines
From: Marek Vasut <[email protected]>
Sent: jeudi 26 mars 2020 16:57Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)arch/arm/mach- renamed from arch/arm/mach-stm32mp/include/mach/stm32.h +0
-0
stm32mp/include/mach/stm32.h
indexf0636005e5..62d95d7f88100644arch/arm/mach-stm32mp/include/mach/stm32.h line 16
Quoted 4 lines
arch/arm/mach-stm32mp/include/mach/stm32.h +1
-0@@ -13,6 +13,7 @@#define STM32_RCC_BASE 0x50000000#define STM32_PWR_BASE 0x50001000#define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the device defined here.
Quoted 2 lines
But normally it is not the case for FMC2, even if I understand the current need, without FMC2 bus driver.... I will take this patch only it is not possible to get FMC2 address from device tree.
I can parse this information from the DT, but what would be the benefit? Slower boot due to the need to traverse DT and more complex code?
PATCH 1/1 ARM: dts: stm32: Define FMC2 base address
Dear,
Quoted 36 lines
From: Marek Vasut <[email protected]>
Sent: jeudi 9 avril 2020 13:23Quoted 1 line · Patrick DELAUNAY
Hi Marek,
Hi,
Quoted 13 lines
Quoted 13 lines
From: Marek Vasut <[email protected]>
Sent: jeudi 26 mars 2020 16:57Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)Quoted 13 lines
arch/arm/mach-stm32mp/include/mach/stm32.h line 16
Quoted 10 lines
(quoted diff) +0
-0b/arch/arm/mach-
stm32mp/include/mach/stm32.hindexf0636005e5..62d95d7f88100644arch/arm/mach-stm32mp/include/mach/stm32.h +1
-0@@ -13,6 +13,7 @@#define STM32_RCC_BASE 0x50000000#define STM32_PWR_BASE 0x50001000#define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the
device defined here.
Quoted 1 line
Quoted 7 lines
Quoted 1 line
But normally it is not the case for FMC2, even if I understand the current need,
without FMC2 bus driver....
Quoted 1 line
I will take this patch only it is not possible to get FMC2 address from device
tree.
I can parse this information from the DT, but what would be the benefit? Slower boot due to the need to traverse DT and more complex code?
I am convinced now (thanks to Christophe) because the correct FMC bus driver is not yet ready...
It will be clean-up later when no more used.
Thanks
Patrick
PATCH 1/1 ARM: dts: stm32: Define FMC2 base address
Hi
Quoted 44 lines · Patrick DELAUNAY
Dear,
Quoted 32 lines
From: Marek Vasut <[email protected]>
Sent: jeudi 9 avril 2020 13:23Quoted 1 line · Patrick DELAUNAY
Hi Marek,
Hi,
Quoted 13 lines
Quoted 13 lines
From: Marek Vasut <[email protected]>
Sent: jeudi 26 mars 2020 16:57Define FMC2 base address, for use in board files, until there is an actual FMC2 bus driver.
Signed-off-by Marek Vasut <[email protected]>Cc Patrick Delaunay <[email protected]>Cc Patrice Chotard <[email protected]>--- arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
arch/arm/mach-stm32mp/include/mach/stm32.h line 16
Quoted 10 lines
(quoted diff) +0
-0b/arch/arm/mach-
stm32mp/include/mach/stm32.hindexf0636005e5..62d95d7f88100644arch/arm/mach-stm32mp/include/mach/stm32.h +1
-0@@ -13,6 +13,7 @@#define STM32_RCC_BASE 0x50000000#define STM32_PWR_BASE 0x50001000#define STM32_DBGMCU_BASE 0x50081000 +#define STM32_FMC2_BASE 0x58002000For me, the address should be defined in this file only for the few addresses used before device tree avaibility: I want to avoid to have all the
Quoted 8 lines
device defined here.
Quoted 1 line
But normally it is not the case for FMC2, even if I understand the current need,
without FMC2 bus driver....
Quoted 1 line
I will take this patch only it is not possible to get FMC2 address from device
tree.
I can parse this information from the DT, but what would be the benefit? Slower boot due to the need to traverse DT and more complex code?
I am convinced now (thanks to Christophe) because the correct FMC bus driver is not yet ready...
Quoted 9 lines
It will be clean-up later when no more used.
Reviewed-by Patrick Delaunay <[email protected]>Thanks
Patrick
Applied to u-boot-stm/next
Thanks
Patrice