infiniband: hfi1: Use scnprintf() for avoiding potential buffer overflow
Subsystems (2)
PATCH 1/1 infiniband: hfi1: Use scnprintf() for avoiding potential buffer overflow
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf().
Cc Mike Marciniszyn <[email protected]>
Cc Dennis Dalessandro <[email protected]>
Cc Doug Ledford <[email protected]>
Cc Jason Gunthorpe <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
--- drivers/infiniband/hw/hfi1/fault.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/hfi1/fault.c +2 -2
@@ -222,11 +222,11 @@ static ssize_t fault_opcodes_read(struct file *file, char __user *buf,while (bit < bitsize) { zero =find_next_zero_bit (fault->opcodes, bitsize, bit);if (zero -1 != bit) - size +=snprintf (data + size, + size +=scnprintf (data + size, datalen - size -1 ,"0x%lx-0x%lx," , bit, zero -1 );else - size +=snprintf (data + size, + size +=scnprintf (data + size, datalen - size -1 ,"0x%lx," , bit); bit =find_next_bit (fault->opcodes, bitsize, zero);
Signature · 1 line
2.16.4
Jason Gunthorpe
AppliedQuoted 10 lines · Takashi Iwai
Since
snprintf()returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing withscnprintf().Cc Mike Marciniszyn <[email protected]>Cc Dennis Dalessandro <[email protected]>Cc Doug Ledford <[email protected]>Cc Jason Gunthorpe <[email protected]>Signed-off-by Takashi Iwai <[email protected]>
Quoted 3 lines
--- drivers/infiniband/hw/hfi1/fault.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to for-next, thanks
Jason