Skip to contentSkip to conversation

wilc1000: Use crc7 in lib/ rather than a private copy

PATCH In review George Spelvin 2 participants 3 messages Mar 26, 2020 – Mar 27, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 wilc1000: Use crc7 in lib/ rather than a private copy

The code in lib/ is the desired polynomial, and even includes the 1-bit left shift in the table rather than needing to code it explicitly.

While I'm in Kconfig, add a description of what a WILC1000 is. Kconfig questions that require me to look up a data sheet to find out that I probably don't have one are a pet peeve.

---
v2: Rebase on staging-next tree
v2: Resend to Greg. I sent it to Ajay, maintainer of the driver, for
him to forward. Should I have bypassed him?

 drivers/staging/wilc1000/Kconfig |  5 +++
 drivers/staging/wilc1000/spi.c   | 64 +++-----------------------------
 2 files changed, 11 insertions(+), 58 deletions(-)
drivers/staging/wilc1000/Kconfig +5 -0
index 59e58550d1397..80c92e8bf8a59 100644
@@ -2,6 +2,10 @@
 config WILC1000
 	tristate
 	help
+	  Add support for the Atmel WILC1000 802.11 b/g/n SoC.
+	  This provides Wi-FI over an SDIO or SPI interface, and
+	  is usually found in IoT devices.
+
 	  This module only support IEEE 802.11n WiFi.
 
 config WILC1000_SDIO
@@ -22,6 +26,7 @@ config WILC1000_SPI
 	tristate "Atmel WILC1000 SPI (WiFi only)"
 	depends on CFG80211 && INET && SPI
 	select WILC1000
+	select CRC7
 	help
 	  This module adds support for the SPI interface of adapters using
 	  WILC1000 chipset. The Atmel WILC1000 has a Serial Peripheral
drivers/staging/wilc1000/spi.c +6 -58

82 lines not on this page · raw message

base-commit: 3017e587e36819f87e53d3c8751afdf987c1f542

Signature · 1 line
2.26.0.rc2
#1 lore raw

Hi George,

Quoted 9 lines · George Spelvin

The code in lib/ is the desired polynomial, and even includes the 1-bit left shift in the table rather than needing to code it explicitly.

While I'm in Kconfig, add a description of what a WILC1000 is. Kconfig questions that require me to look up a data sheet to find out that I probably don't have one are a pet peeve.

Quoted 8 lines

---
v2: Rebase on staging-next tree
v2: Resend to Greg. I sent it to Ajay, maintainer of the driver, for
him to forward. Should I have bypassed him?

Currently, wilc1000 driver is present in staging so while submitting patches please mark '[email protected]' mail-id also. Btw, I have already resubmitted your patch by adding mailing group. The patch is applied to 'staging-next' branch, so please pull the latest staging to check the changes.
For future patches, please also add '[email protected]' mailing-id.

Regards,
Ajay

#2 lore raw
Quoted 2 lines · On Fri, Mar 27, 2020 at 07:03:28AM +0000, [email protected] wrote:

Currently, wilc1000 driver is present in staging so while submitting patches please mark '[email protected]' mail-id also.

Aah, my error was to *only* check the staging/wilc1000/ entry in MAINTAINERS, and not include the overall staging/ entries, which scripts/get_maintainer.pl pulled out.

Sorry about that.