ppc/smp: Replace unnecessary 'while' by 'if'
RFC PATCH 1/1 ppc/smp: Replace unnecessary 'while' by 'if'
spin_until_cond() will wait until nmi_ipi_busy == false, and nmi_ipi_lock_start() does not seem to change nmi_ipi_busy, so there is no way this while will ever repeat.
Replace this 'while' by an 'if', so it does not look like it can repeat.
--- arch/powerpc/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/smp.c +1 -1
@@ -473,7 +473,7 @@ static int __smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *),return 0 ;nmi_ipi_lock_start (&flags); -while (nmi_ipi_busy) { +if (nmi_ipi_busy) {nmi_ipi_unlock_end (&flags);spin_until_cond (!nmi_ipi_busy);nmi_ipi_lock_start (&flags);
Signature · 1 line
2.24.1
Paul Mackerras
NAKQuoted 5 lines · Leonardo Bras
spin_until_cond()will wait untilnmi_ipi_busy== false, andnmi_ipi_lock_start()does not seem to changenmi_ipi_busy, so there is no way this while will ever repeat.Replace this 'while' by an 'if', so it does not look like it can repeat.
Nack, it can repeat. The scenario is that cpu A is in this code, inside spin_until_cond(); cpu B has previously set nmi_ipi_busy, and cpu C is also waiting for nmi_ipi_busy to be cleared, like cpu A. When cpu B clears nmi_ipi_busy, both cpu A and cpu C will see that and will race inside nmi_ipi_lock_start(). One of them, say cpu C, will take the lock and proceed to set nmi_ipi_busy and then call nmi_ipi_unlock(). Then the other cpu (cpu A) will then take the lock and return from nmi_ipi_lock_start() and find nmi_ipi_busy == true. At that point it needs to go through the while loop body once more.
Paul.
Quoted 17 lines · Paul Mackerras
Quoted 5 lines · Leonardo Bras
spin_until_cond()will wait untilnmi_ipi_busy== false, andnmi_ipi_lock_start()does not seem to changenmi_ipi_busy, so there is no way this while will ever repeat.Replace this 'while' by an 'if', so it does not look like it can repeat.
Nack, it can repeat. The scenario is that cpu A is in this code, inside
spin_until_cond(); cpu B has previously setnmi_ipi_busy, and cpu C is also waiting fornmi_ipi_busyto be cleared, like cpu A. When cpu B clearsnmi_ipi_busy, both cpu A and cpu C will see that and will race insidenmi_ipi_lock_start(). One of them, say cpu C, will take the lock and proceed to setnmi_ipi_busyand then callnmi_ipi_unlock(). Then the other cpu (cpu A) will then take the lock and return fromnmi_ipi_lock_start()and findnmi_ipi_busy== true. At that point it needs to go through the while loop body once more.
Quoted 1 line
Paul.
Ok, got it.
Thanks for explaining Paul!