Skip to contentSkip to conversation

package/sdbusplus: needs C++17

PATCH New Fabrice Fontaine 4 participants 4 messages Mar 26, 2020 – Apr 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/sdbusplus: needs C++17

sdbusplus needs C++17 since
https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d

This is not needed for host-sdbusplus as libsdbusplus is disabled on host through --disable-libsdbusplus

Fixes:
- http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe

---
 package/sdbusplus/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/sdbusplus/Config.in +4 -2
index e278d17156..c66203c463 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_SDBUSPLUS
 	bool "sdbusplus"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_SYSTEMD
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
 	help
 	  A C++ library for sd-bus with a bindings and doc generator.
 
@@ -10,5 +11,6 @@ config BR2_PACKAGE_SDBUSPLUS
 
 	  https://github.com/openbmc/sdbusplus
 
-comment "sdbusplus needs systemd and a toolchain w/ C++"
-	depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP
+comment "sdbusplus needs systemd and a toolchain w/ C++, gcc >= 7"
+	depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_7
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/sdbusplus: needs C++17

Quoted 9 lines

From: Fabrice Fontaine <[email protected]>
Sent: Thursday, March 26, 2020 1:38 PM
To: buildroot at buildroot.org <[email protected]>
Cc: John Faith <[email protected]>; Fabrice Fontaine <[email protected]>
Subject: [PATCH 1/1] package/sdbusplus: needs C++17

sdbusplus needs C++17 since
https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d

Quoted 8 lines

This is not needed for host-sdbusplus as libsdbusplus is disabled on host through --disable-libsdbusplus

Fixes:
-
http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe

Thanks for fixing this!
,
John

Quoted 27 lines

---
package/sdbusplus/Config.in | 6 ++++--

1 file changed, 4 insertions(+), 2 deletions(-)
package/sdbusplus/Config.in +0 -0
index e278d17156..c66203c463 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_SDBUSPLUS

bool "sdbusplus"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_PACKAGE_SYSTEMD
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17 help
A C++ library for sd-bus with a bindings and doc generator.

package/sdbusplus/Config.in +0 -0
@@ -10,5 +11,6 @@ config BR2_PACKAGE_SDBUSPLUS
 

https://github.com/openbmc/sdbusplus

package/sdbusplus/Config.in +3 -2
-comment "sdbusplus needs systemd and a toolchain w/ C++"
- depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP
+comment "sdbusplus needs systemd and a toolchain w/ C++, gcc >= 7"
+ depends on !BR2_PACKAGE_SYSTEMD || !BR2_INSTALL_LIBSTDCPP || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_7
Signature · 1 line
2.25.1
#2 lore raw

PATCH 1/1 package/sdbusplus: needs C++17

In reply to Fabrice Fontaine
Quoted 6 lines · On Thu, 26 Mar 2020 21:38:20 +0100 Fabrice Fontaine…

sdbusplus needs C++17 since
https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d

This is not needed for host-sdbusplus as libsdbusplus is disabled on host through --disable-libsdbusplus

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe

---
 package/sdbusplus/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/sdbusplus: needs C++17

In reply to Fabrice Fontaine
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

sdbusplus needs C++17 since
https://github.com/openbmc/sdbusplus/commit/ca46b9d2e958d1e4b392265f656f782899c2de1d

Quoted 7 lines

This is not needed for host-sdbusplus as libsdbusplus is disabled on host through --disable-libsdbusplus

Fixes:
- http://autobuild.buildroot.org/results/65a4652e5b419f03ace109c4b3738e9b997cdabe

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard