package/connman: disable wireguard support
PATCH v2 1/1 package/connman: disable wireguard support
The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
But to keep the same 'Connman' setup as previous setup, we need to explicitly disable the 'WireGuard' support.
The support of all the new 'Connman' options will be added by follow-up commits (or patches).
Fixes:
http://autobuild.buildroot.org/?reason=connman-1.38
---
Changes v1 -> v2 (after review of Romain Naour)
- this fix concerns all Arch, not only x86_64
- do not add a new '_CONF_OPTS' line but use the previous one
package/connman/connman.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/connman/connman.mk +2 -1
@@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES CONNMAN_LICENSE = GPL-2.0 CONNMAN_LICENSE_FILES = COPYING -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \ + --disable-wireguard ifeq ($(BR2_INIT_SYSTEMD),y) CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
Signature · 1 line
2.20.1
PATCH v2 1/1 package/connman: disable wireguard support
Hi Mikael,
Le 26/03/2020 ? 16:25, Mikael Bourhis-Cloarec a ?crit?:
Quoted 5 lines
The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
But to keep the same 'Connman' setup as previous setup, we need to explicitly disable the 'WireGuard' support.
Quoted 7 lines
The support of all the new 'Connman' options will be added by follow-up commits (or patches).
Fixes:
http://autobuild.buildroot.org/?reason=connman-1.38Signed-off-by Mikael Bourhis-Cloarec <[email protected]>
Best regards,
Romain
Quoted 23 lines
---
Changes v1 -> v2 (after review of Romain Naour)
- this fix concerns all Arch, not onlyx86_64
- do not add a new '_CONF_OPTS' line but use the previous onepackage/connman/connman.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/connman/connman.mk +2
-1@@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES CONNMAN_LICENSE = GPL-2.0 CONNMAN_LICENSE_FILES = COPYING -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \ + --disable-wireguard ifeq ($(BR2_INIT_SYSTEMD),y) CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/system
PATCH v2 1/1 package/connman: disable wireguard support
In reply to Mikael Bourhis-CloarecOn 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
Quoted 1 line
The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
For the libmnl part, we already have a pending patch:
https://patchwork.ozlabs.org/patch/1251106/
Quoted 8 lines
But to keep the same 'Connman' setup as previous setup, we need to explicitly disable the 'WireGuard' support.
The support of all the new 'Connman' options will be added by follow-up commits (or patches).
AFAICS, all the failures have iptable support enabled, which should be solved by the patch above...
I don't see how wireguard fits in the picture...
Regards,
Yann E. MORIN.
Quoted 29 lines
Signed-off-by Mikael Bourhis-Cloarec <[email protected]>---
Changes v1 -> v2 (after review of Romain Naour)
- this fix concerns all Arch, not onlyx86_64
- do not add a new '_CONF_OPTS' line but use the previous onepackage/connman/connman.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/connman/connman.mk +2
-1@@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES CONNMAN_LICENSE = GPL-2.0 CONNMAN_LICENSE_FILES = COPYING -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \ + --disable-wireguard ifeq ($(BR2_INIT_SYSTEMD),y) CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/systemSignature · 5 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/connman: disable wireguard support
Hi Yann, All,
Le 26/03/2020 ? 20:01, Yann E. MORIN a ?crit?:
Quoted 12 lines
On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
Quoted 1 line
The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
For the libmnl part, we already have a pending patch:
https://patchwork.ozlabs.org/patch/1251106/Quoted 6 lines
But to keep the same 'Connman' setup as previous setup, we need to explicitly disable the 'WireGuard' support.
The support of all the new 'Connman' options will be added by follow-up commits (or patches).
Quoted 7 lines
Quoted 2 lines
AFAICS, all the failures have iptable support enabled, which should be solved by the patch above...
I don't see how wireguard fits in the picture...
Sorry but our build still failing on current master with:
checking for LIBMNL... no
configure: error: libmnl >= 1.0.0 not found.
Here is the defconfig
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_CONNMAN=y
BR2_PACKAGE_CONNMAN_WIFI=y
BR2_PACKAGE_CONNMAN_CLIENT=y
That's because wiregard is enabled by default and BR2_PACKAGE_CONNMAN_IPTABLES is set.
It's unfortunate but we have several issues with the same error. The case fixed by James Hilliard is when BR2_PACKAGE_CONNMAN_NFTABLES is set.
Best regards,
Romain
Quoted 34 lines
Regards,
Yann E. MORIN.Quoted 29 lines
Signed-off-by Mikael Bourhis-Cloarec <[email protected]>---
Changes v1 -> v2 (after review of Romain Naour)
- this fix concerns all Arch, not onlyx86_64
- do not add a new '_CONF_OPTS' line but use the previous onepackage/connman/connman.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/connman/connman.mk +2
-1@@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES CONNMAN_LICENSE = GPL-2.0 CONNMAN_LICENSE_FILES = COPYING -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \ + --disable-wireguard ifeq ($(BR2_INIT_SYSTEMD),y) CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/systemSignature · 5 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
PATCH v2 1/1 package/connman: disable wireguard support
Romain, All,
On 2020-03-26 21:30 +0100, Romain Naour spake thusly:
Quoted 16 lines
Le 26/03/2020 ? 20:01, Yann E. MORIN a ?crit?:
Quoted 15 lines
On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
Quoted 1 line
The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
For the libmnl part, we already have a pending patch:
https://patchwork.ozlabs.org/patch/1251106/Quoted 8 lines
But to keep the same 'Connman' setup as previous setup, we need to explicitly disable the 'WireGuard' support.
The support of all the new 'Connman' options will be added by follow-up commits (or patches).
Quoted 6 lines
Quoted 4 lines
AFAICS, all the failures have iptable support enabled, which should be solved by the patch above...
I don't see how wireguard fits in the picture...
Sorry but our build still failing on current master with:
I was not trying to imply that master was fixed, just that we already had a pending patch about libmnl.
[--SNIP--]
Quoted 2 lines
It's unfortunate but we have several issues with the same error. The case fixed by James Hilliard is when
BR2_PACKAGE_CONNMAN_NFTABLESis set.
Damn, iptables, not nftables. Your patch is still on the table, then. ;-)
Regards,
Yann E. MORIN.
Quoted 38 lines
Best regards,
RomainQuoted 34 lines
Regards,
Yann E. MORIN.Quoted 29 lines
Signed-off-by Mikael Bourhis-Cloarec <[email protected]>---
Changes v1 -> v2 (after review of Romain Naour)
- this fix concerns all Arch, not onlyx86_64
- do not add a new '_CONF_OPTS' line but use the previous onepackage/connman/connman.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/connman/connman.mk +2
-1@@ -12,7 +12,8 @@ CONNMAN_INSTALL_STAGING = YES CONNMAN_LICENSE = GPL-2.0 CONNMAN_LICENSE_FILES = COPYING -CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc +CONNMAN_CONF_OPTS = --with-dbusconfdir=/etc \ + --disable-wireguard ifeq ($(BR2_INIT_SYSTEMD),y) CONNMAN_CONF_OPTS += --with-systemdunitdir=/usr/lib/systemd/systemSignature · 5 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/connman: disable wireguard support
Romain, Mikael, All,
On 2020-03-26 21:37 +0100, Yann E. MORIN spake thusly:
Quoted 5 lines
On 2020-03-26 21:30 +0100, Romain Naour spake thusly:
Quoted 3 lines
Le 26/03/2020 ? 20:01, Yann E. MORIN a ?crit?:
Quoted 2 lines
On 2020-03-26 16:25 +0100, Mikael Bourhis-Cloarec spake thusly:
Quoted 1 line
The new Connman 1.38 release uses 'WireGuard' and 'libmnl' by default now.
Damn, iptables, not nftables. Your patch is still on the table, then.
In the meantime, Thomas applied another earlier pending patch that actually enabled wireguard support.
So I've marked your patch as not applicable in patchwork.
Thanks for the contribution nonetheless! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'