Skip to contentSkip to conversation

staging: ralink-gdma: add blank line

PATCH In review Gokce Kuler 2 participants 2 messages Mar 26, 2020 – Mar 27, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: ralink-gdma: add blank line

Add missing blank line after declarations to follow the Linux kernel coding conventions.

---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/ralink-gdma/ralink-gdma.c +1 -0
index eabf109..b43f37f2 100644
@@ -123,6 +123,7 @@ struct gdma_dma_dev {
 	void __iomem *base;
 	struct tasklet_struct task;
 	volatile unsigned long chan_issued;
+
 	atomic_t cnt;
 
 	struct gdma_dmaengine_chan chan[];
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 13 lines · Gokce Kuler

Add missing blank line after declarations to follow the Linux kernel coding conventions.

---
 drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/ralink-gdma/ralink-gdma.c +0 -0
index eabf109..b43f37f2 100644

drivers/staging/ralink-gdma/ralink-gdma.c struct gdma_dma_dev { · line 129

Quoted 7 lines
drivers/staging/ralink-gdma/ralink-gdma.c +1 -0
@@ -123,6 +123,7 @@ struct gdma_dma_dev {
 	void __iomem *base;
 	struct tasklet_struct task;
 	volatile unsigned long chan_issued;
+
 	atomic_t cnt;
 
 	struct gdma_dmaengine_chan chan[];

No, you need to remove a blank line here to get this right, not add one. Look at the list of variables...

thanks,

greg k-h