Skip to contentSkip to conversation

ARM: dts: stm32: Repair PMIC configuration on AV96

PATCH New Marek Vasut 2 participants 2 messages Mar 26, 2020 – Mar 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Repair PMIC configuration on AV96

The core and vdd PMIC buck regulators were misconfigured, which caused instability of the board and malfunction of high-speed interfaces, like the RGMII. Furthermore, the vtt_ddr was also wrong. Configure the PMIC correctly to repair these problems.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp157a-avenger96.dts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/stm32mp157a-avenger96.dts +6 -5
index b6c984171a..8e36df8787 100644
@@ -153,7 +153,7 @@
 
 			vddcore: buck1 {
 				regulator-name = "vddcore";
-				regulator-min-microvolt = <1200000>;
+				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1350000>;
 				regulator-always-on;
 				regulator-initial-mode = <0>;
@@ -171,8 +171,8 @@
 
 			vdd: buck3 {
 				regulator-name = "vdd";
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <2500000>;
 				regulator-always-on;
 				st,mask_reset;
 				regulator-initial-mode = <0>;
@@ -206,8 +206,8 @@
 
 			vtt_ddr: ldo3 {
 				regulator-name = "vtt_ddr";
-				regulator-min-microvolt = <500000>;
-				regulator-max-microvolt = <750000>;
+				regulator-min-microvolt = <0>;
+				regulator-max-microvolt = <1000000>;
 				regulator-always-on;
 				regulator-over-current-protection;
 			};
@@ -254,6 +254,7 @@
 				regulator-name = "vbus_otg";
 				interrupts = <IT_OCP_OTG 0>;
 				interrupt-parent = <&pmic>;
+				regulator-active-discharge = <1>;
 			};
 
 			vbus_sw: pwr_sw2 {
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 ARM: dts: stm32: Repair PMIC configuration on AV96

Hi Marek

Quoted 48 lines · Marek Vasut

The core and vdd PMIC buck regulators were misconfigured, which caused instability of the board and malfunction of high-speed interfaces, like the RGMII. Furthermore, the vtt_ddr was also wrong. Configure the PMIC correctly to repair these problems.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp157a-avenger96.dts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
arch/arm/dts/stm32mp157a-avenger96.dts +5 -5
index b6c984171a..8e36df8787 100644
@@ -153,7 +153,7 @@
 
 			vddcore: buck1 {
 				regulator-name = "vddcore";
-				regulator-min-microvolt = <1200000>;
+				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <1350000>;
 				regulator-always-on;
 				regulator-initial-mode = <0>;
@@ -171,8 +171,8 @@
 
 			vdd: buck3 {
 				regulator-name = "vdd";
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <2500000>;
 				regulator-always-on;
 				st,mask_reset;
 				regulator-initial-mode = <0>;
@@ -206,8 +206,8 @@
 
 			vtt_ddr: ldo3 {
 				regulator-name = "vtt_ddr";
-				regulator-min-microvolt = <500000>;
-				regulator-max-microvolt = <750000>;
+				regulator-min-microvolt = <0>;
+				regulator-max-microvolt = <1000000>;
 				regulator-always-on;
 				regulator-over-current-protection;
 			};

arch/arm/dts/stm32mp157a-avenger96.dts line 260

Quoted 7 lines
arch/arm/dts/stm32mp157a-avenger96.dts +1 -0
@@ -254,6 +254,7 @@
 				regulator-name = "vbus_otg";
 				interrupts = <IT_OCP_OTG 0>;
 				interrupt-parent = <&pmic>;
+				regulator-active-discharge = <1>;
 			};
 
 			vbus_sw: pwr_sw2 {

Thanks