net: phy: probe PHY drivers synchronously
Subsystems (3)
Heiner Kallweit
maintainerPATCH v2 1/1 net: phy: probe PHY drivers synchronously
If we have scenarios like
mdiobus_register()
-> loads PHY driver module(s) -> registers PHY driver(s) -> may schedule async probe
phydev = mdiobus_get_phy()
<phydev action involving PHY driver>
or
phydev = phy_device_create()
-> loads PHY driver module -> registers PHY driver -> may schedule async probe
<phydev action involving PHY driver>
then we expect the PHY driver to be bound to the phydev when triggering the action. This may not be the case in case of asynchronous probing. Therefore ensure that PHY drivers are probed synchronously.
Default still is sync probing, except async probing is explicitly requested. I saw some comments that the intention is to promote async probing for more parallelism in boot process and want to be prepared for the case that the default is changed to async probing.
--- drivers/net/phy/phy_device.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/phy/phy_device.c +1 -0
@@ -2575,6 +2575,7 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner) new_driver->mdiodrv.driver.probe = phy_probe; new_driver->mdiodrv.driver.remove = phy_remove; new_driver->mdiodrv.driver.owner = owner; + new_driver->mdiodrv.driver.probe_type =PROBE_FORCE_SYNCHRONOUS ; retval =driver_register (&new_driver->mdiodrv.driver);if (retval) {
Signature · 1 line
2.26.0
Quoted 21 lines · Heiner Kallweit
If we have scenarios like
mdiobus_register()-> loads PHY driver module(s) -> registers PHY driver(s) -> may schedule async probephydev =
mdiobus_get_phy()
<phydev action involving PHY driver>or
phydev =
phy_device_create()-> loads PHY driver module -> registers PHY driver -> may schedule async probe<phydev action involving PHY driver>
then we expect the PHY driver to be bound to the phydev when triggering the action. This may not be the case in case of asynchronous probing. Therefore ensure that PHY drivers are probed synchronously.
Quoted 6 lines
Default still is sync probing, except async probing is explicitly requested. I saw some comments that the intention is to promote async probing for more parallelism in boot process and want to be prepared for the case that the default is changed to async probing.
Signed-off-by Heiner Kallweit <[email protected]>
Signature · 1 line
Florian
Quoted 21 lines · Heiner Kallweit
If we have scenarios like
mdiobus_register()-> loads PHY driver module(s) -> registers PHY driver(s) -> may schedule async probephydev =
mdiobus_get_phy()
<phydev action involving PHY driver>or
phydev =
phy_device_create()-> loads PHY driver module -> registers PHY driver -> may schedule async probe<phydev action involving PHY driver>
then we expect the PHY driver to be bound to the phydev when triggering the action. This may not be the case in case of asynchronous probing. Therefore ensure that PHY drivers are probed synchronously.
Quoted 6 lines
Default still is sync probing, except async probing is explicitly requested. I saw some comments that the intention is to promote async probing for more parallelism in boot process and want to be prepared for the case that the default is changed to async probing.
Signed-off-by Heiner Kallweit <[email protected]>
Andrew
From: Heiner Kallweit <[email protected]>
Date: Fri, 27 Mar 2020 01:00:22 +0100
Quoted 21 lines
If we have scenarios like
mdiobus_register()-> loads PHY driver module(s) -> registers PHY driver(s) -> may schedule async probephydev =
mdiobus_get_phy()
<phydev action involving PHY driver>or
phydev =
phy_device_create()-> loads PHY driver module -> registers PHY driver -> may schedule async probe<phydev action involving PHY driver>
then we expect the PHY driver to be bound to the phydev when triggering the action. This may not be the case in case of asynchronous probing. Therefore ensure that PHY drivers are probed synchronously.
Quoted 6 lines
Default still is sync probing, except async probing is explicitly requested. I saw some comments that the intention is to promote async probing for more parallelism in boot process and want to be prepared for the case that the default is changed to async probing.
Signed-off-by Heiner Kallweit <[email protected]>
Applied, thanks Heiner.