Skip to contentSkip to conversation

xen/softirq: adjust comment

PATCH In review Juergen Gross 2 participants 2 messages Mar 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/softirq: adjust comment

With commit cef21210fb133 ("rcu: don't process callbacks when holding a rcu_read_lock()") the comment in process_pending_softirqs() about not entering the scheduler should have been moved.

---
 xen/common/softirq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/common/softirq.c +1 -1
index eba65c5fc0..063e93cbe3 100644
@@ -56,6 +56,7 @@ static void __do_softirq(unsigned long ignore_mask)
 
 void process_pending_softirqs(void)
 {
+    /* Do not enter scheduler as it can preempt the calling context. */
     unsigned long ignore_mask = (1ul << SCHEDULE_SOFTIRQ) |
                                 (1ul << SCHED_SLAVE_SOFTIRQ);
 
@@ -64,7 +65,6 @@ void process_pending_softirqs(void)
         ignore_mask |= 1ul << RCU_SOFTIRQ;
 
     ASSERT(!in_irq() && local_irq_is_enabled());
-    /* Do not enter scheduler as it can preempt the calling context. */
     __do_softirq(ignore_mask);
 }
 
Signature · 1 line
2.16.4