Skip to contentSkip to conversation

s390/qeth: support net namespaces for L3 devices

PATCH Applied Julian Wiedmann 2 participants 4 messages Mar 27, 2020 – Mar 30, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390/qeth: support net namespaces for L3 devices

Enable the L3 driver's IPv4 address notifier to watch for events on qeth devices that have been moved into a net namespace. We need to program those IPs into the HW just as usual, otherwise inbound traffic won't flow.

Fixes 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
---
 drivers/s390/net/qeth_l3_main.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/s390/net/qeth_l3_main.c +0 -3
index 82f800d1d7b3..46c212118022 100644
@@ -2204,9 +2204,6 @@ static int qeth_l3_ip_event(struct notifier_block *this,
 	struct qeth_ipaddr addr;
 	struct qeth_card *card;
 
-	if (dev_net(dev) != &init_net)
-		return NOTIFY_DONE;
-
 	card = qeth_l3_get_card_from_dev(dev);
 	if (!card)
 		return NOTIFY_DONE;
Signature · 1 line
2.17.1
maintainer
#1 lore raw

From: Julian Wiedmann <[email protected]>
Date: Fri, 27 Mar 2020 12:00:42 +0100

Quoted 7 lines

Enable the L3 driver's IPv4 address notifier to watch for events on qeth devices that have been moved into a net namespace. We need to program those IPs into the HW just as usual, otherwise inbound traffic won't flow.

Fixes 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")

This looks more like a feature, openning the L3 driver into multiple namespaces, rather than a critical fix.

#2 lore raw
Quoted 8 lines · David Miller

From: Julian Wiedmann <[email protected]>
Date: Fri, 27 Mar 2020 12:00:42 +0100

Quoted 5 lines

Enable the L3 driver's IPv4 address notifier to watch for events on qeth devices that have been moved into a net namespace. We need to program those IPs into the HW just as usual, otherwise inbound traffic won't flow.

Quoted 6 lines
Quoted 2 lines
Fixes 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")

This looks more like a feature, openning the L3 driver into multiple namespaces, rather than a critical fix.

Definitely not 'critical', agreed. It's rather silly though that things currently work just fine for IPv6, but not for IPv4.

Mind queueing this up for net-next then instead? Thanks.

maintainer Applied
#3 lore raw
In reply to Julian Wiedmann

From: Julian Wiedmann <[email protected]>
Date: Fri, 27 Mar 2020 12:00:42 +0100

Quoted 7 lines

Enable the L3 driver's IPv4 address notifier to watch for events on qeth devices that have been moved into a net namespace. We need to program those IPs into the HW just as usual, otherwise inbound traffic won't flow.

Fixes 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")

Applied to net-next.