Skip to contentSkip to conversation

crypto: arm[64]/poly1305 - add artifact to .gitignore files

PATCH In review Jason A. Donenfeld 2 participants 7 messages Mar 19, 2020 – Mar 27, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: arm[64]/poly1305 - add artifact to .gitignore files

The .S_shipped yields a .S, and the pattern in these directories is to add that to .gitignore so that git-status doesn't raise a fuss.

Fixes a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Fixes f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Cc Ard Biesheuvel <[email protected]>
---
 arch/arm/crypto/.gitignore   | 1 +
 arch/arm64/crypto/.gitignore | 1 +
 2 files changed, 2 insertions(+)
arch/arm/crypto/.gitignore +1 -0
index 31e1f538df7d..a3c7ad52a469 100644
@@ -1,3 +1,4 @@
 aesbs-core.S
 sha256-core.S
 sha512-core.S
+poly1305-core.S
arch/arm64/crypto/.gitignore +1 -0
index 879df8781ed5..e403b1343328 100644
@@ -1,2 +1,3 @@
 sha256-core.S
 sha512-core.S
+poly1305-core.S
Signature · 1 line
2.25.1
maintainer
#4 lore raw
In reply to Jason A. Donenfeld
Quoted 8 lines · Jason A. Donenfeld

The .S_shipped yields a .S, and the pattern in these directories is to add that to .gitignore so that git-status doesn't raise a fuss.

Fixes a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Fixes f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Cc Ard Biesheuvel <[email protected]>
Quoted 4 lines
---
 arch/arm/crypto/.gitignore   | 1 +
 arch/arm64/crypto/.gitignore | 1 +
 2 files changed, 2 insertions(+)

Patch applied.

arch/arm64/crypto/.gitignore line 3

Quoted 8 lines
arch/arm64/crypto/.gitignore +1 -0
index 879df8781ed5..e403b1343328 100644
@@ -1,2 +1,3 @@
 sha256-core.S
 sha512-core.S
+poly1305-core.S

This didn't apply because a similar patch had already been added to cryptodev a month ago. Please base your patches on the latest cryptodev in future.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#5 lore raw
Quoted 17 lines · Herbert Xu
Quoted 8 lines · Jason A. Donenfeld

The .S_shipped yields a .S, and the pattern in these directories is to add that to .gitignore so that git-status doesn't raise a fuss.

Fixes a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Fixes f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Cc Ard Biesheuvel <[email protected]>
Quoted 4 lines
---
 arch/arm/crypto/.gitignore   | 1 +
 arch/arm64/crypto/.gitignore | 1 +
 2 files changed, 2 insertions(+)

Patch applied.

Quoted 12 lines

arch/arm64/crypto/.gitignore line 3

Quoted 8 lines
arch/arm64/crypto/.gitignore +1 -0
index 879df8781ed5..e403b1343328 100644
@@ -1,2 +1,3 @@
 sha256-core.S
 sha512-core.S
+poly1305-core.S

This didn't apply because a similar patch had already been added to cryptodev a month ago. Please base your patches on the latest cryptodev in future.

I had sent this with [PATCH crypto] in the subject line, meant for crypto-2.6.git for 5.6, since it's a bug fix for the things there. I didn't realize you were queuing these changes for 5.7 instead.

maintainer
#6 lore raw
Quoted 4 lines · Jason A. Donenfeld

I had sent this with [PATCH crypto] in the subject line, meant for crypto-2.6.git for 5.6, since it's a bug fix for the things there. I didn't realize you were queuing these changes for 5.7 instead.

Sorry about that. However, as a general rule I don't take trivial fixes such as these for the crypto tree.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt