perf synthetic-events: save 4kb from 2 stack frames
Ian Rogers
reviewerPATCH v2 1/1 perf synthetic-events: save 4kb from 2 stack frames
Reuse an existing char buffer to avoid two PATH_MAX sized char buffers. Reduces stack frame sizes by 4kb.
perf_event__synthesize_mmap_events before 'sub $0x45b8,%rsp' after 'sub $0x35b8,%rsp'.
perf_event__get_comm_ids before 'sub $0x2028,%rsp' after 'sub $0x1028,%rsp'.
Signed-off-by Ian Rogers <[email protected]>
--- tools/perf/util/synthetic-events.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-)
tools/perf/util/synthetic-events.c +10 -12
@@ -70,7 +70,6 @@ int perf_tool__process_synth_event(struct perf_tool *tool,static int perf_event__get_comm_ids (pid_t pid,char *comm,size_t len,pid_t *tgid,pid_t *ppid) { -char filename[PATH_MAX ];char bf[4096 ];int fd;size_t size =0 ;
@@ -80,11 +79,11 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len, *tgid =-1 ; *ppid =-1 ; -snprintf (filename,sizeof (filename),"/proc/%d/status" , pid); +snprintf (bf,sizeof (bf),"/proc/%d/status" , pid); - fd =open (filename,O_RDONLY ); + fd =open (bf,O_RDONLY );if (fd <0 ) { -pr_debug ("couldn't open %s\n" , filename); +pr_debug ("couldn't open %s\n" , bf);return -1 ; }
@@ -280,9 +279,9 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool, struct machine *machine, bool mmap_data) { - char filename[PATH_MAX];FILE *fp;unsigned long long t; +char bf[BUFSIZ ];bool truncation = false;unsigned long long timeout = proc_map_timeout *1000000ULL ;int rc =0 ;
@@ -292,15 +291,15 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,if (machine__is_default_guest (machine))return 0 ; -snprintf (filename,sizeof (filename),"%s/proc/%d/task/%d/maps" , - machine->root_dir, pid, pid); +snprintf (bf,sizeof (bf),"%s/proc/%d/task/%d/maps" , + machine->root_dir, pid, pid); - fp =fopen (filename,"r" ); + fp =fopen (bf,"r" );if (fp ==NULL ) {/* * We raced with a task exiting - just return: */ -pr_debug ("couldn't open %s\n" , filename); +pr_debug ("couldn't open %s\n" , bf);return -1 ; }
@@ -308,7 +307,6 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool, t =rdclock ();while (1 ) { -char bf[BUFSIZ ];char prot[5 ];char execname[PATH_MAX ];char anonstr[] ="//anon" ;
@@ -320,10 +318,10 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,break ;if ((rdclock () - t) > timeout) { -pr_warning ("Reading %s time out. " +pr_warning ("Reading %s/proc/%d/task/%d/maps time out. " "You may want to increase " "the time limit by --proc-map-timeout\n" , - filename); + machine->root_dir, pid, pid); truncation = true; goto out; }
Signature · 1 line
2.25.1.696.g5e7596f4ac-goog
From: Ian Rogers
Quoted 4 lines
Sent: 27 March 2020 17:29
Reuse an existing char buffer to avoid two
PATH_MAXsized char buffers. Reduces stack frame sizes by 4kb.
It's userspace, it really doesn't matter.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)