Skip to contentSkip to conversation

rtc: max8907: add missing select REGMAP_IRQ

PATCH In review Jules Irenge 1 participant 2 messages Mar 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/11 rtc: max8907: add missing select REGMAP_IRQ

From: Corentin Labbe <[email protected]>

I have hit the following build error:

armv7a-hardfloat-linux-gnueabi-ld: drivers/rtc/rtc-max8907.o: in function `max8907_rtc_probe':
rtc-max8907.c:(.text+0x400): undefined reference to `regmap_irq_get_virq'

max8907 should select REGMAP_IRQ

Fixes 94c01ab6d7544 ("rtc: add MAX8907 RTC driver")
Cc stable <[email protected]>
---
 drivers/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/rtc/Kconfig +1 -0
index 34c8b6c7e095..8e503881d9d6 100644
@@ -327,6 +327,7 @@ config RTC_DRV_MAX6900
 config RTC_DRV_MAX8907
 	tristate "Maxim MAX8907"
 	depends on MFD_MAX8907 || COMPILE_TEST
+	select REGMAP_IRQ
 	help
 	  If you say yes here you will get support for the
 	  RTC of Maxim MAX8907 PMIC.
Signature · 1 line
2.25.1
#1 lore raw
Quoted 33 lines · Jules Irenge

From: Corentin Labbe <[email protected]>

I have hit the following build error:

armv7a-hardfloat-linux-gnueabi-ld: drivers/rtc/rtc-max8907.o: in function `max8907_rtc_probe':
rtc-max8907.c:(.text+0x400): undefined reference to `regmap_irq_get_virq'

max8907 should select REGMAP_IRQ

Fixes 94c01ab6d7544 ("rtc: add MAX8907 RTC driver")
Cc stable <[email protected]>
---
 drivers/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/rtc/Kconfig +1 -0
index 34c8b6c7e095..8e503881d9d6 100644
@@ -327,6 +327,7 @@ config RTC_DRV_MAX6900
 config RTC_DRV_MAX8907
 	tristate "Maxim MAX8907"
 	depends on MFD_MAX8907 || COMPILE_TEST
+	select REGMAP_IRQ
 	help
 	  If you say yes here you will get support for the
 	  RTC of Maxim MAX8907 PMIC.
Signature · 1 line
2.25.1

Apology. I sent this one by mistake.
Please disregard it.

Polite regards,
Jules