Skip to contentSkip to conversation

drm/bridge: anx6345: set correct BPC for display_info of connector

PATCH Applied Vasily Khoruzhick 2 participants 3 messages Mar 29, 2020 – Apr 14, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: anx6345: set correct BPC for display_info of connector

Some drivers (e.g. sun4i-drm) need this info to decide whether they need to enable dithering. Currently driver reports what panel supports and if panel supports 8 we don't get dithering enabled.

Hardcode BPC to 6 for now since that's the only BPC that driver supports.

Fixes 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
---
 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +3 -0
index d7cb10c599a3..ea5de9395662 100644
@@ -494,6 +494,9 @@ static int anx6345_get_modes(struct drm_connector *connector)
 
 	num_modes += drm_add_edid_modes(connector, anx6345->edid);
 
+	/* Driver currently supports only 6bpc */
+	connector->display_info.bpc = 6;
+
 unlock:
 	if (power_off)
 		anx6345_poweroff(anx6345);
Signature · 6 lines
2.25.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v1 1/1
#1 lore raw

Hi!

Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick napisal(a):

Quoted 6 lines

Some drivers (e.g. sun4i-drm) need this info to decide whether they need to enable dithering. Currently driver reports what panel supports and if panel supports 8 we don't get dithering enabled.

Hardcode BPC to 6 for now since that's the only BPC that driver supports.

Best regards,
Jernej

Quoted 23 lines
Fixes 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
---
 drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index d7cb10c599a3..ea5de9395662 100644

drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +3 -0
@@ -494,6 +494,9 @@ static int anx6345_get_modes(struct drm_connector
 *connector)
 
 	num_modes += drm_add_edid_modes(connector, anx6345->edid);
 
+	/* Driver currently supports only 6bpc */
+	connector->display_info.bpc = 6;
+
 unlock:
 	if (power_off)

anx6345_poweroff(anx6345);

#2 lore raw
In reply to Vasily Khoruzhick

Dne ponedeljek, 30. marec 2020 ob 00:22:53 CEST je Vasily Khoruzhick napisal(a):

Quoted 9 lines

Some drivers (e.g. sun4i-drm) need this info to decide whether they need to enable dithering. Currently driver reports what panel supports and if panel supports 8 we don't get dithering enabled.

Hardcode BPC to 6 for now since that's the only BPC that driver supports.

Fixes 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")

Applied to drm-misc-fixes. Thanks!

Best regards,
Jernej