rtc: da9052: convert to devm_rtc_allocate_device
Subsystems (2)
Alexandre Belloni
maintainerPATCH v2 1/1 rtc: da9052: convert to devm_rtc_allocate_device
This allows further improvement of the driver.
Signed-off-by Alexandre Belloni <[email protected]>
---
Changes in v2:
- avoid reordering rtc registration and irq request.
drivers/rtc/rtc-da9052.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/rtc/rtc-da9052.c +7 -3
@@ -298,12 +298,16 @@ static int da9052_rtc_probe(struct platform_device *pdev)rtc_err (rtc,"Failed to disable TICKS: %d\n" , ret);device_init_wakeup (&pdev->dev, true); - rtc->rtc =devm_rtc_device_register (&pdev->dev, pdev->name, - &da9052_rtc_ops,THIS_MODULE ); - + rtc->rtc =devm_rtc_allocate_device (&pdev->dev);if (IS_ERR (rtc->rtc))return PTR_ERR (rtc->rtc); + rtc->rtc->ops = &da9052_rtc_ops; + + ret =rtc_register_device (rtc->rtc); +if (ret) +return ret; + ret =da9052_request_irq (rtc->da9052,DA9052_IRQ_ALARM ,"ALM" , da9052_rtc_irq, rtc);if (ret !=0 ) {
Signature · 1 line
2.25.1
Quoted 3 lines · Alexandre Belloni
This allows further improvement of the driver.
Signed-off-by Alexandre Belloni <[email protected]>
Acked-by Adam Thomson <[email protected]>
Quoted 35 lines
---
Changes in v2:
- avoid reordering rtc registration and irq request.drivers/rtc/rtc-da9052.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)drivers/rtc/rtc-da9052.c +7
-3@@ -298,12 +298,16 @@ static int da9052_rtc_probe(struct platform_device *pdev)rtc_err (rtc,"Failed to disable TICKS: %d\n" , ret);device_init_wakeup (&pdev->dev, true); - rtc->rtc =devm_rtc_device_register (&pdev->dev, pdev->name, - &da9052_rtc_ops,THIS_MODULE ); - + rtc->rtc =devm_rtc_allocate_device (&pdev->dev);if (IS_ERR (rtc->rtc))return PTR_ERR (rtc->rtc); + rtc->rtc->ops = &da9052_rtc_ops; + + ret =rtc_register_device (rtc->rtc); +if (ret) +return ret; + ret =da9052_request_irq (rtc->da9052,DA9052_IRQ_ALARM ,"ALM" , da9052_rtc_irq, rtc);if (ret != 0) {
--
2.25.1