staging: rtl8723bs: Remove multiple assignments
PATCH 1/1 staging: rtl8723bs: Remove multiple assignments
Remove multiple assignments by factorizing them.
Problem found using checkpatch.pl:-
CHECK: multiple assignments should be avoided
--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +5 -2
@@ -194,7 +194,9 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf +4 - ((SIZE_PTR )(pcmdpriv->rsp_allocated_buf) &3 ); - pcmdpriv->cmd_issued_cnt = pcmdpriv->cmd_done_cnt = pcmdpriv->rsp_cnt =0 ; + pcmdpriv->cmd_issued_cnt =0 ; + pcmdpriv->cmd_done_cnt =0 ; + pcmdpriv->rsp_cnt =0 ;mutex_init (&pcmdpriv->sctx_mutex); exit:
@@ -2138,7 +2140,8 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj * goto exit; } - psta->aid = psta->mac_id = passocsta_rsp->cam_id; + psta->aid = passocsta_rsp->cam_id; + psta->mac_id = passocsta_rsp->cam_id;spin_lock_bh (&pmlmepriv->lock);
Signature · 1 line
2.17.1
Quoted 14 lines · On Wed, 25 Mar 2020 19:52:26 +0530 Simran Singhal <[email protected]>…
Remove multiple assignments by factorizing them.
Problem found using checkpatch.pl:-
CHECK: multiple assignments should be avoidedSigned-off-by Simran Singhal <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/staging/rtl8723bs/core/rtw_cmd.c +0
-0
drivers/staging/rtl8723bs/core/rtw_cmd.c int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) · line 199
Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +3
-1@@ -194,7 +194,9 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf +4 - ((SIZE_PTR )(pcmdpriv->rsp_allocated_buf) &3 ); - pcmdpriv->cmd_issued_cnt = pcmdpriv->cmd_done_cnt = pcmdpriv->rsp_cnt =0 ; + pcmdpriv->cmd_issued_cnt =0 ; + pcmdpriv->cmd_done_cnt =0 ; + pcmdpriv->rsp_cnt =0 ;
I think this is better than the original because the original exceeds 80 columns (and looks horrible in general). But the second hunk:
drivers/staging/rtl8723bs/core/rtw_cmd.c void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj * · line 2144
Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +2
-1mutex_init (&pcmdpriv->sctx_mutex); exit:@@ -2138,7 +2140,8 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj * goto exit; } - psta->aid = psta->mac_id = passocsta_rsp->cam_id; + psta->aid = passocsta_rsp->cam_id; + psta->mac_id = passocsta_rsp->cam_id;
I would leave this alone, because psta->aid is really the same thing here, it's not just a value that happens to be assigned to both by accident.
Signature · 1 line
Stefano