Staging: rtl8188eu: hal: Add space around operators
PATCH v2 1/1 Staging: rtl8188eu: hal: Add space around operators
Add space around operators for improving the code
readability.
Reported by checkpatch.pl
git diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.
Signed-off-by Shreeya Patel <[email protected]>
---
shreeya@Shreeya-Patel:~staging$ git diff -w drivers/staging/rtl8188eu/hal/ shreeya@Shreeya-Patel:~staging$
shreeya@Shreeya-Patel:~staging/drivers/staging/rtl8188eu/hal$ find . -name
"*_old.o" -exec sh -c 'old=$0; new=$(echo $old | sed s/_old.o/.o/);
diff $old $new' {} \;
shreeya@Shreeya-Patel:~staging/drivers/staging/rtl8188eu/hal$Changes in v2:
- Merge the patch series into a single patch
drivers/staging/rtl8188eu/hal/hal_com.c | 22 +-- drivers/staging/rtl8188eu/hal/odm.c | 48 +++--- drivers/staging/rtl8188eu/hal/odm_hwconfig.c | 54 +++---- drivers/staging/rtl8188eu/hal/phy.c | 138 +++++++++--------- drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 2 +- drivers/staging/rtl8188eu/hal/rf.c | 60 ++++---- drivers/staging/rtl8188eu/hal/rf_cfg.c | 4 +- drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 42 +++--- .../staging/rtl8188eu/hal/rtl8188e_hal_init.c | 44 +++--- .../staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +- .../staging/rtl8188eu/hal/rtl8188eu_xmit.c | 32 ++-- 11 files changed, 224 insertions(+), 224 deletions(-)
drivers/staging/rtl8188eu/hal/hal_com.c +11 -11
@@ -18,26 +18,26 @@ void dump_chip_info(struct HAL_VERSION chip_vers)uint cnt =0 ;char buf[128 ]; - cnt +=sprintf ((buf+cnt),"Chip Version Info: CHIP_8188E_" ); - cnt +=sprintf ((buf+cnt),"%s_" , chip_vers.ChipType ==NORMAL_CHIP ? + cnt +=sprintf ((buf + cnt),"Chip Version Info: CHIP_8188E_" ); + cnt +=sprintf ((buf + cnt),"%s_" , chip_vers.ChipType ==NORMAL_CHIP ?"Normal_Chip" :"Test_Chip" ); - cnt +=sprintf ((buf+cnt),"%s_" , chip_vers.VendorType ==CHIP_VENDOR_TSMC ? + cnt +=sprintf ((buf + cnt),"%s_" , chip_vers.VendorType ==CHIP_VENDOR_TSMC ?"TSMC" :"UMC" );if (chip_vers.CUTVersion ==A_CUT_VERSION ) - cnt +=sprintf ((buf+cnt),"A_CUT_" ); + cnt +=sprintf ((buf + cnt),"A_CUT_" );else if (chip_vers.CUTVersion ==B_CUT_VERSION ) - cnt +=sprintf ((buf+cnt),"B_CUT_" ); + cnt +=sprintf ((buf + cnt),"B_CUT_" );else if (chip_vers.CUTVersion ==C_CUT_VERSION ) - cnt +=sprintf ((buf+cnt),"C_CUT_" ); + cnt +=sprintf ((buf + cnt),"C_CUT_" );else if (chip_vers.CUTVersion ==D_CUT_VERSION ) - cnt +=sprintf ((buf+cnt),"D_CUT_" ); + cnt +=sprintf ((buf + cnt),"D_CUT_" );else if (chip_vers.CUTVersion ==E_CUT_VERSION ) - cnt +=sprintf ((buf+cnt),"E_CUT_" ); + cnt +=sprintf ((buf + cnt),"E_CUT_" );else - cnt +=sprintf ((buf+cnt),"UNKNOWN_CUT(%d)_" , + cnt +=sprintf ((buf + cnt),"UNKNOWN_CUT(%d)_" , chip_vers.CUTVersion); - cnt +=sprintf ((buf+cnt),"1T1R_" ); - cnt +=sprintf ((buf+cnt),"RomVer(0)\n" ); + cnt +=sprintf ((buf + cnt),"1T1R_" ); + cnt +=sprintf ((buf + cnt),"RomVer(0)\n" );pr_info ("%s" , buf); }
drivers/staging/rtl8188eu/hal/odm.c +24 -24
124 lines not on this page · raw message
drivers/staging/rtl8188eu/hal/odm_hwconfig.c +27 -27
147 lines not on this page · raw message
drivers/staging/rtl8188eu/hal/phy.c +69 -69
348 lines not on this page · raw message
drivers/staging/rtl8188eu/hal/pwrseqcmd.c +1 -1
@@ -85,7 +85,7 @@ u8 rtl88eu_pwrseqcmdparsing(struct adapter *padapter, u8 cut_vers,if (GET_PWR_CFG_VALUE (pwrcfgcmd) ==PWRSEQ_DELAY_US )udelay (GET_PWR_CFG_OFFSET (pwrcfgcmd));else -udelay (GET_PWR_CFG_OFFSET (pwrcfgcmd)*1000 ); +udelay (GET_PWR_CFG_OFFSET (pwrcfgcmd) *1000 );break ;case PWR_CMD_END :/* When this command is parsed, end the process */
drivers/staging/rtl8188eu/hal/rf.c +30 -30
144 lines not on this page · raw message
drivers/staging/rtl8188eu/hal/rf_cfg.c +2 -2
@@ -143,7 +143,7 @@ static u32 Array_RadioA_1T_8188E[] = {#define READ_NEXT_PAIR (v1, v2, i) \ do { \ i += 2; v1 = array[i]; \ - v2 = array[i+1]; \ + v2 = array[i + 1]; \ } while (0)#define RFREG_OFFSET_MASK 0xfffff
@@ -190,7 +190,7 @@ static bool rtl88e_phy_config_rf_with_headerfile(struct adapter *adapt)for (i =0 ; i < array_len; i +=2 ) {u32 v1 = array[i]; -u32 v2 = array[i+1 ]; +u32 v2 = array[i +1 ];if (v1 <0xCDCDCDCD ) {rtl8188e_config_rf_reg (adapt, v1, v2);
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c +21 -21
147 lines not on this page · raw message
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c +22 -22
145 lines not on this page · raw message
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c +1 -1
@@ -182,7 +182,7 @@ void update_recvframe_phyinfo_88e(struct recv_frame *precvframe,rtl8188e_process_phy_info (padapter, precvframe); } }else if (pkt_info.bPacketToSelf || pkt_info.bPacketBeacon) { -if (check_fwstate (&padapter->mlmepriv,WIFI_ADHOC_STATE |WIFI_ADHOC_MASTER_STATE )) { +if (check_fwstate (&padapter->mlmepriv,WIFI_ADHOC_STATE |WIFI_ADHOC_MASTER_STATE )) {if (psta) precvframe->psta = psta; }
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c +16 -16
@@ -58,12 +58,12 @@ void rtl8188e_fill_fake_txdesc(struct adapter *adapt, u8 *desc, u32 BufferLen, u/* offset 0 */ ptxdesc->txdw0 |=cpu_to_le32 (OWN |FSG |LSG );/* own, bFirstSeg, bLastSeg; */ - ptxdesc->txdw0 |=cpu_to_le32 (((TXDESC_SIZE +OFFSET_SZ )<<OFFSET_SHT )&0x00ff0000 );/* 32 bytes for TX Desc */ + ptxdesc->txdw0 |=cpu_to_le32 (((TXDESC_SIZE +OFFSET_SZ ) <<OFFSET_SHT ) &0x00ff0000 );/* 32 bytes for TX Desc */ - ptxdesc->txdw0 |=cpu_to_le32 (BufferLen&0x0000ffff );/* Buffer size + command header */ + ptxdesc->txdw0 |=cpu_to_le32 (BufferLen &0x0000ffff );/* Buffer size + command header */ /* offset 4 */ - ptxdesc->txdw1 |=cpu_to_le32 ((QSLT_MGNT <<QSEL_SHT )&0x00001f00 );/* Fixed queue of Mgnt queue */ + ptxdesc->txdw1 |=cpu_to_le32 ((QSLT_MGNT <<QSEL_SHT ) &0x00001f00 );/* Fixed queue of Mgnt queue */ /* Set NAVUSEHDR to prevent Ps-poll AId filed to be changed to error vlaue by Hw. */ if (ispspoll) {
@@ -91,16 +91,16 @@ static void fill_txdesc_sectype(struct pkt_attrib *pattrib, struct tx_desc *ptxd/* SEC_TYPE : 0:NO_ENC,1:WEP40/TKIP,2:WAPI,3:AES */ case _WEP40_:case _WEP104_: - ptxdesc->txdw1 |=cpu_to_le32 ((0x01 <<SEC_TYPE_SHT )&0x00c00000 ); + ptxdesc->txdw1 |=cpu_to_le32 ((0x01 <<SEC_TYPE_SHT ) &0x00c00000 ); ptxdesc->txdw2 |=cpu_to_le32 (0x7 <<AMPDU_DENSITY_SHT );break ;case _TKIP_:case _TKIP_WTMIC_: - ptxdesc->txdw1 |=cpu_to_le32 ((0x01 <<SEC_TYPE_SHT )&0x00c00000 ); + ptxdesc->txdw1 |=cpu_to_le32 ((0x01 <<SEC_TYPE_SHT ) &0x00c00000 ); ptxdesc->txdw2 |=cpu_to_le32 (0x7 <<AMPDU_DENSITY_SHT );break ;case _AES_: - ptxdesc->txdw1 |=cpu_to_le32 ((0x03 <<SEC_TYPE_SHT )&0x00c00000 ); + ptxdesc->txdw1 |=cpu_to_le32 ((0x03 <<SEC_TYPE_SHT ) &0x00c00000 ); ptxdesc->txdw2 |=cpu_to_le32 (0x7 <<AMPDU_DENSITY_SHT );break ;case _NO_PRIVACY_:
@@ -127,7 +127,7 @@ static void fill_txdesc_vcs(struct pkt_attrib *pattrib, __le32 *pdw) *pdw |=cpu_to_le32 (HW_RTS_EN );/* Set RTS BW */ if (pattrib->ht_en) { - *pdw |= (pattrib->bwmode&HT_CHANNEL_WIDTH_40 ) ?cpu_to_le32 (BIT (27 )) :0 ; + *pdw |= (pattrib->bwmode &HT_CHANNEL_WIDTH_40 ) ?cpu_to_le32 (BIT (27 )) :0 ;if (pattrib->ch_offset ==HAL_PRIME_CHNL_OFFSET_LOWER ) *pdw |=cpu_to_le32 ((0x01 <<28 ) &0x30000000 );
@@ -144,7 +144,7 @@ static void fill_txdesc_vcs(struct pkt_attrib *pattrib, __le32 *pdw)static void fill_txdesc_phy (struct pkt_attrib *pattrib,__le32 *pdw) {if (pattrib->ht_en) { - *pdw |= (pattrib->bwmode&HT_CHANNEL_WIDTH_40 ) ?cpu_to_le32 (BIT (25 )) :0 ; + *pdw |= (pattrib->bwmode &HT_CHANNEL_WIDTH_40 ) ?cpu_to_le32 (BIT (25 )) :0 ;if (pattrib->ch_offset ==HAL_PRIME_CHNL_OFFSET_LOWER ) *pdw |=cpu_to_le32 ((0x01 <<DATA_SC_SHT ) &0x003f0000 );
@@ -171,7 +171,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bagif (adapt->registrypriv.mp_mode ==0 ) {if ((!bagg_pkt) && (urb_zero_packet_chk (adapt, sz) ==0 )) { - ptxdesc = (struct tx_desc *)(pmem+PACKET_OFFSET_SZ ); + ptxdesc = (struct tx_desc *)(pmem +PACKET_OFFSET_SZ ); pull =1 ; } }
@@ -263,11 +263,11 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag ptxdesc->txdw4 |=cpu_to_le32 (BIT (24 ));/* DATA_SHORT */ ptxdesc->txdw5 |=cpu_to_le32 (MRateToHwRate (pmlmeext->tx_rate)); } - }else if ((pxmitframe->frame_tag&0x0f ) ==MGNT_FRAMETAG ) { + }else if ((pxmitframe->frame_tag &0x0f ) ==MGNT_FRAMETAG ) {/* offset 4 */ ptxdesc->txdw1 |=cpu_to_le32 (pattrib->mac_id &0x3f ); - qsel = (uint)(pattrib->qsel&0x0000001f ); + qsel = (uint)(pattrib->qsel &0x0000001f ); ptxdesc->txdw1 |=cpu_to_le32 ((qsel <<QSEL_SHT ) &0x00001f00 ); ptxdesc->txdw1 |=cpu_to_le32 ((pattrib->raid <<RATE_ID_SHT ) &0x000f0000 );
@@ -278,7 +278,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag ptxdesc->txdw2 |=cpu_to_le32 (BIT (19 ));/* offset 12 */ - ptxdesc->txdw3 |=cpu_to_le32 ((pattrib->seqnum<<SEQ_SHT )&0x0FFF0000 ); + ptxdesc->txdw3 |=cpu_to_le32 ((pattrib->seqnum <<SEQ_SHT ) &0x0FFF0000 );/* offset 20 */ ptxdesc->txdw5 |=cpu_to_le32 (RTY_LMT_EN );/* retry limit enable */
@@ -288,7 +288,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag ptxdesc->txdw5 |=cpu_to_le32 (0x00300000 );/* retry limit = 12 */ ptxdesc->txdw5 |=cpu_to_le32 (MRateToHwRate (pmlmeext->tx_rate)); - }else if ((pxmitframe->frame_tag&0x0f ) ==TXAGG_FRAMETAG ) { + }else if ((pxmitframe->frame_tag &0x0f ) ==TXAGG_FRAMETAG ) {DBG_88E ("pxmitframe->frame_tag == TXAGG_FRAMETAG\n" ); }else {DBG_88E ("pxmitframe->frame_tag = %d\n" , pxmitframe->frame_tag);
@@ -301,7 +301,7 @@ static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bag/* offset 8 */ /* offset 12 */ - ptxdesc->txdw3 |=cpu_to_le32 ((pattrib->seqnum<<SEQ_SHT )&0x0fff0000 ); + ptxdesc->txdw3 |=cpu_to_le32 ((pattrib->seqnum <<SEQ_SHT ) &0x0fff0000 );/* offset 20 */ ptxdesc->txdw5 |=cpu_to_le32 (MRateToHwRate (pmlmeext->tx_rate));
@@ -466,7 +466,7 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt,/* 3 2. aggregate same priority and same DA(AP or STA) frames */ pfirstframe = pxmitframe; - len =xmitframe_need_length (pfirstframe) +TXDESC_SIZE + (pfirstframe->pkt_offset*PACKET_OFFSET_SZ ); + len =xmitframe_need_length (pfirstframe) +TXDESC_SIZE + (pfirstframe->pkt_offset *PACKET_OFFSET_SZ ); pbuf_tail = len; pbuf =round_up (pbuf_tail,8 );
@@ -517,7 +517,7 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt, pxmitframe->agg_num =0 ;/* not first frame of aggregation */ pxmitframe->pkt_offset =0 ;/* not first frame of aggregation, no need to reserve offset */ - len =xmitframe_need_length (pxmitframe) +TXDESC_SIZE + (pxmitframe->pkt_offset*PACKET_OFFSET_SZ ); + len =xmitframe_need_length (pxmitframe) +TXDESC_SIZE + (pxmitframe->pkt_offset *PACKET_OFFSET_SZ );if (round_up (pbuf + len,8 ) >MAX_XMITBUF_SZ ) { pxmitframe->agg_num =1 ;
Signature · 1 line
2.17.1
Quoted 8 lines · On Wed, 25 Mar 2020 21:31:42 +0530 Shreeya Patel…
Add space around operators for improving the code
readability.
Reported by checkpatch.plgit diff -w shows no difference.
diff of the .o files before and after the changes shows no difference.Signed-off-by Shreeya Patel <[email protected]>
Reviewed-by Stefano Brivio <[email protected]>
Signature · 1 line
Stefano