Skip to contentSkip to conversation

powerpc xmon: use `dcbf` inplace of `dcbi` instruction for 64bit Book3S

PATCH Applied Balamuruhan S 3 participants 3 messages Mar 30, 2020 – Jul 30, 2020 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 powerpc xmon: use `dcbf` inplace of `dcbi` instruction for 64bit Book3S

Data Cache Block Invalidate (dcbi) instruction implemented back in PowerPC architecture version 2.03. But as per Power Processor Users Manual it is obsolete and not supported by POWER8/POWER9 core. Attempt to use of this illegal instruction results in a hypervisor emulation assistance interrupt. So, ifdef it out the option i in xmon for 64bit Book3S.

0:mon> fi
cpu 0x0: Vector: 700 (Program Check) at [c000000003be74a0]

    pc: c000000000102030: cacheflush+0x180/0x1a0
    lr: c000000000101f3c: cacheflush+0x8c/0x1a0
    sp: c000000003be7730
   msr: 8000000000081033
  current = 0xc0000000035e5c00
  paca    = 0xc000000001910000   irqmask: 0x03   irq_happened: 0x01
    pid   = 1025, comm = bash

Linux version 5.6.0-rc5-g5aa19adac (root@ltc-wspoon6) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) #1 SMP Tue Mar 10 04:38:41 CDT 2020 cpu 0x0: Exception 700 (Program Check) in xmon, returning to main loop [c000000003be7c50] c00000000084abb0 __handle_sysrq+0xf0/0x2a0 [c000000003be7d00] c00000000084b3c0 write_sysrq_trigger+0xb0/0xe0 [c000000003be7d30] c0000000004d1edc proc_reg_write+0x8c/0x130 [c000000003be7d60] c00000000040dc7c __vfs_write+0x3c/0x70 [c000000003be7d80] c000000000410e70 vfs_write+0xd0/0x210 [c000000003be7dd0] c00000000041126c ksys_write+0xdc/0x130 [c000000003be7e20] c00000000000b9d0 system_call+0x5c/0x68 --- Exception: c01 (System Call) at 00007fffa345e420
SP (7ffff0b08ab0) is in userspace

---
 arch/powerpc/xmon/xmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---
changes in v3:
-------------
Fix Christophe's review comments and rebase it on latest mpe's merge tree,
* mention the dcbi obsolete statement based on Power processor users manual in commit message.
* make #ifdef in a more simple way.
changes in v2:
-------------
Fix review comments from Segher and Michael,
* change incorrect architecture version 2.01 to 2.03 in commit message.
* ifdef it out the option i for PPC_BOOK3S_64 instead to drop it and change the commit message accordingly.

arch/powerpc/xmon/xmon.c +1 -1
index ea303b7e4e29..7b62d5dcc4a1 100644
@@ -1808,7 +1808,7 @@ static void cacheflush(void)
 		catch_memory_errors = 1;
 		sync();
 
-		if (cmd != 'i') {
+		if (cmd != 'i' || IS_ENABLED(CONFIG_PPC_BOOK3S_64)) {
 			for (; nflush > 0; --nflush, adrs += L1_CACHE_BYTES)
 				cflush((void *) adrs);
 		} else {

base-commit: 1ad3b5ebe084246ad593a22707cd91ef6418c31e

Signature · 1 line
2.24.1
Reviewed-by on v3 1/1
#1 lore raw

Le 30/03/2020 à 09:59, Balamuruhan S a écrit :

Quoted 28 lines

Data Cache Block Invalidate (dcbi) instruction implemented back in PowerPC architecture version 2.03. But as per Power Processor Users Manual it is obsolete and not supported by POWER8/POWER9 core. Attempt to use of this illegal instruction results in a hypervisor emulation assistance interrupt. So, ifdef it out the option i in xmon for 64bit Book3S.

0:mon> fi
cpu 0x0: Vector: 700 (Program Check) at [c000000003be74a0]

     pc: c000000000102030: cacheflush+0x180/0x1a0
     lr: c000000000101f3c: cacheflush+0x8c/0x1a0
     sp: c000000003be7730
    msr: 8000000000081033
   current = 0xc0000000035e5c00
   paca    = 0xc000000001910000   irqmask: 0x03   irq_happened: 0x01
     pid   = 1025, comm = bash

Linux version 5.6.0-rc5-g5aa19adac (root@ltc-wspoon6) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) #1 SMP Tue Mar 10 04:38:41 CDT 2020 cpu 0x0: Exception 700 (Program Check) in xmon, returning to main loop [c000000003be7c50] c00000000084abb0 __handle_sysrq+0xf0/0x2a0 [c000000003be7d00] c00000000084b3c0 write_sysrq_trigger+0xb0/0xe0 [c000000003be7d30] c0000000004d1edc proc_reg_write+0x8c/0x130 [c000000003be7d60] c00000000040dc7c __vfs_write+0x3c/0x70 [c000000003be7d80] c000000000410e70 vfs_write+0xd0/0x210 [c000000003be7dd0] c00000000041126c ksys_write+0xdc/0x130 [c000000003be7e20] c00000000000b9d0 system_call+0x5c/0x68 --- Exception: c01 (System Call) at 00007fffa345e420
SP (7ffff0b08ab0) is in userspace

Quoted 1 line
Quoted 35 lines
---
  arch/powerpc/xmon/xmon.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

---
changes in v3:
-------------
Fix Christophe's review comments and rebase it on latest mpe's merge tree,
* mention the dcbi obsolete statement based on Power processor users manual in commit message.
* make #ifdef in a more simple way.
changes in v2:
-------------
Fix review comments from Segher and Michael,
* change incorrect architecture version 2.01 to 2.03 in commit message.
* ifdef it out the option i for PPC_BOOK3S_64 instead to drop it and change the commit message accordingly.

arch/powerpc/xmon/xmon.c +1 -1
index ea303b7e4e29..7b62d5dcc4a1 100644
@@ -1808,7 +1808,7 @@ static void cacheflush(void)
  		catch_memory_errors = 1;
  		sync();
 
-		if (cmd != 'i') {
+		if (cmd != 'i' || IS_ENABLED(CONFIG_PPC_BOOK3S_64)) {
  			for (; nflush > 0; --nflush, adrs += L1_CACHE_BYTES)
  				cflush((void *) adrs);
  		} else {

base-commit: 1ad3b5ebe084246ad593a22707cd91ef6418c31e

#2 lore raw
In reply to Balamuruhan S
Quoted 15 lines · Balamuruhan S

Data Cache Block Invalidate (dcbi) instruction implemented back in PowerPC architecture version 2.03. But as per Power Processor Users Manual it is obsolete and not supported by POWER8/POWER9 core. Attempt to use of this illegal instruction results in a hypervisor emulation assistance interrupt. So, ifdef it out the option i in xmon for 64bit Book3S.

0:mon> fi
cpu 0x0: Vector: 700 (Program Check) at [c000000003be74a0]

    pc: c000000000102030: cacheflush+0x180/0x1a0
    lr: c000000000101f3c: cacheflush+0x8c/0x1a0
    sp: c000000003be7730
   msr: 8000000000081033
  current = 0xc0000000035e5c00
  paca    = 0xc000000001910000   irqmask: 0x03   irq_happened: 0x01
    pid   = 1025, comm = bash
Quoted 12 lines

Linux version 5.6.0-rc5-g5aa19adac (root@ltc-wspoon6) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) #1 SMP Tue Mar 10 04:38:41 CDT 2020 cpu 0x0: Exception 700 (Program Check) in xmon, returning to main loop [c000000003be7c50] c00000000084abb0 __handle_sysrq+0xf0/0x2a0 [c000000003be7d00] c00000000084b3c0 write_sysrq_trigger+0xb0/0xe0 [c000000003be7d30] c0000000004d1edc proc_reg_write+0x8c/0x130 [c000000003be7d60] c00000000040dc7c __vfs_write+0x3c/0x70 [c000000003be7d80] c000000000410e70 vfs_write+0xd0/0x210 [c000000003be7dd0] c00000000041126c ksys_write+0xdc/0x130 [c000000003be7e20] c00000000000b9d0 system_call+0x5c/0x68 --- Exception: c01 (System Call) at 00007fffa345e420
SP (7ffff0b08ab0) is in userspace

Applied to powerpc/next.

[1/1] powerpc/xmon: Use dcbf inplace of dcbi instruction for 64bit Book3S

      https://git.kernel.org/powerpc/c/81a413259a224f0d1783c41a74f18864d4f3d67e

cheers