Skip to contentSkip to conversation

ipc: mqueue.c: avoid NULL comparison

PATCH In review Payal Kshirsagar 2 participants 2 messages Mar 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipc: mqueue.c: avoid NULL comparison

Change suggested by coccinelle.
Avoid NULL comparison, compare using boolean negation.

---
 ipc/mqueue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
ipc/mqueue.c +2 -2
index 49a05ba3000d..dbc987d71445 100644
@@ -1361,7 +1361,7 @@ static int do_mq_notify(mqd_t mqdes, const struct sigevent *notification)
 
 	ret = 0;
 	spin_lock(&info->lock);
-	if (notification == NULL) {
+	if (!notification) {
 		if (info->notify_owner == task_tgid(current)) {
 			remove_notification(info);
 			inode->i_atime = inode->i_ctime = current_time(inode);
@@ -1688,7 +1688,7 @@ static int __init init_mqueue_fs(void)
 	mqueue_inode_cachep = kmem_cache_create("mqueue_inode_cache",
 				sizeof(struct mqueue_inode_info), 0,
 				SLAB_HWCACHE_ALIGN|SLAB_ACCOUNT, init_once);
-	if (mqueue_inode_cachep == NULL)
+	if (!mqueue_inode_cachep)
 		return -ENOMEM;
 
 	/* ignore failures - they are not fatal */
Signature · 1 line
2.17.1
#1 lore raw
Quoted 7 lines · Payal Kshirsagar

Change suggested by coccinelle.
Avoid NULL comparison, compare using boolean negation.

---
 ipc/mqueue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I can not take any outreachy patches made outside of drivers/staging, sorry.

So consider this, and your other patch, dropped, sorry.

greg k-h