staging: qlge: Remove extra blank lines
PATCH 1/1 staging: qlge: Remove extra blank lines
Remove unnecessary extra blank lines to improve code readability and to adhere to the Linux Kernel coding style.
Reported by checkpatch.pl
--- drivers/staging/qlge/qlge_mpi.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/qlge/qlge_mpi.c +0 -3
@@ -119,7 +119,6 @@ int ql_own_firmware(struct ql_adapter *qdev)return 1 ;return 0 ; - }static int ql_get_mb_sts (struct ql_adapter *qdev,struct mbox_params *mbcp)
@@ -358,7 +357,6 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp)for (i =0 ; i < mbcp->out_count; i++)netif_err (qdev, drv, qdev->ndev,"mbox_out[%d] = 0x%.08x.\n" , i, mbcp->mbox_out[i]); - }return status;
@@ -406,7 +404,6 @@ static int ql_mpi_handler(struct ql_adapter *qdev, struct mbox_params *mbcp) }switch (mbcp->mbox_out[0 ]) { -/* This case is only active when we arrive here * as a result of issuing a mailbox command to * the firmware.
Signature · 1 line
2.17.1
Quoted 5 lines · On Mon, 30 Mar 2020 10:43:43 +0530 Soumyajit Deb <[email protected]>…
Remove unnecessary extra blank lines to improve code readability and to adhere to the Linux Kernel coding style.
Reported by checkpatch.plSigned-off-by Soumyajit Deb <[email protected]>
This looks good to me, but why isn't it in a series with the next patch you sent? They touch the same driver with similar purposes...
Signature · 1 line
Stefano
Quoted 14 lines · Stefano Brivio
Quoted 5 lines · On Mon, 30 Mar 2020 10:43:43 +0530 Soumyajit Deb <[email protected]>…
Remove unnecessary extra blank lines to improve code readability and to adhere to the Linux Kernel coding style.
Reported by checkpatch.plSigned-off-by Soumyajit Deb <[email protected]>This looks good to me, but why isn't it in a series with the next patch you sent? They touch the same driver with similar purposes...
Signature · 1 line
Stefano
Should I resend this patch along with the other patches concerning the same driver as a patch series?
--
Soumyajit
Quoted 1 line
Quoted 10 lines · On Wed, 1 Apr 2020 00:37:28 +0530 Soumyajit Deb <[email protected]>…
Quoted 9 lines · Stefano Brivio
Quoted 5 lines · On Mon, 30 Mar 2020 10:43:43 +0530 Soumyajit Deb <[email protected]>…
Remove unnecessary extra blank lines to improve code readability and to adhere to the Linux Kernel coding style.
Reported by checkpatch.plSigned-off-by Soumyajit Deb <[email protected]>
Quoted 8 lines
Quoted 5 lines
This looks good to me, but why isn't it in a series with the next patch you sent? They touch the same driver with similar purposes...
Signature · 1 line
StefanoShould I resend this patch along with the other patches concerning the same driver as a patch series?
Yes, exactly -- it's just another invocation of git format-patch, you're almost there.
Signature · 1 line
Stefano
Quoted 16 lines · Stefano Brivio
Quoted 13 lines · On Wed, 1 Apr 2020 00:37:28 +0530 Soumyajit Deb <[email protected]>…
Quoted 12 lines · Stefano Brivio
Quoted 5 lines · On Mon, 30 Mar 2020 10:43:43 +0530 Soumyajit Deb <[email protected]>…
Remove unnecessary extra blank lines to improve code readability and to adhere to the Linux Kernel coding style.
Reported by checkpatch.plSigned-off-by Soumyajit Deb <[email protected]>This looks good to me, but why isn't it in a series with the next patch you sent? They touch the same driver with similar purposes...
Quoted 11 lines
Quoted 5 lines
Quoted 2 lines
Signature · 1 line
StefanoShould I resend this patch along with the other patches concerning the same driver as a patch series?
Yes, exactly -- it's just another invocation of git format-patch, you're almost there.
Signature · 1 line
Stefano
Okay, I will send this patch and the patch after that as a patch series. Thank you.
--
Soumyajit