Skip to contentSkip to conversation

doc: use svg file type for ice nic

PATCH Superseded Haiyue Wang 2 participants 7 messages Mar 31, 2020 – Apr 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: use svg file type for ice nic

Replace the binary format png with text type svg.

---
 doc/guides/nics/img/ice_dcf.png | Bin 39168 -> 0 bytes
 doc/guides/nics/img/ice_dcf.svg | 727 ++++++++++++++++++++++++++++++++
 2 files changed, 727 insertions(+)
 delete mode 100644 doc/guides/nics/img/ice_dcf.png
 create mode 100644 doc/guides/nics/img/ice_dcf.svg
doc/guides/nics/img/ice_dcf.png deleted binary +0 -0
deleted file mode 100644
index 540823c4a05e9ea9d558d233fea77016d1ae5df3..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/nics/img/ice_dcf.svg new file +727 -0

727 lines not on this page · raw message

Signature · 1 line
2.26.0
#1 lore raw

PATCH v2 1/1 doc: use svg file type for ice

Replace the binary format png with text type svg.

---
v2: Fix the commit tile log format error

---
 doc/guides/nics/img/ice_dcf.png | Bin 39168 -> 0 bytes
 doc/guides/nics/img/ice_dcf.svg | 727 ++++++++++++++++++++++++++++++++
 2 files changed, 727 insertions(+)
 delete mode 100644 doc/guides/nics/img/ice_dcf.png
 create mode 100644 doc/guides/nics/img/ice_dcf.svg
doc/guides/nics/img/ice_dcf.png deleted binary +0 -0
deleted file mode 100644
index 540823c4a05e9ea9d558d233fea77016d1ae5df3..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/nics/img/ice_dcf.svg new file +727 -0

727 lines not on this page · raw message

Signature · 1 line
2.26.0
#2 lore raw

Re: [dpdk-dev] [PATCH v2] doc: use svg file type for ice

Quoted 9 lines · Haiyue Wang

Replace the binary format png with text type svg.

---
v2: Fix the commit tile log format error

---
 doc/guides/nics/img/ice_dcf.png | Bin 39168 -> 0 bytes
 doc/guides/nics/img/ice_dcf.svg | 727 ++++++++++++++++++++++++++++++++

<...>

Quoted 10 lines
doc/guides/nics/img/ice_dcf.svg new file +4 -0
new file mode 100644
index 000000000..58851ca5d
@@ -0,0 +1,727 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" width="568px" height="513px" viewBox="0 0 568 513" enable-background="new 0 0 568 513" xml:space="preserve">  <image id="image0" width="568" height="513" x="0" y="0"
+    href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAjgAAAIBCAIAAADLYlLEAAAABGdBTUEAALGPC/xhBQAAACBjSFJN

doc/guides/nics/img/ice_dcf.svg line 14

Quoted 10 lines
doc/guides/nics/img/ice_dcf.svg new file +10 -0
+AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAABmJLR0QA/wD/AP+gvaeTAAAA
+CXBIWXMAABJ0AAASdAHeZh94AACAAElEQVR42uzdZ3wbx5kw8NmO3gGCvVeJpHrvkm3JlmvcHTtx
+Sb1znOSScy538d29l7tcitN9SWynOO7dlquK1XulRIm9N5DoHdj+fqBMURQpUWIBSTz/nz9Yi8Vi
+dgnsszPzzAwWCoU0Gg0CAAAAppJwOIzjOIZhuCzLiS4MAAAAMJQsy/0RCk90SQAAAIBhyJ+DGhUA
+AICp6EKNCgIVAACAKUuWZTLRZQAAXDWe5+vr6xNdCgAmVkZGRv//QKACYPqJRqPvvPNOTk4OhmGJ
+LgsA408Uxba2tm9/+9v9bX4QqACYlkiSfOCBBwiCSHRBABh/oVDo6aef7v9/SKYAAAAw1UF6OgAA
+gCkNAhUAAIApDQIVAACAqWigZwoCFQAAgCkNsv4AAGBCRKPR7du3v/XWW7/4xS9SUlIGtv/+97/n
+ef6WW245duzYwYMHN2zYcMsttwy86nK5vv71r6elpf3P//yPVqsdYxk6OjreeuutXbt29fX1EQSx
+Zs2axx9/3G634/j411J+8pOf6PX6m2++OTMzc3yPPE6ByncK9e0d99MG10KTjzI2J7oQIGHCPIrw
+iS4EQAghJIpMDClaO7q37jl0w+bb+jdGI+E33npnw423RAlNU2ffjs92xkWUM2tBSmoaQigSDu/e

<...>

Hi Haiyue,

This still looks like in binary format. The .svg should be text based, like:

https://git.dpdk.org/dpdk/tree/doc/guides/nics/img/intel_perf_test_setup.svg?h=v20.02

#3 lore raw

Re: [dpdk-dev] [PATCH v2] doc: use svg file type for ice

Quoted 46 lines

-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Tuesday, March 31, 2020 21:25
To: Wang, Haiyue <[email protected]>; [email protected]; Ye, Xiaolong <[email protected]>
Subject: Re: [PATCH v2] doc: use svg file type for ice

Quoted 9 lines · Haiyue Wang

Replace the binary format png with text type svg.

---
v2: Fix the commit tile log format error

---
 doc/guides/nics/img/ice_dcf.png | Bin 39168 -> 0 bytes
 doc/guides/nics/img/ice_dcf.svg | 727 ++++++++++++++++++++++++++++++++

<...>

doc/guides/nics/img/ice_dcf.svg line 3

Quoted 9 lines
doc/guides/nics/img/ice_dcf.svg new file +3 -0
new file mode 100644
index 000000000..58851ca5d
@@ -0,0 +1,727 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg"

xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" width="568px" height="513px" viewBox="0 0 568 513" enable-background="new 0 0 568 513" xml:space="preserve"> <image id="image0" width="568" height="513" x="0" y="0"

doc/guides/nics/img/ice_dcf.svg line 4

Quoted 1 line
doc/guides/nics/img/ice_dcf.svg new file +1 -0
+

href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAjgAAAIBCAIAAADLYlLEAAAABGdBTUEAALGPC/xhBQAAACBjSF JN

Quoted 10 lines
doc/guides/nics/img/ice_dcf.svg new file +10 -0
+AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAABmJLR0QA/wD/AP+gvaeTAAAA
+CXBIWXMAABJ0AAASdAHeZh94AACAAElEQVR42uzdZ3wbx5kw8NmO3gGCvVeJpHrvkm3JlmvcHTtx
+Sb1znOSScy538d29l7tcitN9SWynOO7dlquK1XulRIm9N5DoHdj+fqBMURQpUWIBSTz/nz9Yi8Vi
+dgnsszPzzAwWCoU0Gg0CAAAAppJwOIzjOIZhuCzLiS4MAAAAMJQsy/0RCk90SQAAAIBhyJ+DGhUA
+AICp6EKNCgIVAACAKUuWZTLRZQAAXDWe5+vr6xNdCgAmVkZGRv//QKACYPqJRqPvvPNOTk4OhmGJ
+LgsA408Uxba2tm9/+9v9bX4QqACYlkiSfOCBBwiCSHRBABh/oVDo6aef7v9/SKYAAAAw1UF6OgAA
+gCkNAhUAAIApDQIVAACAqWigZwoCFQAAgCkNsv4AAGBCRKPR7du3v/XWW7/4xS9SUlIGtv/+97/n
+ef6WW245duzYwYMHN2zYcMsttwy86nK5vv71r6elpf3P//yPVqsdYxk6OjreeuutXbt29fX1EQSx
+Zs2axx9/3G634/j411J+8pOf6PX6m2++OTMzc3yPPE6ByncK9e0d99MG10KTjzI2J7oQIGHCPIrw
+iS4EQAghJIpMDClaO7q37jl0w+bb+jdGI+E33npnw423RAlNU2ffjs92xkWUM2tBSmoaQigSDu/e

<...>

Quoted 7 lines

Hi Haiyue,

This still looks like in binary format. The .svg should be text based, like:

https://git.dpdk.org/dpdk/tree/doc/guides/nics/img/intel_perf_test_setup.svg?h=v20.02

Hi Ferruh,

I used the 'https://www.aconvert.com/image/png-to-svg/' online tool to convert the PNG to SVG. Looks like that I need to create it from zero ? Any tools suggested ?

#4 lore raw

Re: [dpdk-dev] [PATCH v2] doc: use svg file type for ice

Quoted 50 lines · Haiyue
Quoted 50 lines

-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Tuesday, March 31, 2020 21:25
To: Wang, Haiyue <[email protected]>; [email protected]; Ye, Xiaolong <[email protected]>
Subject: Re: [PATCH v2] doc: use svg file type for ice

Quoted 9 lines · Haiyue Wang

Replace the binary format png with text type svg.

---
v2: Fix the commit tile log format error

---
 doc/guides/nics/img/ice_dcf.png | Bin 39168 -> 0 bytes
 doc/guides/nics/img/ice_dcf.svg | 727 ++++++++++++++++++++++++++++++++

<...>

doc/guides/nics/img/ice_dcf.svg line 3

Quoted 9 lines
doc/guides/nics/img/ice_dcf.svg new file +3 -0
new file mode 100644
index 000000000..58851ca5d
@@ -0,0 +1,727 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg"

xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" width="568px" height="513px" viewBox="0 0 568 513" enable-background="new 0 0 568 513" xml:space="preserve"> <image id="image0" width="568" height="513" x="0" y="0"

doc/guides/nics/img/ice_dcf.svg line 4

Quoted 1 line
doc/guides/nics/img/ice_dcf.svg new file +1 -0
+

href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAjgAAAIBCAIAAADLYlLEAAAABGdBTUEAALGPC/xhBQAAACBjSF JN

doc/guides/nics/img/ice_dcf.svg line 14

Quoted 10 lines
doc/guides/nics/img/ice_dcf.svg new file +10 -0
+AAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAABmJLR0QA/wD/AP+gvaeTAAAA
+CXBIWXMAABJ0AAASdAHeZh94AACAAElEQVR42uzdZ3wbx5kw8NmO3gGCvVeJpHrvkm3JlmvcHTtx
+Sb1znOSScy538d29l7tcitN9SWynOO7dlquK1XulRIm9N5DoHdj+fqBMURQpUWIBSTz/nz9Yi8Vi
+dgnsszPzzAwWCoU0Gg0CAAAAppJwOIzjOIZhuCzLiS4MAAAAMJQsy/0RCk90SQAAAIBhyJ+DGhUA
+AICp6EKNCgIVAACAKUuWZTLRZQAAXDWe5+vr6xNdCgAmVkZGRv//QKACYPqJRqPvvPNOTk4OhmGJ
+LgsA408Uxba2tm9/+9v9bX4QqACYlkiSfOCBBwiCSHRBABh/oVDo6aef7v9/SKYAAAAw1UF6OgAA
+gCkNAhUAAIApDQIVAACAqWigZwoCFQAAgCkNsv4AAGBCRKPR7du3v/XWW7/4xS9SUlIGtv/+97/n
+ef6WW245duzYwYMHN2zYcMsttwy86nK5vv71r6elpf3P//yPVqsdYxk6OjreeuutXbt29fX1EQSx
+Zs2axx9/3G634/j411J+8pOf6PX6m2++OTMzc3yPPE6ByncK9e0d99MG10KTjzI2J7oQIGHCPIrw
+iS4EQAghJIpMDClaO7q37jl0w+bb+jdGI+E33npnw423RAlNU2ffjs92xkWUM2tBSmoaQigSDu/e

<...>

Hi Haiyue,

This still looks like in binary format. The .svg should be text based, like:

Quoted 9 lines
Quoted 3 lines

https://git.dpdk.org/dpdk/tree/doc/guides/nics/img/intel_perf_test_setup.svg?h=v20.02

Hi Ferruh,

I used the 'https://www.aconvert.com/image/png-to-svg/' online tool to convert the PNG to SVG. Looks like that I need to create it from zero ? Any tools suggested ?

When you convert, tools mostly wraps binary data and it looks like .svg but it is not actually. In the past I remember Inkscape does the conversion to the actual .svg format but it is not trivial and quality reduces a lot. The best way I am aware is to recreate it as .svg from scratch unfortunately.

#5 lore raw

PATCH v3 1/1 doc: use svg file type for ice PMD

In reply to Haiyue Wang

Replace the PNG binary format with SVG text format.

---
v3: Recreate it as .svg from scratch
v2: Fix the commit tile log format error

---
 doc/guides/nics/img/ice_dcf.png | Bin 39168 -> 0 bytes
 doc/guides/nics/img/ice_dcf.svg | 516 ++++++++++++++++++++++++++++++++
 2 files changed, 516 insertions(+)
 delete mode 100644 doc/guides/nics/img/ice_dcf.png
 create mode 100644 doc/guides/nics/img/ice_dcf.svg
doc/guides/nics/img/ice_dcf.png deleted binary +0 -0
deleted file mode 100644
index 540823c4a05e9ea9d558d233fea77016d1ae5df3..0000000000000000000000000000000000000000
GIT binary patch
doc/guides/nics/img/ice_dcf.svg new file +516 -0

516 lines not on this page · raw message

Signature · 1 line
2.26.0
Reviewed-by on v3 1/1
#6 lore raw

Re: [dpdk-dev] [PATCH v3] doc: use svg file type for ice PMD

Quoted 6 lines · Haiyue Wang

Replace the PNG binary format with SVG text format.

---
v3: Recreate it as .svg from scratch
v2: Fix the commit tile log format error

Squashed into relevant commit in next-net, thanks.