Skip to contentSkip to conversation

phy: cadence: salvo: add salvo phy driver

PATCH In review Peter Chen 5 participants 8 messages Apr 1, 2020 – May 7, 2020

Subsystems (3)
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH v4 1/2 phy: cadence: salvo: add salvo phy driver

Cadence SALVO PHY is a 28nm product, and is only used for USB3 & USB2. According to the Cadence, this PHY is a legacy Module, and Sierra and Torrent are later evolutions from it, and their sequence overlap is minimal, meaning we cannot reuse either (Sierra & Torrent) of the PHY drivers.

---
No changes.

 drivers/phy/cadence/Kconfig             |   9 +
 drivers/phy/cadence/Makefile            |   1 +
 drivers/phy/cadence/phy-cadence-salvo.c | 316 ++++++++++++++++++++++++
 3 files changed, 326 insertions(+)
 create mode 100644 drivers/phy/cadence/phy-cadence-salvo.c
drivers/phy/cadence/Kconfig +9 -0
index b2db916db64b..eca272b227b7 100644
@@ -27,3 +27,12 @@ config PHY_CADENCE_SIERRA
 	select GENERIC_PHY
 	help
 	  Enable this to support the Cadence Sierra PHY driver
+
+config PHY_CADENCE_SALVO
+	tristate "Cadence Salvo PHY Driver"
+	depends on OF && HAS_IOMEM
+	select GENERIC_PHY
+	help
+	  Enable this to support the Cadence SALVO PHY driver,
+	  this PHY is a legacy PHY, and only are used for USB3
+	  and USB2.
drivers/phy/cadence/Makefile +1 -0
index 8f89560f1711..7c7d13c0c647 100644
@@ -2,3 +2,4 @@
 obj-$(CONFIG_PHY_CADENCE_DP)	+= phy-cadence-dp.o
 obj-$(CONFIG_PHY_CADENCE_DPHY)	+= cdns-dphy.o
 obj-$(CONFIG_PHY_CADENCE_SIERRA)	+= phy-cadence-sierra.o
+obj-$(CONFIG_PHY_CADENCE_SALVO)	+= phy-cadence-salvo.o
drivers/phy/cadence/phy-cadence-salvo.c new file +316 -0

316 lines not on this page · raw message

Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v4 2/2 doc: dt-binding: cdns-salvo-phy: add binding doc

Add Cadence SALVO PHY binding doc, this PHY is a legacy module, and is only used for USB3 and USB2.

---
Changes for v4:
- Drop the useless description for power-domains
- change unit-address of node as lowercase hex

Changes for v3:
- Fix more schema errors

 .../bindings/phy/cdns,salvo-phy.yaml          | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml
Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml new file +52 -0
new file mode 100644
index 000000000000..3a07285b5470
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (c) 2020 NXP
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/phy/cdns,salvo-phy.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Cadence SALVO PHY
+
+maintainers:
+  - Peter Chen <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - nxp,salvo-phy
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: salvo_phy_clk
+
+  power-domains:
+    maxItems: 1
+
+  "#phy-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/firmware/imx/rsrc.h>
+
+    usb3phy: usb3-phy@5b160000 {
+        compatible = "nxp,salvo-phy";
+        reg = <0x5b160000 0x40000>;
+        clocks = <&usb3_lpcg 4>;
+        clock-names = "salvo_phy_clk";
+        power-domains = <&pd IMX_SC_R_USB_2_PHY>;
+        #phy-cells = <0>;
+    };
Signature · 1 line
2.17.1
maintainer Reviewed-by on v4 2/2
#2 lore raw

Re: [PATH v4 2/2] doc: dt-binding: cdns-salvo-phy: add binding doc

Quoted 9 lines · Peter Chen

Add Cadence SALVO PHY binding doc, this PHY is a legacy module, and is only used for USB3 and USB2.

---
Changes for v4:
- Drop the useless description for power-domains
- change unit-address of node as lowercase hex

Quoted 7 lines

Changes for v3:
- Fix more schema errors

 .../bindings/phy/cdns,salvo-phy.yaml          | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml
#4 lore raw
Quoted 11 lines · Oliver Graute
Quoted 7 lines · Peter Chen

Cadence SALVO PHY is a 28nm product, and is only used for USB3 & USB2. According to the Cadence, this PHY is a legacy Module, and Sierra and Torrent are later evolutions from it, and their sequence overlap is minimal, meaning we cannot reuse either (Sierra & Torrent) of the PHY drivers.

Hi Kithon,

Rob has already acked the dt-binding patch, would you please merge these two patches,
thanks.

Peter

#5 lore raw

Hi Peter,

Quoted 9 lines · Peter Chen
Quoted 8 lines · Oliver Graute
Quoted 6 lines · Peter Chen

Cadence SALVO PHY is a 28nm product, and is only used for USB3 & USB2. According to the Cadence, this PHY is a legacy Module, and Sierra and Torrent are later evolutions from it, and their sequence overlap is minimal, meaning we cannot reuse either (Sierra & Torrent) of the PHY drivers.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Hi Kithon,

Rob has already acked the dt-binding patch, would you please merge these two patches,

Sure, I'll be merging it this week.

Thanks
Kishon

#6 lore raw
Quoted 15 lines · Kishon Vijay Abraham I

Hi Peter,

Quoted 11 lines · Peter Chen
Quoted 10 lines · Oliver Graute
Quoted 7 lines · Peter Chen

Cadence SALVO PHY is a 28nm product, and is only used for USB3 & USB2. According to the Cadence, this PHY is a legacy Module, and Sierra and Torrent are later evolutions from it, and their sequence overlap is minimal, meaning we cannot reuse either (Sierra & Torrent) of the PHY drivers.

Quoted 9 lines
Quoted 6 lines
Quoted 1 line

Hi Kithon,

Rob has already acked the dt-binding patch, would you please merge these two patches,

Sure, I'll be merging it this week.

HI Kishon,

I still not find it at your next tree:

https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git/tree/drivers/phy/cadence?h=next

Would you please merge it, I have patches based on it, thanks.

Peter

#7 lore raw

+Vinod

Quoted 26 lines · Peter Chen
Quoted 15 lines · Kishon Vijay Abraham I

Hi Peter,

Quoted 11 lines · Peter Chen
Quoted 10 lines · Oliver Graute
Quoted 7 lines · Peter Chen

Cadence SALVO PHY is a 28nm product, and is only used for USB3 & USB2. According to the Cadence, this PHY is a legacy Module, and Sierra and Torrent are later evolutions from it, and their sequence overlap is minimal, meaning we cannot reuse either (Sierra & Torrent) of the PHY drivers.

Quoted 9 lines
Quoted 6 lines
Quoted 1 line

Hi Kithon,

Rob has already acked the dt-binding patch, would you please merge these two patches,

Sure, I'll be merging it this week.

Quoted 7 lines

HI Kishon,

I still not find it at your next tree:

https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git/tree/drivers/phy/cadence?h=next

Would you please merge it, I have patches based on it, thanks.

merged this now, thanks!

-Kishon