smack: fix a missing-check bug in smack_sb_eat_lsm_opts()
Subsystems (2)
PATCH 1/1 smack: fix a missing-check bug in smack_sb_eat_lsm_opts()
In smack_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It returns NULL when fails, add check for it.
Signed-off-by Chen Zhou <[email protected]>
--- security/smack/smack_lsm.c | 2 ++ 1 file changed, 2 insertions(+)
security/smack/smack_lsm.c +2 -0
@@ -731,6 +731,8 @@ static int smack_sb_eat_lsm_opts(char *options, void **mnt_opts) token =match_opt_prefix (from, len, &arg);if (token != Opt_error) { arg =kmemdup_nul (arg, from + len - arg,GFP_KERNEL ); +if (!arg) +return -ENOMEM ; rc =smack_add_opt (token, arg, mnt_opts);if (unlikely (rc)) {kfree (arg);
Signature · 1 line
2.7.4
Quoted 2 lines · Chen Zhou
In
smack_sb_eat_lsm_opts(), 'arg' is allocated bykmemdup_nul(). It returns NULL when fails, add check for it.
Thanks. But this check is not needed, for smack_add_opt() returns NULL if arg == NULL.