Skip to contentSkip to conversation

ASoC: topology: use name_prefix for new kcontrol

PATCH In review 이경택 2 participants 3 messages Apr 1, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200401004223epcas2p2a2b0f54f83ea8fa0c1a1b96660cf4b69@epcas2p2.samsung.com

이경택

author
#1 lore raw

PATCH 2/3 ASoC: topology: use name_prefix for new kcontrol

Current topology doesn't add prefix of component to new kcontrol.

---
 sound/soc/soc-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-topology.c +1 -1
index 575da6aba807..a152409e8746 100644
@@ -362,7 +362,7 @@ static int soc_tplg_add_kcontrol(struct soc_tplg *tplg,
 	struct snd_soc_component *comp = tplg->comp;
 
 	return soc_tplg_add_dcontrol(comp->card->snd_card,
-				comp->dev, k, NULL, comp, kcontrol);
+				comp->dev, k, comp->name_prefix, comp, kcontrol);
 }
 
 /* remove a mixer kcontrol */
Signature · 1 line
2.21.0
maintainer
#2 lore raw
Quoted 1 line · �̰���

Current topology doesn't add prefix of component to new kcontrol.

Please only number patches if you are sending them as part of a patch series, the purpose of numbering is to make sure that things get handled in the right order. Without a series it looks like there are some missing patches.

author
#3 lore raw
Quoted 8 lines · Mark Brown
Quoted 1 line · �̰���

Current topology doesn't add prefix of component to new kcontrol.

Please only number patches if you are sending them as part of a patch series, the purpose of numbering is to make sure that things get handled in the right order. Without a series it looks like there are some missing patches.

I'm trying to catch up the merge process now. Let me know if anything has gone wrong.
I removed the patch number and re-sent the patch again.

Sorry and thank you for your review.