Skip to contentSkip to conversation

pinctrl: baytrail: Enable pin configuration setting for GPIO chip

PATCH In review Andy Shevchenko 2 participants 3 messages Mar 31, 2020 – Apr 13, 2020

Subsystems (3)
GPIO Pin control Pin controller - Intel
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 pinctrl: baytrail: Enable pin configuration setting for GPIO chip

It appears that pin configuration for GPIO chip hasn't been enabled yet due to absence of ->set_config() callback.

Enable it here for Intel Baytrail.

Fixes c501d0b149de ("pinctrl: baytrail: Add pin control operations")

Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/pinctrl/intel/pinctrl-baytrail.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/intel/pinctrl-baytrail.c +1 -0
index b409642f168d..9b821c9cbd16 100644
@@ -1286,6 +1286,7 @@ static const struct gpio_chip byt_gpio_chip = {
 	.direction_output	= byt_gpio_direction_output,
 	.get			= byt_gpio_get,
 	.set			= byt_gpio_set,
+	.set_config		= gpiochip_generic_config,
 	.dbg_show		= byt_gpio_dbg_show,
 };
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Andy Shevchenko

It appears that pin configuration for GPIO chip hasn't been enabled yet due to absence of ->set_config() callback.

Enable it here for Intel Baytrail.

Fixes c501d0b149de ("pinctrl: baytrail: Add pin control operations")

Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")

Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Mika Westerberg <[email protected]>
author Applied
#2 lore raw
Quoted 11 lines · Mika Westerberg
Quoted 8 lines · Andy Shevchenko

It appears that pin configuration for GPIO chip hasn't been enabled yet due to absence of ->set_config() callback.

Enable it here for Intel Baytrail.

Fixes c501d0b149de ("pinctrl: baytrail: Add pin control operations")

Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")

Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Mika Westerberg <[email protected]>

Pushed to fixes, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko