tty/sysrq: Export sysrq_mask()
PATCH 1/1 tty/sysrq: Export sysrq_mask()
Build fix for serial_core being module:
ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
--- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+)
drivers/tty/sysrq.c +1 -0
@@ -74,6 +74,7 @@ int sysrq_mask(void)return 1 ;return sysrq_enabled; } +EXPORT_SYMBOL_GPL (sysrq_mask);/* * A value of 1 means 'all', other nonzero values are an op mask:
Signature · 1 line
2.25.1
Greg Kroah-Hartman
maintainerQuoted 11 lines · Dmitry Safonov
Build fix for
serial_corebeing module:
ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!Cc Greg Kroah-Hartman <[email protected]>Cc Jiri Slaby <[email protected]>Reported-by "kernelci.org bot" <[email protected]>Reported-by Michael Ellerman <[email protected]>Signed-off-by Dmitry Safonov <[email protected]>--- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+)
Is this a new problem? What commit does this fix?
thanks,
greg k-h
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Dmitry Safonov
Build fix for
serial_corebeing module:
ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!Cc Greg Kroah-Hartman <[email protected]>Cc Jiri Slaby <[email protected]>Reported-by "kernelci.org bot" <[email protected]>Reported-by Michael Ellerman <[email protected]>Signed-off-by Dmitry Safonov <[email protected]>--- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+)
Quoted 1 line
Is this a new problem? What commit does this fix?
Right, sorry I've managed to forget adding the tag:
Maybe also:
Link:
https://lore.kernel.org/linux-fsdevel/[email protected]/
Thanks,
Dmitry
Greg Kroah-Hartman
maintainerQuoted 16 lines · Dmitry Safonov
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Dmitry Safonov
Build fix for
serial_corebeing module:
ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!Cc Greg Kroah-Hartman <[email protected]>Cc Jiri Slaby <[email protected]>Reported-by "kernelci.org bot" <[email protected]>Reported-by Michael Ellerman <[email protected]>Signed-off-by Dmitry Safonov <[email protected]>--- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+)Quoted 1 line
Is this a new problem? What commit does this fix?
Quoted 8 lines
Right, sorry I've managed to forget adding the tag:
Fixes eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")Maybe also:
Link:
https://lore.kernel.org/linux-fsdevel/[email protected]/
Thanks, that works. WIll queue this up after -rc1 is out.
greg k-h
Quoted 19 lines · Greg Kroah-Hartman
Quoted 18 lines · Dmitry Safonov
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Dmitry Safonov
Build fix for
serial_corebeing module:
ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!Cc Greg Kroah-Hartman <[email protected]>Cc Jiri Slaby <[email protected]>Reported-by "kernelci.org bot" <[email protected]>Reported-by Michael Ellerman <[email protected]>Signed-off-by Dmitry Safonov <[email protected]>--- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+)Quoted 1 line
Is this a new problem? What commit does this fix?
Right, sorry I've managed to forget adding the tag:
Quoted 8 lines
Quoted 6 lines
Fixes eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")Maybe also:
Link:
https://lore.kernel.org/linux-fsdevel/[email protected]/Thanks, that works. WIll queue this up after -rc1 is out.
Why wait until after rc1?
It's a build break for a bunch of folks and the fix is obviously correct (famous last words).
cheers
Quoted 28 lines · Michael Ellerman
Quoted 26 lines · Greg Kroah-Hartman
Quoted 24 lines · Dmitry Safonov
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Dmitry Safonov
Build fix for
serial_corebeing module:
ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!Cc Greg Kroah-Hartman <[email protected]>Cc Jiri Slaby <[email protected]>Reported-by "kernelci.org bot" <[email protected]>Reported-by Michael Ellerman <[email protected]>Signed-off-by Dmitry Safonov <[email protected]>--- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+)Quoted 1 line
Is this a new problem? What commit does this fix?
Right, sorry I've managed to forget adding the tag:
Fixes eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")Maybe also:
Link:
https://lore.kernel.org/linux-fsdevel/[email protected]/
Quoted 6 lines
Quoted 1 line
Thanks, that works. WIll queue this up after -rc1 is out.
Why wait until after rc1?
It's a build break for a bunch of folks and the fix is obviously correct (famous last words).
definitely seems like something that should be fixed prior to rc1, s390 builds in fedora are hitting it.
Dave.
Greg Kroah-Hartman
maintainerQuoted 31 lines · Dave Airlie
Quoted 30 lines · Michael Ellerman
Quoted 27 lines · Greg Kroah-Hartman
Quoted 16 lines · Dmitry Safonov
Quoted 13 lines · Greg Kroah-Hartman
Quoted 11 lines · Dmitry Safonov
Build fix for
serial_corebeing module:
ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!Cc Greg Kroah-Hartman <[email protected]>Cc Jiri Slaby <[email protected]>Reported-by "kernelci.org bot" <[email protected]>Reported-by Michael Ellerman <[email protected]>Signed-off-by Dmitry Safonov <[email protected]>--- drivers/tty/sysrq.c | 1 + 1 file changed, 1 insertion(+)Quoted 1 line
Is this a new problem? What commit does this fix?
Quoted 8 lines
Right, sorry I've managed to forget adding the tag:
Fixes eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")Maybe also:
Link:
https://lore.kernel.org/linux-fsdevel/[email protected]/Thanks, that works. WIll queue this up after -rc1 is out.
Quoted 7 lines
Quoted 4 lines
Why wait until after rc1?
It's a build break for a bunch of folks and the fix is obviously correct (famous last words).
definitely seems like something that should be fixed prior to rc1, s390 builds in fedora are hitting it.
Ugh, I missed this, I'll go queue this up now, sorry for the delay...
greg k-h