drivers: gpio: xgene-sb: set valid IRQ type in to_irq()
PATCH 1/1 drivers: gpio: xgene-sb: set valid IRQ type in to_irq()
xgene-sb is setup to be a hierarchical IRQ chip with the GIC as the parent chip. xgene_gpio_sb_to_irq() currently sets the default IRQ type to IRQ_TYPE_NONE, which the GIC loudly complains about with a WARN_ON(). Let's set the initial default to a sane value (IRQ_TYPE_EDGE_RISING) that was determined by decoding the ACPI tables on affected hardware:
Device (_SB.GPSB)
{
Name (_HID, "APMC0D15") // _HID: Hardware ID
Name (_CID, "APMC0D15") // _CID: Compatible ID
Name (_UID, "GPIOSB") // _UID: Unique ID
...
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
...
Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, ,, )
{
0x00000048,
}
...
}
}This can be overridden later as needed with irq_set_irq_type().
--- drivers/gpio/gpio-xgene-sb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpio-xgene-sb.c +1 -1
@@ -122,7 +122,7 @@ static int xgene_gpio_sb_to_irq(struct gpio_chip *gc, u32 gpio) fwspec.fwnode = gc->parent->fwnode; fwspec.param_count =2 ; fwspec.param[0 ] =GPIO_TO_HWIRQ (priv, gpio); - fwspec.param[1 ] =IRQ_TYPE_NONE ; + fwspec.param[1 ] =IRQ_TYPE_EDGE_RISING ;return irq_create_fwspec_mapping (&fwspec); }
Signature · 1 line
2.25.1
śr., 1 kwi 2020 o 19:49 Brian Masney <[email protected]> napisał(a):
Quoted 45 lines
xgene-sb is setup to be a hierarchical IRQ chip with the GIC as the parent chip.
xgene_gpio_sb_to_irq()currently sets the default IRQ type toIRQ_TYPE_NONE, which the GIC loudly complains about with aWARN_ON(). Let's set the initial default to a sane value (IRQ_TYPE_EDGE_RISING) that was determined by decoding the ACPI tables on affected hardware:Device (_SB.GPSB) { Name (_HID, "APMC0D15") // _HID: Hardware ID Name (_CID, "APMC0D15") // _CID: Compatible ID Name (_UID, "GPIOSB") // _UID: Unique ID ... Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings { ... Interrupt (ResourceConsumer, Edge, ActiveHigh, Exclusive, ,, ) { 0x00000048, } ... } }This can be overridden later as needed with
irq_set_irq_type().Signed-off-by Brian Masney <[email protected]>--- drivers/gpio/gpio-xgene-sb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpio/gpio-xgene-sb.c +1
-2@@ -122,7 +122,7 @@ static int xgene_gpio_sb_to_irq(struct gpio_chip *gc, u32 gpio) fwspec.fwnode = gc->parent->fwnode; fwspec.param_count =2 ; fwspec.param[0 ] =GPIO_TO_HWIRQ (priv, gpio); - fwspec.param[1 ] =IRQ_TYPE_NONE ; + fwspec.param[1 ] =IRQ_TYPE_EDGE_RISING ;return irq_create_fwspec_mapping (&fwspec); } --
Quoted 2 lines
2.25.1
Patch applied, thanks!
Bartosz