Skip to contentSkip to conversation

package/nftables: check for python

PATCH New aduskett at gmail.com 3 participants 11 messages Mar 30, 2020 – Apr 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 package/nftables: check for python

From: Adam Duskett <[email protected]>

If python or python3 is selected, nftables should depend on the package and set the --enable-python option, otherwise set --disable-python

---
 package/nftables/nftables.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/nftables/nftables.mk +7 -0
index 11ef6844ce..210e950c11 100644
@@ -27,6 +27,13 @@ else
 NFTABLES_CONF_OPTS += --without-json
 endif
 
+ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
+NFTABLES_CONF_OPTS += --enable-python
+NFTABLES_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,python3)
+else
+NFTABLES_CONF_OPTS += --disable-python
+endif
+
 ifeq ($(BR2_STATIC_LIBS)$(BR2_PACKAGE_LIBNFTNL_JSON),yy)
 NFTABLES_LIBS += -ljansson -lm
 endif
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/5 linux: add automatic nftables config selection

From: Adam Duskett <[email protected]>

Select the minimum amount of kernel features to enable nftables when the nftables package is selected.

---
 linux/linux.mk | 4 ++++
 1 file changed, 4 insertions(+)
linux/linux.mk +4 -0
index 1927832e7e..3c797aab88 100644
@@ -389,6 +389,10 @@ define LINUX_KCONFIG_FIXUP_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_FILTER,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_XTABLES,$(@D)/.config))
+	$(if $(BR2_PACKAGE_NFTABLES),
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_INET,$(@D)/.config))
 	$(if $(BR2_PACKAGE_XTABLES_ADDONS),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_ADVANCED,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK,$(@D)/.config)
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/5 linux: add automatic nftables config selection

Adam, All,

On 2020-03-30 16:46 -0700, aduskett at gmail.com spake thusly:

Quoted 15 lines

From: Adam Duskett <[email protected]>

Select the minimum amount of kernel features to enable nftables when the nftables package is selected.

---
 linux/linux.mk | 4 ++++
 1 file changed, 4 insertions(+)
linux/linux.mk +0 -0
index 1927832e7e..3c797aab88 100644

linux/linux.mk define LINUX_KCONFIG_FIXUP_CMDS · line 395

Quoted 7 lines
linux/linux.mk +4 -0
@@ -389,6 +389,10 @@ define LINUX_KCONFIG_FIXUP_CMDS
 		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_FILTER,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_XTABLES,$(@D)/.config))
+	$(if $(BR2_PACKAGE_NFTABLES),
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_INET,$(@D)/.config))

As you know, we have a pending series that moves such selections out of linux.mk and into the corresponding packages.

As such, I'm not sure what to do with that patch for now. Since anyway the rest of the series is (or will soon be) marked as changes requested, I've done the same for that patch.

Regards,
Yann E. MORIN.

Quoted 10 lines
linux/linux.mk +0 -0
 	$(if $(BR2_PACKAGE_XTABLES_ADDONS),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_ADVANCED,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK,$(@D)/.config)
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 3/5 package/python-slip-dbus: new package

In reply to aduskett at gmail.com

From: Adam Duskett <[email protected]>

A dbus.service.Object derivative that ends
itself after a certain time without being used and/or if there are no clients anymore on the message bus, as well as convenience functions and decorators for integrating a dbus service with PolicyKit.

---
 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 package/python-slip-dbus/Config.in            | 29 +++++++++++++++++++
 .../python-slip-dbus/python-slip-dbus.hash    |  3 ++
 package/python-slip-dbus/python-slip-dbus.mk  | 20 +++++++++++++
 5 files changed, 54 insertions(+)
 create mode 100644 package/python-slip-dbus/Config.in
 create mode 100644 package/python-slip-dbus/python-slip-dbus.hash
 create mode 100644 package/python-slip-dbus/python-slip-dbus.mk
DEVELOPERS +1 -0
index f1bf5c263c..64f0333fbb 100644
@@ -73,6 +73,7 @@ F:	package/python-nested-dict/
 F:	package/python-pbr/
 F:	package/python-pip/
 F:	package/python-psycopg2/
+F:	package/python-slip-dbus/
 F:	package/python-smmap2/
 F:	package/python-sqlalchemy/
 F:	package/python-sqlparse/
package/Config.in +1 -0
index 4aaf2d93f8..e6c5bb11c6 100644
@@ -1143,6 +1143,7 @@ menu "External python modules"
 	source "package/python-singledispatch/Config.in"
 	source "package/python-sip/Config.in"
 	source "package/python-six/Config.in"
+	source "package/python-slip-dbus/Config.in"
 	source "package/python-slob/Config.in"
 	source "package/python-smbus-cffi/Config.in"
 	source "package/python-smmap2/Config.in"
package/python-slip-dbus/Config.in new file +29 -0
new file mode 100644
index 0000000000..98bc762055
@@ -0,0 +1,29 @@
+config BR2_PACKAGE_PYTHON_SLIP_DBUS
+	bool "python-slip-dbus"
+	depends on BR2_PACKAGE_DBUS # runtime
+	depends on BR2_USE_MMU # libglib2, gobject-introspection
+	depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS # gobject-introspection
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # gobject-introspection
+	depends on BR2_TOOLCHAIN_USES_GLIBC # gobject-introspection
+	depends on BR2_PACKAGE_PYTHON3 # gobject-introspection
+	select BR2_PACKAGE_DBUS_PYTHON # runtime
+	select BR2_PACKAGE_PYTHON_DECORATOR  # runtime
+	select BR2_PACKAGE_PYTHON_GOBJECT  # runtime
+	select BR2_PACKAGE_PYTHON_SIX # runtime
+	help
+	  A dbus.service.Object derivative that ends
+	  itself after a certain time without being used and/or if there
+	  are no clients anymore on the message bus, as well as
+	  convenience functions and decorators for integrating a dbus
+	  service with PolicyKit.
+
+	  https://github.com/nphilipp/python-slip
+
+comment "python-slip-dbus needs python3"
+	depends on !BR2_PACKAGE_PYTHON3
+
+comment "python-slip-dbus needs a glibc toolchain, gcc >= 4.9"
+	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_DBUS && BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
package/python-slip-dbus/python-slip-dbus.hash new file +3 -0
new file mode 100644
index 0000000000..8a88533169
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  7a52ebe49945cd27d06a1172042a55eb5c79cfda49b742153fa076d1d9bd99a1  python-slip-0.6.5.tar.gz
+sha256  1ca3e8f71b7de618968e7ea9fe47822d9e704dc476aef8544033abedec355225  COPYING
package/python-slip-dbus/python-slip-dbus.mk new file +20 -0
new file mode 100644
index 0000000000..20b587fd5c
@@ -0,0 +1,20 @@
+################################################################################
+#
+# python-slip-dbus
+#
+################################################################################
+
+PYTHON_SLIP_DBUS_VERSION = 0.6.5
+PYTHON_SLIP_DBUS_SOURCE = python-slip-$(PYTHON_SLIP_DBUS_VERSION).tar.gz
+PYTHON_SLIP_DBUS_SITE = https://github.com/nphilipp/python-slip/archive
+PYTHON_SLIP_DBUS_LICENSE = GPL-2.0+
+PYTHON_SLIP_DBUS_LICENSE_FILES = COPYING
+PYTHON_SLIP_DBUS_SETUP_TYPE = distutils
+PYTHON_SLIP_DBUS_DEPENDENCIES = python-gobject
+
+define PYTHON_SLIP_DBUS_APPEND_VERSION
+	cd $(@D); sed -e 's/@VERSION@/$(PYTHON_SLIP_DBUS_VERSION)/g' setup.py.in > setup.py
+endef
+PYTHON_SLIP_DBUS_PRE_CONFIGURE_HOOKS += PYTHON_SLIP_DBUS_APPEND_VERSION
+
+$(eval $(python-package))
Signature · 1 line
2.25.1
#4 lore raw

PATCH 3/5 package/python-slip-dbus: new package

On 2020-03-30 16:46 -0700, aduskett at gmail.com spake thusly:

Quoted 7 lines

From: Adam Duskett <[email protected]>

A dbus.service.Object derivative that ends
itself after a certain time without being used and/or if there are no clients anymore on the message bus, as well as convenience functions and decorators for integrating a dbus service with PolicyKit.

Repeating the package description in the commit log is usally not very useful.

However, see below for what should appear in a commit log...

Quoted 2 lines

---

[--SNIP--]

package/python-slip-dbus/Config.in line 3

Quoted 9 lines
package/python-slip-dbus/Config.in new file +3 -0
new file mode 100644
index 0000000000..98bc762055
@@ -0,0 +1,29 @@
+config BR2_PACKAGE_PYTHON_SLIP_DBUS
+	bool "python-slip-dbus"
+	depends on BR2_PACKAGE_DBUS # runtime

I think we want it to select dbus.

So it needs threads as well.

Quoted 16 lines
package/python-slip-dbus/Config.in new file +16 -0
+	depends on BR2_USE_MMU # libglib2, gobject-introspection
+	depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS # gobject-introspection
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # gobject-introspection
+	depends on BR2_TOOLCHAIN_USES_GLIBC # gobject-introspection
+	depends on BR2_PACKAGE_PYTHON3 # gobject-introspection
+	select BR2_PACKAGE_DBUS_PYTHON # runtime
+	select BR2_PACKAGE_PYTHON_DECORATOR  # runtime
+	select BR2_PACKAGE_PYTHON_GOBJECT  # runtime
+	select BR2_PACKAGE_PYTHON_SIX # runtime
+	help
+	  A dbus.service.Object derivative that ends
+	  itself after a certain time without being used and/or if there
+	  are no clients anymore on the message bus, as well as
+	  convenience functions and decorators for integrating a dbus
+	  service with PolicyKit.
+

package/python-slip-dbus/Config.in line 29

Quoted 10 lines
package/python-slip-dbus/Config.in new file +10 -0
+	  https://github.com/nphilipp/python-slip
+
+comment "python-slip-dbus needs python3"
+	depends on !BR2_PACKAGE_PYTHON3
+
+comment "python-slip-dbus needs a glibc toolchain, gcc >= 4.9"
+	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_DBUS && BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

I don't like it when there are two comments about the dependencies of a single package. What about;

comment "python-slip-dbus needs python3, and a glibc toolchain w/ gcc >= 4.9, threads"
depends on BR2_USE_MMU
depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_TOOLCHAIN_USES_GLIBC \
|| !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_PYTHON3

Quoted 23 lines
package/python-slip-dbus/python-slip-dbus.hash new file +3 -0
new file mode 100644
index 0000000000..8a88533169
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  7a52ebe49945cd27d06a1172042a55eb5c79cfda49b742153fa076d1d9bd99a1  python-slip-0.6.5.tar.gz
+sha256  1ca3e8f71b7de618968e7ea9fe47822d9e704dc476aef8544033abedec355225  COPYING
package/python-slip-dbus/python-slip-dbus.mk new file +8 -0
new file mode 100644
index 0000000000..20b587fd5c
@@ -0,0 +1,20 @@
+################################################################################
+#
+# python-slip-dbus
+#
+################################################################################
+
+PYTHON_SLIP_DBUS_VERSION = 0.6.5
+PYTHON_SLIP_DBUS_SOURCE = python-slip-$(PYTHON_SLIP_DBUS_VERSION).tar.gz

package/python-slip-dbus/python-slip-dbus.mk line 18

Quoted 10 lines
package/python-slip-dbus/python-slip-dbus.mk new file +10 -0
+PYTHON_SLIP_DBUS_SITE = https://github.com/nphilipp/python-slip/archive
+PYTHON_SLIP_DBUS_LICENSE = GPL-2.0+
+PYTHON_SLIP_DBUS_LICENSE_FILES = COPYING
+PYTHON_SLIP_DBUS_SETUP_TYPE = distutils
+PYTHON_SLIP_DBUS_DEPENDENCIES = python-gobject
+
+define PYTHON_SLIP_DBUS_APPEND_VERSION
+	cd $(@D); sed -e 's/@VERSION@/$(PYTHON_SLIP_DBUS_VERSION)/g' setup.py.in > setup.py
+endef
+PYTHON_SLIP_DBUS_PRE_CONFIGURE_HOOKS += PYTHON_SLIP_DBUS_APPEND_VERSION

Explanations for this hook should appear in the commit log, bewcause it is far from obvious why this is needed.

I've marked as changes requested; care to address those and respin, please?

Thanks!

Regards,
Yann E. MORIN.

Quoted 8 lines
package/python-slip-dbus/python-slip-dbus.mk new file +1 -0
+$(eval $(python-package))
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 4/5 package/firewalld: new package

In reply to aduskett at gmail.com

From: Adam Duskett <[email protected]>

Firewalld provides a dynamically managed firewall with support for network or firewall zones to define the trust level of network connections or interfaces. It has support for IPv4, IPv6 firewall settings and for ethernet bridges and a separation of runtime and permanent configuration options.

It also provides an interface for services or applications to add iptables and ebtables rules directly.

---
 DEVELOPERS                                    |  1 +
 package/Config.in                             |  1 +
 ...on-to-disable-building-documentation.patch | 90 +++++++++++++++++++
 package/firewalld/Config.in                   | 42 +++++++++
 package/firewalld/firewalld.hash              |  3 +
 package/firewalld/firewalld.init              | 52 +++++++++++
 package/firewalld/firewalld.mk                | 79 ++++++++++++++++
 7 files changed, 268 insertions(+)
 create mode 100644 package/firewalld/0001-Add-an-option-to-disable-building-documentation.patch
 create mode 100644 package/firewalld/Config.in
 create mode 100644 package/firewalld/firewalld.hash
 create mode 100644 package/firewalld/firewalld.init
 create mode 100644 package/firewalld/firewalld.mk
DEVELOPERS +1 -0
index 64f0333fbb..240ceb6533 100644
@@ -31,6 +31,7 @@ F:	package/audit/
 F:	package/busybox/
 F:	package/checkpolicy/
 F:	package/cppdb/
+F:	package/firewalld/
 F:	package/gobject-introspection/
 F:	package/gstreamer1/gstreamer1/
 F:	package/gstreamer1/gstreamer1-mm/
package/Config.in +1 -0
index e6c5bb11c6..dbe084711c 100644
@@ -2016,6 +2016,7 @@ menu "Networking applications"
 	source "package/fail2ban/Config.in"
 	source "package/fastd/Config.in"
 	source "package/fcgiwrap/Config.in"
+	source "package/firewalld/Config.in"
 	source "package/flannel/Config.in"
 	source "package/fmc/Config.in"
 	source "package/fping/Config.in"
package/firewalld/0001-Add-an-option-to-disable-building-documentation.patch new file +90 -0

90 lines not on this page · raw message

package/firewalld/Config.in new file +42 -0

42 lines not on this page · raw message

package/firewalld/firewalld.hash new file +3 -0
new file mode 100644
index 0000000000..ed4ac54a67
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 cfdf40890bca18892d1695bd902ede695cb2a61e1fcf809a2f8c394ca788a31e firewalld-v0.8.1.tar.gz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING
package/firewalld/firewalld.init new file +52 -0

52 lines not on this page · raw message

package/firewalld/firewalld.mk new file +79 -0

79 lines not on this page · raw message

Signature · 1 line
2.25.1
#6 lore raw

PATCH 4/5 package/firewalld: new package

Adam, All,

On 2020-03-30 16:46 -0700, aduskett at gmail.com spake thusly:

Quoted 9 lines

From: Adam Duskett <[email protected]>

Firewalld provides a dynamically managed firewall with support for network or firewall zones to define the trust level of network connections or interfaces. It has support for IPv4, IPv6 firewall settings and for ethernet bridges and a separation of runtime and permanent configuration options.

It also provides an interface for services or applications to add iptables and ebtables rules directly.

Again, repeating the package description in the commit log is not that useful...

Quoted 2 lines

---

[--SNIP--]

Quoted 20 lines
package/firewalld/0001-Add-an-option-to-disable-building-documentation.patch new file +14 -0
new file mode 100644
index 0000000000..150a74a4a5
@@ -0,0 +1,90 @@
+From 1627f1046515e93f7acb34fbfededecf9e1b16a7 Mon Sep 17 00:00:00 2001
+From: Adam Duskett <[email protected]>
+Date: Sun, 29 Mar 2020 16:28:06 -0700
+Subject: [PATCH] improvement: build: add an option to disable building
+ documentation
+
+For embedded applications such as Buildroot or Yocto, the man pages may not be
+desired or even capable of being built.
+
+On line 45 of configure.ac there is the line:
+JH_CHECK_XML_CATALOG([http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl], [DocBook XSL Stylesheets])
+
+There are three issues with this:
+  - It requires building the xml-catalog package.

package/firewalld/0001-Add-an-option-to-disable-building-documentation.patch line 24

Quoted 10 lines
package/firewalld/0001-Add-an-option-to-disable-building-documentation.patch new file +10 -0
+  - It automatically defaults to the host systems xml-catalog
+    instead of the cross environments.
+  - It isn't necessary to have a functioning firewalld.
+
+Create a new option: --disable-docs. By default, build the documentation, but
+if a user passes --disable-docs documentation will no longer be built as
+desired.
+
+Upstream-Status: Merged
+See: https://github.com/firewalld/firewalld/pull/596

The usual way we identify backoprted patches is not from their merge request, but by stating how it wsa backported, like:

    Backported-from: 1627f1046515e93f7acb34fbfededecf9e1b16a7
oe:
    upstream commit: 1627f1046515e93f7acb34fbfededecf9e1b16a7

[--SNIP--]

package/firewalld/Config.in line 6

Quoted 12 lines
package/firewalld/Config.in new file +6 -0
new file mode 100644
index 0000000000..2b74655b1a
@@ -0,0 +1,42 @@
+config BR2_PACKAGE_FIREWALLD
+	bool "firewalld"
+	depends on BR2_USE_MMU # ebtables, gobject-introspection
+	depends on BR2_USE_WCHAR # dbus-python, gettext
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 # nftables
+	depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS # gobject-introspection

Move that one up below MMU, as it is an arch-related dependency.

package/firewalld/Config.in line 10

Quoted 4 lines
package/firewalld/Config.in new file +4 -0
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # gobject-introspection
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus-python
+	depends on BR2_TOOLCHAIN_USES_GLIBC # gobject-introspection
+	depends on BR2_PACKAGE_DBUS # dbus-python

You should select dbus (and thus inherit its dependencies).

Quoted 22 lines
package/firewalld/Config.in new file +22 -0
+	depends on BR2_PACKAGE_PYTHON3 # gobject-introspection
+	select BR2_PACKAGE_DBUS_PYTHON
+	select BR2_PACKAGE_EBTABLES
+	select BR2_PACKAGE_GETTEXT
+	select BR2_PACKAGE_GOBJECT_INTROSPECTION
+	select BR2_PACKAGE_IPSET
+	select BR2_PACKAGE_IPTABLES
+	select BR2_PACKAGE_JANSSON # Runtime
+	select BR2_PACKAGE_NFTABLES
+	select BR2_PACKAGE_PYTHON_DECORATOR
+	select BR2_PACKAGE_PYTHON_GOBJECT
+	select BR2_PACKAGE_PYTHON_SIX
+	select BR2_PACKAGE_PYTHON_SLIP_DBUS
+	help
+	  Firewalld provides a dynamically managed firewall with
+	  support for network or firewall zones to define the trust
+	  level of network connections or interfaces. It has support
+	  for IPv4, IPv6 firewall settings and for ethernet bridges and
+	  a separation of runtime and permanent configuration options.
+	  It also provides an interface for services or applications to
+	  add ip*tables and ebtables rules directly.
+

package/firewalld/Config.in line 42

Quoted 10 lines
package/firewalld/Config.in new file +10 -0
+	  https://github.com/firewalld/firewalld
+
+comment "firewalld needs python3"
+	depends on !BR2_PACKAGE_PYTHON3
+
+comment "firewalld needs a glibc toolchain w/ wchar, threads, gcc >= 4.9"
+	depends on BR2_USE_MMU || !BR2_USE_WCHAR
+	depends on BR2_PACKAGE_DBUS && BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_USES_GLIBC || \
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

As for for python-slip-dbus, I don;t much like that we have two comments. Can you see at making it a single one, please?

package/firewalld/firewalld.hash line 3

Quoted 9 lines
package/firewalld/firewalld.hash new file +3 -0
new file mode 100644
index 0000000000..ed4ac54a67
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 cfdf40890bca18892d1695bd902ede695cb2a61e1fcf809a2f8c394ca788a31e firewalld-v0.8.1.tar.gz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING

Two spaces between fields in hash file, please.

Quoted 44 lines
package/firewalld/firewalld.init new file +38 -0
new file mode 100644
index 0000000000..72c9f7a31a
@@ -0,0 +1,52 @@
+#!/bin/sh
+
+firewalld=/usr/sbin/firewalld
+pidfile=/var/run/firewalld.pid
+
+start() {
+  printf "Starting firewalld: "
+  start-stop-daemon -S -q --exec $firewalld
+  [ $? = 0 ] && echo "OK" || echo "FAIL"
+}
+stop() {
+  printf "Stopping firewalld: "
+  start-stop-daemon --stop --quiet --pidfile $pidfile
+  [ $? = 0 ] && echo "OK" || echo "FAIL"
+}
+
+reload(){
+  printf "Reloading firewalld: "
+  firewall-cmd --reload
+  [ $? = 0 ] && echo "OK" || echo "FAIL"
+}
+
+restart() {
+  stop
+  start
+}
+
+status(){
+  firewall-cmd --state
+}
+
+
+case "$1" in
+    start)
+      start
+      ;;
+    stop)
+      stop

package/firewalld/firewalld.init line 48

Quoted 10 lines
package/firewalld/firewalld.init new file +10 -0
+      ;;
+    restart)
+      restart
+      ;;
+    reload)
+      reload
+      ;;
+    status)
+      status
+      ;;
    case "${1}" in
        start|stop|....)
            ${1}
            ;;
        *)
            echo "usage..."
            ;;
    esac
Quoted 35 lines
package/firewalld/firewalld.init new file +4 -0
+    *)
+      echo "Usage: $0 {start|stop|restart|reload|status}"
+      exit 1
+esac
package/firewalld/firewalld.mk new file +25 -0
new file mode 100644
index 0000000000..e028a01c84
@@ -0,0 +1,79 @@
+################################################################################
+#
+# firewalld
+#
+################################################################################
+
+FIREWALLD_VERSION = v0.8.1
+FIREWALLD_SITE = $(call github,firewalld,firewalld,$(FIREWALLD_VERSION))
+FIREWALLD_LICENSE = GPL-2.0
+FIREWALLD_LICENSE_FILES = COPYING
+FIREWALLD_AUTORECONF = YES
+FIREWALLD_DEPENDENCIES = \
+	host-intltool \
+	host-libglib2 \
+	host-libxml2 \
+	host-libxslt \
+	dbus-python \
+	dbus-python \
+	ebtables \
+	gettext \
+	gobject-introspection \
+	ipset \
+	iptables \
+	jansson \
+	nftables \

package/firewalld/firewalld.mk line 35

Quoted 10 lines
package/firewalld/firewalld.mk new file +10 -0
+	python3 \
+	python-decorator \
+	python-gobject \
+	python-six \
+	python-slip-dbus
+
+define FIREWALLD_RUN_AUTOGEN
+	cd $(@D) && $(HOST_DIR)/bin/intltoolize --force
+endef
+FIREWALLD_PRE_CONFIGURE_HOOKS += FIREWALLD_RUN_AUTOGEN

This warrants a bit of explanations in the commit log.

package/firewalld/firewalld.mk line 43

Quoted 7 lines
package/firewalld/firewalld.mk new file +7 -0
+# iptables, ip6tables, ebtables, and ipset *should* be unnecessary
+# when the nftables backend is available, because nftables supersedes all of
+# them. However we still need to build and install iptables and ip6tables
+# because application relying on direct passthrough rules (IE docker) will
+# break.
+# /etc/sysconfig/firewalld is a Red Hat-ism, only referenced by
+# the Red Hat-specific init script which isn't used.

Why do you need this blurb about /etc/sysconfig/firewalld? We don't have anything about it below, so referring to it is confusing... Unless you are referring to the option --disable-sysconfig?

Quoted 4 lines
package/firewalld/firewalld.mk new file +4 -0
+FIREWALLD_CONF_OPTS += \
+	--disable-rpmmacros \
+	--disable-sysconfig \
+	--with-ip6tables-restore=/usr/sbin/ip6tables-restore \

package/firewalld/firewalld.mk line 57

Quoted 10 lines
package/firewalld/firewalld.mk new file +10 -0
+	--with-ip6tables=/usr/sbin/ip6tables \
+	--with-iptables-restore=/usr/sbin/iptables-restore \
+	--with-iptables=/usr/sbin/iptables \
+	--with-nft=/usr/sbin/nft \
+	--without-ebtables \
+	--without-ebtables-restore \
+	--without-ipset \
+	--without-xml-catalog
+
+

Only one empty line.

Thanks!

Regards,
Yann E. MORIN.

Quoted 29 lines
package/firewalld/firewalld.mk new file +22 -0
+# Firewalld hard codes the python shebangs to the full path of the
+# python-interpreter. IE: #!/home/buildroot/output/host/bin/python.
+# Force the proper python path.
+FIREWALLD_CONF_ENV += PYTHON="/usr/bin/env python$(PYTHON3_VERSION_MAJOR)"
+
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+FIREWALLD_CONF_OPTS += --with-systemd-unitdir=/usr/lib/systemd/system
+else
+FIREWALLD_CONF_OPTS += --disable-systemd
+endif
+
+define FIREWALLD_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 0644 $(FIREWALLD_PKGDIR)/firewalld.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/firewalld.service
+endef
+
+define FIREWALLD_INSTALL_INIT_SYSV
+	$(INSTALL) -m 0755 -D $(FIREWALLD_PKGDIR)/firewalld.init \
+		$(TARGET_DIR)/etc/init.d/S41firewalld
+endef
+
+$(eval $(autotools-package))
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 5/5 linux: add automatic firewalld config selection

In reply to aduskett at gmail.com

From: Adam Duskett <[email protected]>

Firewalld requires almost every single nftables rule enabled in the kernel to properly start. As such, if a user selects the firewalld package, it is much easier to select these options for them, must like we do for systemd or iptables.

---
 linux/linux.mk | 175 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 175 insertions(+)
linux/linux.mk +176 -0
index b2ceeecafb..1927832e7e 100644
@@ -358,6 +358,182 @@ define LINUX_KCONFIG_FIXUP_CMDS
 	$(if $(BR2_PACKAGE_AUDIT),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_NET,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_AUDIT,$(@D)/.config))
+	$(if $(BR2_PACKAGE_FIREWALLD),
+		$(call KCONFIG_ENABLE_OPT,CONFIG_BRIDGE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_LOG_COMMON,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_LOG_NETDEV,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_CONNCOUNT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_MARK,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_ZONES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_PROCFS,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_EVENTS,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_TIMEOUT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_TIMESTAMP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_LABELS,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CT_PROTO_DCCP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CT_PROTO_GRE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CT_PROTO_SCTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CT_PROTO_UDPLITE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_AMANDA,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_FTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_H323,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_IRC,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_BROADCAST,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_NETBIOS_NS,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_SNMP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_PPTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_SANE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_SIP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CONNTRACK_TFTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CT_NETLINK,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CT_NETLINK_TIMEOUT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_CT_NETLINK_HELPER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_NETLINK_GLUE_CT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_NEEDED,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_PROTO_DCCP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_PROTO_UDPLITE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_PROTO_SCTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_AMANDA,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_FTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_IRC,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_SIP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_TFTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_REDIRECT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_SYNPROXY,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_SET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_NETDEV,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_NUMGEN,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_CT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_FLOW_OFFLOAD,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_COUNTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_CONNLIMIT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_LOG,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_LIMIT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_MASQ,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_REDIR,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_NAT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_TUNNEL,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_OBJREF,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_QUEUE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_QUOTA,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_REJECT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_REJECT_INET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_COMPAT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_HASH,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_FIB,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_FIB_INET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_SOCKET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_OSF,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_TPROXY,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_DUP_NETDEV,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_DUP_NETDEV,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_FWD_NETDEV,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_FIB_NETDEV,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_FLOW_TABLE_INET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_FLOW_TABLE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NETFILTER_XTABLES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_BITMAP_IP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_BITMAP_IPMAC,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_BITMAP_PORT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_IP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_IPMARK,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_IPPORT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_IPPORTIP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_IPPORTNET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_IPMAC,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_MAC,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_NETPORTNET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_NET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_NETNET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_NETPORT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_HASH_NETIFACE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_SET_LIST_SET,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_DEFRAG_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_SOCKET_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TPROXY_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_CHAIN_ROUTE_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_REJECT_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_DUP_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_FIB_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_ARP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_FLOW_TABLE_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_DUP_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_LOG_ARP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_LOG_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_REJECT_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_MASQUERADE_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_CHAIN_NAT_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_MASQ_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_REDIR_IPV4,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_SNMP_BASIC,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_PROTO_GRE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_PPTP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_H323,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_IPTABLES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_MATCH_AH,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_MATCH_ECN,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_MATCH_RPFILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_MATCH_TTL,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_FILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_REJECT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_SYNPROXY,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_NAT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_MASQUERADE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_NETMAP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_REDIRECT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_MANGLE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_CLUSTERIP,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_ECN,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_TTL,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_RAW,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_ARPTABLES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_ARPFILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_ARP_MANGLE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_SOCKET_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TPROXY_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_CHAIN_ROUTE_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_CHAIN_NAT_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_MASQ_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_REDIR_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_REJECT_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_DUP_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_FIB_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_FLOW_TABLE_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_DUP_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_REJECT_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_LOG_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_NAT_MASQUERADE_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_IPTABLES,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_AH,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_EUI64,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_FRAG,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_OPTS,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_HL,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_IPV6HEADER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_MH,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_RPFILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_RT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MATCH_SRH,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_TARGET_HL,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_FILTER,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_TARGET_REJECT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_TARGET_SYNPROXY,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_MANGLE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_RAW,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_NAT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_TARGET_MASQUERADE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_IP6_NF_TARGET_NPT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_DEFRAG_IPV6,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_TABLES_BRIDGE,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NFT_BRIDGE_REJECT,$(@D)/.config)
+		$(call KCONFIG_ENABLE_OPT,CONFIG_NF_LOG_BRIDGE,$(@D)/.config))
 	$(if $(BR2_PACKAGE_INTEL_MICROCODE),
 		$(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE,$(@D)/.config)
 		$(call KCONFIG_ENABLE_OPT,CONFIG_MICROCODE_INTEL,$(@D)/.config))
Signature · 1 line
2.25.1
#8 lore raw

PATCH 5/5 linux: add automatic firewalld config selection

Adam, All,

On 2020-03-30 16:46 -0700, aduskett at gmail.com spake thusly:

Quoted 6 lines

From: Adam Duskett <[email protected]>

Firewalld requires almost every single nftables rule enabled in the kernel to properly start. As such, if a user selects the firewalld package, it is much easier to select these options for them, must like we do for systemd or iptables.

As for the nftables patch earlier in that series, I've marked this patch as changes requested.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#9 lore raw

PATCH 1/5 package/nftables: check for python

In reply to aduskett at gmail.com

Adam, All,

On 2020-03-30 16:46 -0700, aduskett at gmail.com spake thusly:

Quoted 6 lines

From: Adam Duskett <[email protected]>

If python or python3 is selected, nftables should depend on the package and set the --enable-python option, otherwise set --disable-python

This one patch applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 29 lines
---
 package/nftables/nftables.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/nftables/nftables.mk +7 -0
index 11ef6844ce..210e950c11 100644
@@ -27,6 +27,13 @@ else
 NFTABLES_CONF_OPTS += --without-json
 endif
 
+ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
+NFTABLES_CONF_OPTS += --enable-python
+NFTABLES_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,python3)
+else
+NFTABLES_CONF_OPTS += --disable-python
+endif
+
 ifeq ($(BR2_STATIC_LIBS)$(BR2_PACKAGE_LIBNFTNL_JSON),yy)
 NFTABLES_LIBS += -ljansson -lm
 endif
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#10 lore raw

PATCH 1/5 package/nftables: check for python

In reply to aduskett at gmail.com
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"aduskett" == aduskett <[email protected]> writes:

From: Adam Duskett <[email protected]>
If python or python3 is selected, nftables should depend on the package and set the --enable-python option, otherwise set --disable-python

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard