staging: android: ion: Fix parenthesis alignment
PATCH 1/1 staging: android: ion: Fix parenthesis alignment
Fix 2 parenthesis alignment issues.
Reported by checkpatch.
--- drivers/staging/android/ion/ion_page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/android/ion/ion_page_pool.c +2 -2
@@ -37,7 +37,7 @@ static void ion_page_pool_add(struct ion_page_pool *pool, struct page *page) }mod_node_page_state (page_pgdat (page),NR_KERNEL_MISC_RECLAIMABLE , -1 << pool->order); +1 << pool->order);mutex_unlock (&pool->mutex); }
@@ -57,7 +57,7 @@ static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high)list_del (&page->lru);mod_node_page_state (page_pgdat (page),NR_KERNEL_MISC_RECLAIMABLE , - -(1 << pool->order)); + -(1 << pool->order));return page; }
Signature · 1 line
2.25.1
Quoted 5 lines · On Wed, 1 Apr 2020 18:25:15 -0700 "John B. Wyatt IV" <[email protected]>…
Fix 2 parenthesis alignment issues.
Reported by checkpatch.
Signed-off-by John B. Wyatt IV <[email protected]>
Signature · 1 line
Stefano
Quoted 1 line · John B. Wyatt IV
Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't involve the word "Fix". What have you done and why?
julia
Quoted 38 lines
Reported by checkpatch.
Signed-off-by John B. Wyatt IV <[email protected]>--- drivers/staging/android/ion/ion_page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/android/ion/ion_page_pool.c +2
-3@@ -37,7 +37,7 @@ static void ion_page_pool_add(struct ion_page_pool *pool, struct page *page) }mod_node_page_state (page_pgdat (page),NR_KERNEL_MISC_RECLAIMABLE , -1 << pool->order); +1 << pool->order);mutex_unlock (&pool->mutex); }@@ -57,7 +57,7 @@ static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high)list_del (&page->lru);mod_node_page_state (page_pgdat (page),NR_KERNEL_MISC_RECLAIMABLE , - -(1 << pool->order)); + -(1 << pool->order));return page; } --2.25.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200402012515.429329-1-jbwyatt4%40gmail.com.
Quoted 8 lines · Julia Lawall
Quoted 1 line · John B. Wyatt IV
Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't involve the word "Fix". What have you done and why?
Understood.
How about:
Move spacing on function arguments to to comply with kernel style guide on parenthesis alignment.
Quoted 10 lines · John Wyatt
Quoted 8 lines · Julia Lawall
Quoted 1 line · John B. Wyatt IV
Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't involve the word "Fix". What have you done and why?
Quoted 6 lines
Understood.
How about:
Move spacing on function arguments to to comply with kernel style guide on parenthesis alignment.
It's better (but drop the second "to" :).
Obviously in this case it's not a big deal, but it's better to get out of the habit of just saying "fix".
julia
Quoted 15 lines · Julia Lawall
Quoted 12 lines · John Wyatt
Quoted 8 lines · Julia Lawall
Quoted 1 line · John B. Wyatt IV
Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't
involve the word "Fix". What have you done and why?Understood.
Quoted 7 lines
Quoted 5 lines
How about:
Move spacing on function arguments to to comply with kernel style guide
on parenthesis alignment.It's better (but drop the second "to" :).
And I am going to bed. :)
Quoted 4 lines
Obviously in this case it's not a big deal, but it's better to get out of
the habit of just saying "fix".
Understood, what about the title? Keep 'Fix'. or use 'Move'. or use 'Rearrange'?
Quoted 27 lines · John Wyatt
Quoted 15 lines · Julia Lawall
Quoted 12 lines · John Wyatt
Quoted 8 lines · Julia Lawall
Quoted 1 line · John B. Wyatt IV
Fix 2 parenthesis alignment issues.
Please try to find a way to describe what you have done that doesn't
involve the word "Fix". What have you done and why?Understood.
Quoted 7 lines
Quoted 5 lines
How about:
Move spacing on function arguments to to comply with kernel style guide
on parenthesis alignment.It's better (but drop the second "to" :).
And I am going to bed. :)
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Obviously in this case it's not a big deal, but it's better to get out of
the habit of just saying "fix".Understood, what about the title? Keep 'Fix'. or use 'Move'. or use 'Rearrange'?
The current subject line is not understandable. You aren't actually doing anything with the parentheses. I would suggest to start the subject line with "Align".
julia
Quoted 6 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/c8bd09741e0ec90507a034635d5e9e450e9a53b4.camel%40gmail.com.