Skip to contentSkip to conversation

net: dsa: dsa_bridge_mtu_normalization() can be static

PATCH In review Vladimir Oltean 2 participants 3 messages Apr 2, 2020

Subsystems (3)
lore
Share & tools
lore

Vladimir Oltean

author maintainer
#0 lore raw

PATCH 1/1 net: dsa: dsa_bridge_mtu_normalization() can be static

From: kbuild test robot <[email protected]>

This function is not called from any other C file.

Fixes bff33f7e2ae2 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")
---
 net/dsa/slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/dsa/slave.c +1 -1
index 5390ff541658..e94eb1aac602 100644
@@ -1338,7 +1338,7 @@ static void dsa_hw_port_list_free(struct list_head *hw_port_list)
 }
 
 /* Make the hardware datapath to/from @dev limited to a common MTU */
-void dsa_bridge_mtu_normalization(struct dsa_port *dp)
+static void dsa_bridge_mtu_normalization(struct dsa_port *dp)
 {
 	struct list_head hw_port_list;
 	struct dsa_switch_tree *dst;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Vladimir Oltean

From: kbuild test robot <[email protected]>

This function is not called from any other C file.

Fixes bff33f7e2ae2 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")

Did you mean Reported-by? I don't think kbuild test robot signed that.

Quoted 1 line

Jason sent a patch already.

Thanks,
Vivien

author maintainer
#2 lore raw
Quoted 11 lines · Vivien Didelot
Quoted 6 lines · Vladimir Oltean

From: kbuild test robot <[email protected]>

This function is not called from any other C file.

Fixes bff33f7e2ae2 ("net: dsa: implement auto-normalization of MTU for bridge hardware datapath")

Did you mean Reported-by? I don't think kbuild test robot signed that.

Yes it did?
https://patchwork.ozlabs.org/patch/1265415/
But the sha1sum of the commit is wrong.

Quoted 3 lines
Quoted 1 line

Jason sent a patch already.

Yes, I saw too late.
But it looks like even Jason was too late, David already picked up the kbuild robot's RFC. I wasn't sure he was going to do that since it was an RFC.

Quoted 3 lines

Thanks,
Vivien

-Vladimir