nand: brcmnand: return without disabling clock
PATCH 1/1 nand: brcmnand: return without disabling clock
Linux Broadcom NAND driver only disabled clock if no childs are initialized. This section of the code seems to have been accidentally dropped when it was imported in U-Boot.
--- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/mtd/nand/raw/brcmnand/brcmnand.c +8 -1
@@ -2714,6 +2714,14 @@ int brcmnand_probe(struct udevice *dev, struct brcmnand_soc *soc) }#endif /* __UBOOT__ */ +/* No chip-selects could initialize properly */ +if (list_empty (&ctrl->host_list)) { + ret = -ENODEV ; + goto err; + } + +return 0 ; + err:#ifndef __UBOOT__clk_disable_unprepare (ctrl->clk);
@@ -2722,7 +2730,6 @@ err:clk_disable (ctrl->clk);#endif /* __UBOOT__ */ return ret; - }EXPORT_SYMBOL_GPL (brcmnand_probe);
Signature · 1 line
2.20.1
PATCH 1/1 nand: brcmnand: return without disabling clock
Am 02.04.20 um 10:37 schrieb ?lvaro Fern?ndez Rojas:
Quoted 9 lines
Linux Broadcom NAND driver only disabled clock if no childs are initialized. This section of the code seems to have been accidentally dropped when it was imported in U-Boot.
Signed-off-by ?lvaro Fern?ndez Rojas <[email protected]>--- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
Signature · 1 line
- Daniel
PATCH 1/1 nand: brcmnand: return without disabling clock
Quoted 7 lines · Daniel Schwierzeck
Am 02.04.20 um 10:37 schrieb ?lvaro Fern?ndez Rojas:
Quoted 4 lines
Linux Broadcom NAND driver only disabled clock if no childs are initialized. This section of the code seems to have been accidentally dropped when it was imported in U-Boot.
Quoted 7 lines
Quoted 5 lines
Signed-off-by ?lvaro Fern?ndez Rojas <[email protected]>--- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)Reviewed-by Daniel Schwierzeck <[email protected]>
Does this need to go in to v2020.04? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200402/84496567/attachment.sig>
PATCH 1/1 nand: brcmnand: return without disabling clock
Quoted 18 lines
El 2 abr 2020, a las 17:49, Tom Rini <[email protected]> escribi?:
Quoted 13 lines · Daniel Schwierzeck
Am 02.04.20 um 10:37 schrieb ?lvaro Fern?ndez Rojas:
Quoted 9 lines
Linux Broadcom NAND driver only disabled clock if no childs are initialized. This section of the code seems to have been accidentally dropped when it was imported in U-Boot.
Signed-off-by ?lvaro Fern?ndez Rojas <[email protected]>---
drivers/mtd/nand/raw/brcmnand/brcmnand.c| 9 ++++++++-1 file changed, 8 insertions(+), 1 deletion(-)
Quoted 6 lines
Quoted 1 line
Reviewed-by Daniel Schwierzeck <[email protected]>Does this need to go in to v2020.04? Thanks!
Signature · 1 line
Tom
Not really. I tested it with a development branch and this affects bcm6362 devices (nand not currently supported), but it doesn?t affect bcm63268 devices (1 device supported).
Best regards,
?lvaro.
PATCH 1/1 nand: brcmnand: return without disabling clock
In reply to Álvaro Fernández RojasAm 02.04.20 um 10:37 schrieb ?lvaro Fern?ndez Rojas:
Quoted 9 lines
Linux Broadcom NAND driver only disabled clock if no childs are initialized. This section of the code seems to have been accidentally dropped when it was imported in U-Boot.
Signed-off-by ?lvaro Fern?ndez Rojas <[email protected]>--- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
applied to u-boot-mips, thanks.
Signature · 1 line
- Daniel