Skip to contentSkip to conversation

Documentation/llvm: fix the name of llvm-size

PATCH In review Fangrui Song 3 participants 3 messages Apr 2, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation/llvm: fix the name of llvm-size

The tool is called llvm-size, not llvm-objsize.

Fixes fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
---
 Documentation/kbuild/llvm.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kbuild/llvm.rst +1 -1
index d6c79eb4e23e..eefbdfa3e4d9 100644
@@ -51,7 +51,7 @@ LLVM has substitutes for GNU binutils utilities. These can be invoked as
 additional parameters to `make`.
 
 	make CC=clang AS=clang LD=ld.lld AR=llvm-ar NM=llvm-nm STRIP=llvm-strip \\
-	  OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-objsize \\
+	  OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-size \\
 	  READELF=llvm-readelf HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar \\
 	  HOSTLD=ld.lld
 
Signature · 1 line
2.26.0.rc2.310.g2932bb562d-goog
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Fangrui Song' via Clang Built Linux

The tool is called llvm-size, not llvm-objsize.

Fixes fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
---
 Documentation/kbuild/llvm.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kbuild/llvm.rst +0 -0
index d6c79eb4e23e..eefbdfa3e4d9 100644

Documentation/kbuild/llvm.rst LLVM has substitutes for GNU binutils utilities. These can be invoked as

Quoted 9 lines
Documentation/kbuild/llvm.rst +1 -2
@@ -51,7 +51,7 @@ LLVM has substitutes for GNU binutils utilities. These can be invoked as
 additional parameters to `make`.
 
        make CC=clang AS=clang LD=ld.lld AR=llvm-ar NM=llvm-nm STRIP=llvm-strip \\
-         OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-objsize \\
+         OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-size \\
          READELF=llvm-readelf HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar \\
          HOSTLD=ld.lld
 
--

OBJCOPY -> llvm-objcopy
OBJDUMP -> llvm-objdump
OBJSIZE -> llvm-size

Oops, thanks for the patch.

Signature · 2 lines
Thanks,
~Nick Desaulniers
Reviewed-by on v1 1/1
#2 lore raw
In reply to Fangrui Song
Quoted 4 lines · Fangrui Song' via Clang Built Linux

The tool is called llvm-size, not llvm-objsize.

Fixes fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
Quoted 20 lines
---
 Documentation/kbuild/llvm.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/kbuild/llvm.rst +1 -1
index d6c79eb4e23e..eefbdfa3e4d9 100644
@@ -51,7 +51,7 @@ LLVM has substitutes for GNU binutils utilities. These can be invoked as
 additional parameters to `make`.
 
 	make CC=clang AS=clang LD=ld.lld AR=llvm-ar NM=llvm-nm STRIP=llvm-strip \\
-	  OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-objsize \\
+	  OBJCOPY=llvm-objcopy OBJDUMP=llvm-objdump OBJSIZE=llvm-size \\
 	  READELF=llvm-readelf HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar \\
 	  HOSTLD=ld.lld
 
Signature · 1 line
2.26.0.rc2.310.g2932bb562d-goog