tools/power/x86/intel-speed-select: Fix CLX-N package information output
Subsystems (2)
PATCH 1/1 tools/power/x86/intel-speed-select: Fix CLX-N package information output
On CLX-N the perf-profile output is missing the package, die, and cpu output. On CLX-N the pkg_dev struct will never be evaluated by the core code so pkg_dev.processed is always 0 and the package, die, and cpu information is never output.
Set the pkg_dev.processed flag to 1 for CLX-N processors.
--- tools/power/x86/intel-speed-select/isst-config.c | 1 + 1 file changed, 1 insertion(+)
tools/power/x86/intel-speed-select/isst-config.c +1 -0
@@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int cpu, void *arg1, void *arg2, ctdp_level = &clx_n_pkg_dev.ctdp_level[0 ]; pbf_info = &ctdp_level->pbf_info; + clx_n_pkg_dev.processed =1 ;isst_ctdp_display_information (cpu, outf, tdp_level, &clx_n_pkg_dev);free_cpu_set (ctdp_level->core_cpumask);free_cpu_set (pbf_info->core_cpumask);
Signature · 1 line
2.18.2
Quoted 6 lines · Prarit Bhargava
On CLX-N the perf-profile output is missing the package, die, and cpu output. On CLX-N the
pkg_devstruct will never be evaluated by the core code so pkg_dev.processed is always 0 and the package, die, and cpu information is never output.Set the pkg_dev.processed flag to 1 for CLX-N processors.
I will accept this with PR from Srinivas whenever he sends one to public mailing list.
Quoted 23 lines
Signed-off-by Prarit Bhargava <[email protected]>Cc Srinivas Pandruvada <[email protected]>--- tools/power/x86/intel-speed-select/isst-config.c | 1 + 1 file changed, 1 insertion(+)tools/power/x86/intel-speed-select/isst-config.c +1
-0@@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int cpu, void *arg1, void *arg2, ctdp_level = &clx_n_pkg_dev.ctdp_level[0 ]; pbf_info = &ctdp_level->pbf_info; + clx_n_pkg_dev.processed =1 ;isst_ctdp_display_information (cpu, outf, tdp_level, &clx_n_pkg_dev);free_cpu_set (ctdp_level->core_cpumask);free_cpu_set (pbf_info->core_cpumask);Signature · 1 line
2.18.2
Signature · 2 lines
With Best Regards, Andy Shevchenko
Srinivas Pandruvada
maintainerQuoted 10 lines · Andy Shevchenko
Quoted 8 lines · Prarit Bhargava
On CLX-N the perf-profile output is missing the package, die, and cpu
output. On CLX-N thepkg_devstruct will never be evaluated by the core
code so pkg_dev.processed is always 0 and the package, die, and cpu information is never output.Set the pkg_dev.processed flag to 1 for CLX-N processors.
Sorry Prarit. It took long to respond. The patch is fine. I am applying to my tree.
-Srinivas
Quoted 29 lines
I will accept this with PR from Srinivas whenever he sends one to public mailing list.
Quoted 26 lines
Signed-off-by Prarit Bhargava <[email protected]>Cc Srinivas Pandruvada <[email protected]>--- tools/power/x86/intel-speed-select/isst-config.c | 1 + 1 file changed, 1 insertion(+)tools/power/x86/intel-speed-select/isst-config.c +1
-0@@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int cpu, void *arg1, void *arg2, ctdp_level = &clx_n_pkg_dev.ctdp_level[0 ]; pbf_info = &ctdp_level->pbf_info; + clx_n_pkg_dev.processed =1 ;isst_ctdp_display_information (cpu, outf, tdp_level, &clx_n_pkg_dev);tools/power/x86/intel-speed-select/isst-config.c +0
-0free_cpu_set (ctdp_level->core_cpumask);free_cpu_set (pbf_info->core_cpumask);Signature · 1 line
2.18.2