Skip to contentSkip to conversation

Cleanups in "next" tree

DISCUSSION Pavel Machek 3 participants 9 messages Mar 22, 2020 – Apr 7, 2020 LED

lore
Share & tools
lore
#0 lore raw

Hi!

I've commited some cleanups into LED tree ( git/pavel/linux-leds.git branch for-next ), if someone wants to review them.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

Hi Pavel,

Quoted 4 lines · Pavel Machek

Hi!

I've commited some cleanups into LED tree ( git/pavel/linux-leds.git branch for-next ), if someone wants to review them.

You abused your maintainer power by bypassing the usual patch submission procedure. Please remove the patches from linux-next and submit them officially for discussion. I would have some objections to them.

Signature · 2 lines
Best regards,
Jacek Anaszewski
#2 lore raw

Pavel

Quoted 12 lines · Jacek Anaszewski

Hi Pavel,

Quoted 4 lines · Pavel Machek

Hi!

I've commited some cleanups into LED tree ( git/pavel/linux-leds.git branch for-next ), if someone wants to review them.

You abused your maintainer power by bypassing the usual patch submission procedure. Please remove the patches from linux-next and submit them officially for discussion. I would have some objections to them.

I had a comment on one of the patches and wanted to add my RB.

So can you please post them?

Dan

#3 lore raw
In reply to Jacek Anaszewski
Quoted 5 lines · Jacek Anaszewski

Hi Pavel,

Quoted 2 lines · Pavel Machek

Hi!

Quoted 7 lines
Quoted 2 lines

I've commited some cleanups into LED tree ( git/pavel/linux-leds.git branch for-next ), if someone wants to review them.

You abused your maintainer power by bypassing the usual patch submission procedure. Please remove the patches from linux-next and submit them officially for discussion. I would have some objections to them.

I'm sorry I failed to meet your high expectations... But I don't believe I done anything completely outside of usual kernel procedures.

Could you list the patches and objections you have?

Thanks and best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#4 lore raw

Pavel

Quoted 6 lines · Pavel Machek
Quoted 5 lines · Jacek Anaszewski

Hi Pavel,

Quoted 2 lines · Pavel Machek

Hi!

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I've commited some cleanups into LED tree ( git/pavel/linux-leds.git branch for-next ), if someone wants to review them.

You abused your maintainer power by bypassing the usual patch submission procedure. Please remove the patches from linux-next and submit them officially for discussion. I would have some objections to them.

I'm sorry I failed to meet your high expectations... But I don't believe I done anything completely outside of usual kernel procedures.

So I can push a public tree out and request reviewers to review that tree and expect it to get merged once the review is complete without ever posting the patches to linux-leds?

This would be the precedent you are setting here as maintainer.

And Jacek does not have high expectations he is just requesting that we follow the process as defined in the Linux kernel document

Dan

#5 lore raw
In reply to Pavel Machek
Quoted 9 lines · Pavel Machek
Quoted 8 lines · Jacek Anaszewski

Hi Pavel,

Quoted 4 lines · Pavel Machek

Hi!

I've commited some cleanups into LED tree ( git/pavel/linux-leds.git branch for-next ), if someone wants to review them.

Quoted 7 lines
Quoted 4 lines

You abused your maintainer power by bypassing the usual patch submission procedure. Please remove the patches from linux-next and submit them officially for discussion. I would have some objections to them.

I'm sorry I failed to meet your high expectations... But I don't believe I done anything completely outside of usual kernel procedures.

I believe code review is quite usual kernel procedure.

Quoted 1 line

Could you list the patches and objections you have?

I already expressed my concerns regarding Turris Omnia patch.

My comments regarding remaining patches:

- "Make label "white:power" to be consistent with"

I disagree here. "system" was OK.

- "Warn about old defines that probably should not be used."

Obsolete is only LED_FULL, so the comment is in wrong line

- "Group LED functions according to functionality, and add some"

You're adding here some random comments referencing obsolete naming. I think that it is enough to say what is current standard.

Also, I had a patch [0] describing standard LED functions in my LED naming patch set, but it was not merged. It could be worth getting back to it at this occasion.

[0]
https://lore.kernel.org/linux-leds/[email protected]/

Signature · 2 lines
Best regards,
Jacek Anaszewski
#6 lore raw

Pavel

Quoted 22 lines · Jacek Anaszewski
Quoted 6 lines · Pavel Machek
Quoted 5 lines · Jacek Anaszewski

Hi Pavel,

Quoted 2 lines · Pavel Machek

Hi!

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I've commited some cleanups into LED tree ( git/pavel/linux-leds.git branch for-next ), if someone wants to review them.

You abused your maintainer power by bypassing the usual patch submission procedure. Please remove the patches from linux-next and submit them officially for discussion. I would have some objections to them.

I'm sorry I failed to meet your high expectations... But I don't believe I done anything completely outside of usual kernel procedures.

I believe code review is quite usual kernel procedure.

Quoted 1 line

Could you list the patches and objections you have?

I already expressed my concerns regarding Turris Omnia patch.

My comments regarding remaining patches:

Quoted 7 lines

- "Make label "white:power" to be consistent with"

I disagree here. "system" was OK.

- "Warn about old defines that probably should not be used."

Obsolete is only LED_FULL, so the comment is in wrong line

I would prefer to have the commit sha that obsoleted the LED_FULL to be referenced in the commit message so we have traceability.

Dan

#7 lore raw
In reply to Jacek Anaszewski

Hi!

Quoted 4 lines
Quoted 2 lines

I'm sorry I failed to meet your high expectations... But I don't believe I done anything completely outside of usual kernel procedures.

I believe code review is quite usual kernel procedure.

I don't disagree with that.

Quoted 3 lines
Quoted 1 line

Could you list the patches and objections you have?

I already expressed my concerns regarding Turris Omnia patch.

Ok.

Quoted 5 lines

My comments regarding remaining patches:

- "Make label "white:power" to be consistent with"

I disagree here. "system" was OK.

It was too vague... I know the hardware and it is a LED above power button used as a power indicator.

Quoted 3 lines

- "Warn about old defines that probably should not be used."

Obsolete is only LED_FULL, so the comment is in wrong line

No, all of them are bad. Maybe LED_OFF could be used going forward, but... it is simply easier to write 0. The type is not really an en enumeration, it is brightness, with variable maximum value.

Quoted 4 lines

- "Group LED functions according to functionality, and add some"

You're adding here some random comments referencing obsolete naming. I think that it is enough to say what is current standard.

Ok, I'll drop that part. But I really want to get that documented _somewhere_, because obsolete naming is currently in use, and we won't be able to change it :-(.

Quoted 3 lines

Also, I had a patch [0] describing standard LED functions in my LED naming patch set, but it was not merged. It could be worth getting back to it at this occasion.

I'll take a look.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#8 lore raw
Quoted 24 lines · Pavel Machek

Hi!

Quoted 4 lines
Quoted 2 lines

I'm sorry I failed to meet your high expectations... But I don't believe I done anything completely outside of usual kernel procedures.

I believe code review is quite usual kernel procedure.

I don't disagree with that.

Quoted 3 lines
Quoted 1 line

Could you list the patches and objections you have?

I already expressed my concerns regarding Turris Omnia patch.

Ok.

Quoted 5 lines

My comments regarding remaining patches:

- "Make label "white:power" to be consistent with"

I disagree here. "system" was OK.

It was too vague... I know the hardware and it is a LED above power button used as a power indicator.

Quoted 7 lines
Quoted 3 lines

- "Warn about old defines that probably should not be used."

Obsolete is only LED_FULL, so the comment is in wrong line

No, all of them are bad. Maybe LED_OFF could be used going forward, but... it is simply easier to write 0. The type is not really an en enumeration, it is brightness, with variable maximum value.

In this case brightness should be turned into an int and the change should be applied throughout the whole kernel. Otherwise it is questionable - why all enums are made obsolete if the type of struct led_classdev's brightness property is still enum led_brightness? Do we have some replacement? - one could ask.

Quoted 9 lines
Quoted 5 lines

- "Group LED functions according to functionality, and add some"

You're adding here some random comments referencing obsolete naming. I think that it is enough to say what is current standard.

Ok, I'll drop that part. But I really want to get that documented _somewhere_, because obsolete naming is currently in use, and we won't be able to change it :-(.

You've pushed it out anyway...

Quoted 9 lines
Quoted 3 lines

Also, I had a patch [0] describing standard LED functions in my LED naming patch set, but it was not merged. It could be worth getting back to it at this occasion.

I'll take a look.

Best regards,
Pavel

Signature · 2 lines
Best regards,
Jacek Anaszewski