armv8: ls1046ardb: add new 16GB udimm memory support
PATCH 1/1 armv8: ls1046ardb: add new 16GB udimm memory support
From: Yuantian Tang <[email protected]>
Add this udimm memory support on ls1046ardb board.
--- board/freescale/ls1046ardb/ddr.h | 1 + 1 file changed, 1 insertion(+)
board/freescale/ls1046ardb/ddr.h +1 -0
@@ -32,6 +32,7 @@ static const struct board_specific_parameters udimm0[] = { {2, 1350, 0, 8, 6, 0x0708090B, 0x0C0D0E09,}, {2, 1666, 0, 8, 7, 0x08090A0C, 0x0D0F100B,}, {2, 1900, 0, 8, 7, 0x09090B0D, 0x0E10120B,}, + {2, 2133, 0, 4, 7, 0x08090A0E, 0x1011120C,}, {2, 2300, 0, 8, 9, 0x0A0B0C10, 0x1213140E,}, {} };
Signature · 1 line
2.17.1
PATCH 1/1 armv8: ls1046ardb: add new 16GB udimm memory support
Quoted 10 lines
-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of andy.tang at nxp.com
Sent: Friday, April 3, 2020 12:30 PM
To: Priyanka Jain <[email protected]>
Cc: Mingkai Hu <[email protected]>; Rajesh Bhagat <[email protected]>; u-boot at lists.denx.de; Andy Tang <[email protected]>
Subject: [PATCH] armv8: ls1046ardb: add new 16GB udimm memory support
Quoted 3 lines
From: Yuantian Tang <[email protected]>
Add this udimm memory support on ls1046ardb board.
What is this?
I see in code, you are adding DIMM specific parameter to support new frequency. Is this code changes because you are adding a different DIMM or adding support for new frequency? If new DIMM, What if someone tried to use the frequency "2133" with the original dim on board.
Please provide more details in description.
Thanks
Priyanka
Quoted 22 lines
Signed-off-by Yuantian Tang <[email protected]>---
board/freescale/ls1046ardb/ddr.h| 1 +1 file changed, 1 insertion(+)board/freescale/ls1046ardb/ddr.h +1
-0@@ -32,6 +32,7 @@ static const struct board_specific_parameters udimm0[] = { {2, 1350, 0, 8, 6, 0x0708090B, 0x0C0D0E09,}, {2, 1666, 0, 8, 7, 0x08090A0C, 0x0D0F100B,}, {2, 1900, 0, 8, 7, 0x09090B0D, 0x0E10120B,}, + {2, 2133, 0, 4, 7, 0x08090A0E, 0x1011120C,}, {2, 2300, 0, 8, 9, 0x0A0B0C10, 0x1213140E,}, {}};
--
2.17.1
PATCH 1/1 armv8: ls1046ardb: add new 16GB udimm memory support
+Mazyar,
Hi Mazyar,
Could you please address Priyanka's concern?
BR,
Andy
Quoted 57 lines
-----Original Message-----
From: Priyanka Jain (OSS) <[email protected]>
Sent: 2020?4?15? 18:07
To: Andy Tang <[email protected]>
Cc: Mingkai Hu <[email protected]>; Rajesh Bhagat <[email protected]>; u-boot at lists.denx.de; Andy Tang <[email protected]>
Subject: RE: [PATCH] armv8: ls1046ardb: add new 16GB udimm memory supportQuoted 10 lines
-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of andy.tang at nxp.com
Sent: Friday, April 3, 2020 12:30 PM
To: Priyanka Jain <[email protected]>
Cc: Mingkai Hu <[email protected]>; Rajesh Bhagat <[email protected]>; u-boot at lists.denx.de; Andy Tang <[email protected]>
Subject: [PATCH] armv8: ls1046ardb: add new 16GB udimm memory supportQuoted 3 lines
From: Yuantian Tang <[email protected]>
Add this udimm memory support on ls1046ardb board.
What is this?
I see in code, you are adding DIMM specific parameter to support new frequency.
Is this code changes because you are adding a different DIMM or adding support for new frequency?
If new DIMM, What if someone tried to use the frequency "2133" with the original dim on board.Please provide more details in description.
Thanks
PriyankaQuoted 22 lines
Signed-off-by Yuantian Tang <[email protected]>---
board/freescale/ls1046ardb/ddr.h| 1 +1 file changed, 1 insertion(+)board/freescale/ls1046ardb/ddr.h +1
-0@@ -32,6 +32,7 @@ static const struct board_specific_parameters udimm0[] = { {2, 1350, 0, 8, 6, 0x0708090B, 0x0C0D0E09,}, {2, 1666, 0, 8, 7, 0x08090A0C, 0x0D0F100B,}, {2, 1900, 0, 8, 7, 0x09090B0D, 0x0E10120B,}, + {2, 2133, 0, 4, 7, 0x08090A0E, 0x1011120C,}, {2, 2300, 0, 8, 9, 0x0A0B0C10, 0x1213140E,}, {}};
--
2.17.1