Skip to contentSkip to conversation

staging: ralink-gdma: Remove blank line

PATCH In review John B. Wyatt IV 2 participants 2 messages Apr 3, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: ralink-gdma: Remove blank line

There was an unneeded and inconsistent blank line. Likely added because checkpatch got confused and was reporting a wrong style issue. The blank line was likely added to silence this warning.

Does not fix report. Still reports:
'Missing a blank line after declarations'
'+ struct tasklet_struct task;'
'+ volatile unsigned long chan_issued;'

Reported by checkpatch.

---
v2: Change 'Move' to 'Remove' blank line

Note:
ralink-gdma does not build; even with make allyesconfig. I did not find a menu option with make menuconfig.

 drivers/staging/ralink-gdma/ralink-gdma.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/ralink-gdma/ralink-gdma.c +0 -1
index eabf1093328e..0418af133b13 100644
@@ -124,7 +124,6 @@ struct gdma_dma_dev {
 	struct tasklet_struct task;
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
-
 	struct gdma_dmaengine_chan chan[];
 };
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 30 lines · John B. Wyatt IV

There was an unneeded and inconsistent blank line. Likely added because checkpatch got confused and was reporting a wrong style issue. The blank line was likely added to silence this warning.

Does not fix report. Still reports:
'Missing a blank line after declarations'
'+ struct tasklet_struct task;'
'+ volatile unsigned long chan_issued;'

Reported by checkpatch.

---
v2: Change 'Move' to 'Remove' blank line

Note:
ralink-gdma does not build; even with make allyesconfig. I did not find a menu option with make menuconfig.

 drivers/staging/ralink-gdma/ralink-gdma.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/ralink-gdma/ralink-gdma.c +0 -0
index eabf1093328e..0418af133b13 100644

drivers/staging/ralink-gdma/ralink-gdma.c struct gdma_dma_dev { · line 128

Quoted 6 lines
drivers/staging/ralink-gdma/ralink-gdma.c +0 -1
@@ -124,7 +124,6 @@ struct gdma_dma_dev {
 	struct tasklet_struct task;
 	volatile unsigned long chan_issued;
 	atomic_t cnt;
-
 	struct gdma_dmaengine_chan chan[];
 };

There is nothing wrong with the blank line in this structure that checkpatch, so it can be left alone.

thanks,

greg k-h