Skip to contentSkip to conversation

staging: fsl-dpaa2: ethsw: Fix parenthesis alignment

PATCH In review John B. Wyatt IV 2 participants 2 messages Apr 2, 2020 – Apr 3, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fsl-dpaa2: ethsw: Fix parenthesis alignment

Fix 2 parenthesis alignment issues.

Reported by checkpatch.

---
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/fsl-dpaa2/ethsw/ethsw.c +4 -2
index 676d1ad1b50d..546ad376df99 100644
@@ -1094,7 +1094,8 @@ static int swdev_port_obj_del(struct net_device *netdev,
 
 static int
 ethsw_switchdev_port_attr_set_event(struct net_device *netdev,
-		struct switchdev_notifier_port_attr_info *port_attr_info)
+				    struct switchdev_notifier_port_attr_info
+				    *port_attr_info)
 {
 	int err;
 
@@ -1277,7 +1278,8 @@ static int port_switchdev_event(struct notifier_block *unused,
 
 static int
 ethsw_switchdev_port_obj_event(unsigned long event, struct net_device *netdev,
-			struct switchdev_notifier_port_obj_info *port_obj_info)
+			       struct switchdev_notifier_port_obj_info
+			       *port_obj_info)
 {
 	int err = -EOPNOTSUPP;
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 14 lines · John B. Wyatt IV

Fix 2 parenthesis alignment issues.

Reported by checkpatch.

---
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/fsl-dpaa2/ethsw/ethsw.c +0 -0
index 676d1ad1b50d..546ad376df99 100644

drivers/staging/fsl-dpaa2/ethsw/ethsw.c static int swdev_port_obj_del(struct net_device *netdev, · line 1098

Quoted 6 lines
drivers/staging/fsl-dpaa2/ethsw/ethsw.c +2 -1
@@ -1094,7 +1094,8 @@ static int swdev_port_obj_del(struct net_device *netdev,
 
 static int
 ethsw_switchdev_port_attr_set_event(struct net_device *netdev,
-		struct switchdev_notifier_port_attr_info *port_attr_info)
+				    struct switchdev_notifier_port_attr_info
+				    *port_attr_info)

I feel like the end result is worse than the original code because of how the type and the parameter name are on different lines. Sorry. :/

regards,
dan carpenter