Skip to contentSkip to conversation

drm/amdgpu/psp: dont warn on missing optional TA's

PATCH In review Alex Deucher 2 participants 2 messages Apr 3, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/psp: dont warn on missing optional TA's

Replace dev_warn() with dev_info() and note that they are optional to avoid confusing users.

The RAS TAs only exist on server boards and the HDCP and DTM TAs only exist on client boards. They are optional either way.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +3 -3
index dbaeffc4431e..5d67b1838951 100644
@@ -822,7 +822,7 @@ static int psp_ras_initialize(struct psp_context *psp)
 
 	if (!psp->adev->psp.ta_ras_ucode_size ||
 	    !psp->adev->psp.ta_ras_start_addr) {
-		dev_warn(psp->adev->dev, "RAS: ras ta ucode is not available\n");
+		dev_info(psp->adev->dev, "RAS: optional ras ta ucode is not available\n");
 		return 0;
 	}
 
@@ -906,7 +906,7 @@ static int psp_hdcp_initialize(struct psp_context *psp)
 
 	if (!psp->adev->psp.ta_hdcp_ucode_size ||
 	    !psp->adev->psp.ta_hdcp_start_addr) {
-		dev_warn(psp->adev->dev, "HDCP: hdcp ta ucode is not available\n");
+		dev_info(psp->adev->dev, "HDCP: optional hdcp ta ucode is not available\n");
 		return 0;
 	}
 
@@ -1052,7 +1052,7 @@ static int psp_dtm_initialize(struct psp_context *psp)
 
 	if (!psp->adev->psp.ta_dtm_ucode_size ||
 	    !psp->adev->psp.ta_dtm_start_addr) {
-		dev_warn(psp->adev->dev, "DTM: dtm ta ucode is not available\n");
+		dev_info(psp->adev->dev, "DTM: optional dtm ta ucode is not available\n");
 		return 0;
 	}
 
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Acked-by Nirmoy Das on v1 1/1
#1 lore raw
Quoted 7 lines · Alex Deucher

Replace dev_warn() with dev_info() and note that they are optional to avoid confusing users.

The RAS TAs only exist on server boards and the HDCP and DTM TAs only exist on client boards. They are optional either way.

Quoted 27 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +2 -2
index dbaeffc4431e..5d67b1838951 100644
@@ -822,7 +822,7 @@ static int psp_ras_initialize(struct psp_context *psp)
 
  	if (!psp->adev->psp.ta_ras_ucode_size ||
  	    !psp->adev->psp.ta_ras_start_addr) {
-		dev_warn(psp->adev->dev, "RAS: ras ta ucode is not available\n");
+		dev_info(psp->adev->dev, "RAS: optional ras ta ucode is not available\n");
  		return 0;
  	}
 
@@ -906,7 +906,7 @@ static int psp_hdcp_initialize(struct psp_context *psp)
 
  	if (!psp->adev->psp.ta_hdcp_ucode_size ||
  	    !psp->adev->psp.ta_hdcp_start_addr) {
-		dev_warn(psp->adev->dev, "HDCP: hdcp ta ucode is not available\n");
+		dev_info(psp->adev->dev, "HDCP: optional hdcp ta ucode is not available\n");
  		return 0;
  	}
 

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c static int psp_dtm_initialize(struct psp_context *psp) · line 1058

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +1 -1
@@ -1052,7 +1052,7 @@ static int psp_dtm_initialize(struct psp_context *psp)
 
  	if (!psp->adev->psp.ta_dtm_ucode_size ||
  	    !psp->adev->psp.ta_dtm_start_addr) {
-		dev_warn(psp->adev->dev, "DTM: dtm ta ucode is not available\n");
+		dev_info(psp->adev->dev, "DTM: optional dtm ta ucode is not available\n");
  		return 0;
  	}
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx