SUNRPC: receive buffer size estimation values almost never change
Subsystems (4)
RFC PATCH 1/1 SUNRPC: receive buffer size estimation values almost never change
Avoid unnecessary cache sloshing by placing the buffer size estimation update logic behind an atomic bit flag.
The size of GSS information included in each wrapped Reply does not change during the lifetime of a GSS context. Therefore, the au_rslack and au_ralign fields need to be updated only once after establishing a fresh GSS credential.
Thus a slack size update must occur after a cred is created, duplicated, renewed, or expires. I'm not sure I have this exactly right. A trace point is introduced to track updates to these variables to enable troubleshooting the problem if I missed a spot.
--- include/linux/sunrpc/auth.h | 5 +++- include/trace/events/rpcgss.h | 34 ++++++++++++++++++++++++++++ net/sunrpc/auth_gss/auth_gss.c | 48 ++++++++++++++++++++++++++-------------- net/sunrpc/xprtrdma/rpc_rdma.c | 4 ++- 4 files changed, 70 insertions(+), 21 deletions(-)
Here's more -rc fodder. Comments welcome.
include/linux/sunrpc/auth.h +3 -2
@@ -76,7 +76,7 @@ struct rpc_auth {unsigned int au_verfsize;/* size of reply verifier */ unsigned int au_ralign;/* words before UL header */ -unsigned int au_flags; +unsigned long au_flags;const struct rpc_authops *au_ops;rpc_authflavor_t au_flavor;/* pseudoflavor (note may * differ from the flavor in
@@ -89,7 +89,8 @@ struct rpc_auth { };/* rpc_auth au_flags */ -#define RPCAUTH_AUTH_DATATOUCH 0x00000002 +#define RPCAUTH_AUTH_DATATOUCH (1) +#define RPCAUTH_AUTH_UPDATE_SLACK (2)struct rpc_auth_create_args {rpc_authflavor_t pseudoflavor;
include/trace/events/rpcgss.h +34 -0
@@ -268,6 +268,40 @@ __entry->ret ? "" : "un") ); +TRACE_EVENT (rpcgss_update_slack, +TP_PROTO ( + const struct rpc_task *task, + const struct rpc_auth *auth + ), + +TP_ARGS (task, auth), + +TP_STRUCT__entry ( + __field(unsigned int, task_id) + __field(unsigned int, client_id) + __field(u32, xid) + __field(const void *, auth) + __field(unsigned int, rslack) + __field(unsigned int, ralign) + __field(unsigned int, verfsize) + ), + +TP_fast_assign ( + __entry->task_id = task->tk_pid; + __entry->client_id = task->tk_client->cl_clid; + __entry->xid = be32_to_cpu(task->tk_rqstp->rq_xid); + __entry->auth = auth; + __entry->rslack = auth->au_rslack; + __entry->ralign = auth->au_ralign; + __entry->verfsize = auth->au_verfsize; + ), + +TP_printk ("task:%u@%u xid=0x%08x auth=%p rslack=%u ralign=%u verfsize=%u\n" , + __entry->task_id, __entry->client_id, __entry->xid, + __entry->auth, __entry->rslack, __entry->ralign, + __entry->verfsize) +); +/** ** gssd upcall related trace events **/
net/sunrpc/auth_gss/auth_gss.c +31 -17
108 lines not on this page · raw message
net/sunrpc/xprtrdma/rpc_rdma.c +2 -2
@@ -911,8 +911,8 @@ inline int rpcrdma_prepare_send_sges(struct rpcrdma_xprt *r_xprt,* or privacy, direct data placement of individual data items * is not allowed. */ - ddp_allowed = !(rqst->rq_cred->cr_auth->au_flags & -RPCAUTH_AUTH_DATATOUCH ); + ddp_allowed = !test_bit (RPCAUTH_AUTH_DATATOUCH , + &rqst->rq_cred->cr_auth->au_flags);/* * Chunks needed for results?