class: add class_has_file_ns() helper function
Subsystems (3)
PATCH v2 1/3 class: add class_has_file_ns() helper function
The new helper function is to check whether the class file is existing or not. This function will be used by networking stack to check "/sys/class/net/*" file.
---
v1 -> v2:
- Implement class_has_file_ns() instead of class_find_and_get_file_ns().
- Change headline.
- Add kernel documentation comment.
drivers/base/class.c | 22 ++++++++++++++++++++++ include/linux/device/class.h | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-)
drivers/base/class.c +22 -0
@@ -105,6 +105,28 @@ void class_remove_file_ns(struct class *cls, const struct class_attribute *attr,sysfs_remove_file_ns (&cls->p->subsys.kobj, &attr->attr, ns); } +/** +* class_has_file_ns - check whether file is existing or not +* @cls: the compatibility class +* @name: name to look for +* @ns: the namespace tag to use +*/ +bool class_has_file_ns (struct class *cls,const char *name, +const void *ns) +{ +struct kernfs_node *kn =NULL ; + +if (cls) { + kn =kernfs_find_and_get_ns (cls->p->subsys.kobj.sd, name, ns); +if (kn) { +kernfs_put (kn); +return true; + } + } +return false; +} +EXPORT_SYMBOL_GPL (class_has_file_ns); +static struct class *class_get (struct class *cls) {if (cls)
include/linux/device/class.h +2 -1
@@ -209,7 +209,8 @@ extern int __must_check class_create_file_ns(struct class *class,extern void class_remove_file_ns (struct class *class,const struct class_attribute *attr,const void *ns); - +bool class_has_file_ns (struct class *cls,const char *name, +const void *ns);static inline int __must_check class_create_file (struct class *class,const struct class_attribute *attr) {
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 24 lines · Taehee Yoo
The new helper function is to check whether the class file is existing or not. This function will be used by networking stack to check "
/sys/class/net/*" file.Reported-by [email protected]Fixes b76cdba9cdb2 ("[PATCH] bonding: add sysfs functionality to bonding (large)")Signed-off-by Taehee Yoo <[email protected]>---
v1 -> v2:
- Implementclass_has_file_ns()instead ofclass_find_and_get_file_ns().
- Change headline.
- Add kernel documentation comment.drivers/base/class.c | 22 ++++++++++++++++++++++ include/linux/device/class.h | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-)drivers/base/class.c +0
-0@@ -105,6 +105,28 @@ void class_remove_file_ns(struct class *cls, const struct class_attribute *attr,sysfs_remove_file_ns (&cls->p->subsys.kobj, &attr->attr, ns);
drivers/base/class.c void class_remove_file_ns(struct class *cls, const struct class_attribute *attr, · line 115
Quoted 10 lines
drivers/base/class.c +8
-0} +/** +* class_has_file_ns - check whether file is existing or not +* @cls: the compatibility class +* @name: name to look for +* @ns: the namespace tag to use +*/ +bool class_has_file_ns (struct class *cls,const char *name, +const void *ns)
Why would you use this? And what happens if the file shows up, or goes away, instantly after this call is made?
This feels very broken.
greg k-h
Quoted 1 line · Greg KH
Hi Greg,
Thank you for your review!
Quoted 39 lines · Taehee Yoo
Quoted 24 lines
The new helper function is to check whether the class file is existing or not. This function will be used by networking stack to check "
/sys/class/net/*" file.Reported-by [email protected]Fixes b76cdba9cdb2 ("[PATCH] bonding: add sysfs functionality to bonding (large)")Signed-off-by Taehee Yoo <[email protected]>---
v1 -> v2:
- Implementclass_has_file_ns()instead ofclass_find_and_get_file_ns().
- Change headline.
- Add kernel documentation comment.drivers/base/class.c | 22 ++++++++++++++++++++++ include/linux/device/class.h | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-)drivers/base/class.c +0
-0@@ -105,6 +105,28 @@ void class_remove_file_ns(struct class *cls, const struct class_attribute *attr,sysfs_remove_file_ns (&cls->p->subsys.kobj, &attr->attr, ns);drivers/base/class.c void class_remove_file_ns(struct class *cls, const struct class_attribute *attr, · line 115
Quoted 10 lines
drivers/base/class.c +8
-0} +/** +* class_has_file_ns - check whether file is existing or not +* @cls: the compatibility class +* @name: name to look for +* @ns: the namespace tag to use +*/ +bool class_has_file_ns (struct class *cls,const char *name, +const void *ns)Why would you use this? And what happens if the file shows up, or goes away, instantly after this call is made?
Quoted 2 lines
This feels very broken.
Ah, I missed considering other usescases.
If other users don't use locks, this function would return incorrect information. The problem seems to become from that this function calls kernfs_put().
Thanks a lot!
Taehee Yoo